Sign upLogin

iZettle/ninetails

View on GitHub
Star
app/controllers/ninetails/sections_controller.rb

Summary

Maintainability
A
0 mins
Test Coverage

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

      unless @section.valid?
Severity: Minor
Found in app/controllers/ninetails/sections_controller.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

      unless @section.valid?
Severity: Minor
Found in app/controllers/ninetails/sections_controller.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

There are no issues that match your filters.

Category
Status