src/birdears/questionbase.py
Function __init__
has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring. Open
Open
def __init__(self, mode='major', tonic='C', octave=4, descending=False,
chromatic=False, n_octaves=1, valid_intervals=CHROMATIC_TYPE,
user_durations=None, prequestion_method=None,
resolution_method=None, default_durations=None,
*args, **kwargs):
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function __init__
has 13 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
def __init__(self, mode='major', tonic='C', octave=4, descending=False,
Function get_valid_pitches
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
Open
def get_valid_pitches(scale, valid_intervals=CHROMATIC_TYPE):
tonic_pitch = scale[0]
valid_scale = list()
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Consider simplifying this complex logical expression. Open
Open
if isinstance(octave, str) and any(el in octave for el in ('R', 'r')):
self.octave = randrange(3, 6)
elif isinstance(octave, str) and ',' in octave:
octave = octave.replace(' ', '')
octave = choice(octave.split(','))