Sign upLogin

iagopiimenta/activestorage_legacy

View on GitHub
Star
lib/active_storage/verifier.rb

Summary

Maintainability
A
45 mins
Test Coverage
B
89%

Method verified has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def verified(signed_message, purpose: nil, **)
    if valid_message?(signed_message)
      begin
        data = signed_message.split("--".freeze)[0]
        message = ActiveSupport::MessagesMetadata.verify(decode(data), purpose)
Severity: Minor
Found in lib/active_storage/verifier.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Open

require 'active_storage/messages_metadata'
Severity: Minor
Found in lib/active_storage/verifier.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Use 2 (not 0) spaces for rails indentation.
Open

  def encode(data)
Severity: Minor
Found in lib/active_storage/verifier.rb by rubocop

This cops checks for indentation that doesn't use the specified number of spaces.

See also the IndentationConsistency cop which is the companion to this one.

Example:

# bad
class A
 def test
  puts 'hello'
 end
end

# good
class A
  def test
    puts 'hello'
  end
end

Example: IgnoredPatterns: ['^\s*module']

# bad
module A
class B
  def test
  puts 'hello'
  end
end
end

# good
module A
class B
  def test
    puts 'hello'
  end
end
end

There are no issues that match your filters.

Category
Status