Sign upLogin

iainbeeston/nickel

View on GitHub
Star
lib/nickel/construct_interpreter.rb

Summary

Maintainability
C
1 day
Test Coverage

Method occ_base_opts_from_wrappers has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    def occ_base_opts_from_wrappers
      base_opts = {}
      # Must do type 0 and 1 wrappers first, imagine something like
      # "every friday starting next friday for 6 months".
      @wci.each do |wi|
Severity: Minor
Found in lib/nickel/construct_interpreter.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class ConstructInterpreter has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

  class ConstructInterpreter
    attr_reader :occurrences, :constructs, :curdate

    def initialize(constructs, curdate)
      @constructs = constructs
Severity: Minor
Found in lib/nickel/construct_interpreter.rb - About 2 hrs to fix

    Method occ_base_opts_from_wrappers has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def occ_base_opts_from_wrappers
      base_opts = {}
      # Must do type 0 and 1 wrappers first, imagine something like
      # "every friday starting next friday for 6 months".
      @wci.each do |wi|
    Severity: Minor
    Found in lib/nickel/construct_interpreter.rb - About 1 hr to fix

      Method initialize_sorted_time_map has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def initialize_sorted_time_map
      # Sorted time map has date/datespan/recurrence construct indices as keys, and
      # an array of time/timespan indices as values.
      @sorted_time_map = {}
      Severity: Minor
      Found in lib/nickel/construct_interpreter.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                  base_opts[:start_date] = case @constructs[wi].wrapper_type
                                     when 2 then base_opts[:end_date].sub_days(@constructs[wi].wrapper_length)
                                     when 3 then base_opts[:end_date].sub_weeks(@constructs[wi].wrapper_length)
                                     when 4 then base_opts[:end_date].sub_months(@constructs[wi].wrapper_length)
                                     end
      Severity: Major
      Found in lib/nickel/construct_interpreter.rb - About 45 mins to fix

        Method finalize_timespan_constructs has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def finalize_timespan_constructs(guess = false)
      @tsci.each do |i|
        st, et = @constructs[i].start_time, @constructs[i].end_time
        if st.firm && et.firm
          next  # nothing to do if start and end times are both firm
        Severity: Minor
        Found in lib/nickel/construct_interpreter.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method create_occurrence_for_each_time_in_time_map has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def create_occurrence_for_each_time_in_time_map(occ_base, dindex, &block)
      if !@sorted_time_map[dindex].empty?
        @sorted_time_map[dindex].each do |tindex|   # tindex may be time index or time span index
          occ = occ_base.dup
          occ.start_time = start_time_from_tindex(tindex)
        Severity: Minor
        Found in lib/nickel/construct_interpreter.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    base_opts[:start_date] = case @constructs[wi].wrapper_type
                                     when 2 then base_opts[:end_date].sub_days(@constructs[wi].wrapper_length)
                                     when 3 then base_opts[:end_date].sub_weeks(@constructs[wi].wrapper_length)
                                     when 4 then base_opts[:end_date].sub_months(@constructs[wi].wrapper_length)
        Severity: Minor
        Found in lib/nickel/construct_interpreter.rb and 1 other location - About 45 mins to fix
        lib/nickel/construct_interpreter.rb on lines 325..328

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 41.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    base_opts[:end_date] = case @constructs[wi].wrapper_type
                                   when 2 then base_opts[:start_date].add_days(@constructs[wi].wrapper_length)
                                   when 3 then base_opts[:start_date].add_weeks(@constructs[wi].wrapper_length)
                                   when 4 then base_opts[:start_date].add_months(@constructs[wi].wrapper_length)
        Severity: Minor
        Found in lib/nickel/construct_interpreter.rb and 1 other location - About 45 mins to fix
        lib/nickel/construct_interpreter.rb on lines 331..334

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 41.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status