Sign upLogin

ianadiwibowo/central-park

View on GitHub
Star

Showing 10 of 10 total issues

Function isMatch has a Cognitive Complexity of 37 (exceeds 20 allowed). Consider refactoring.
Open

func isMatch(s string, p string) bool {
    stringIndex := 0
    currentChar := ""

    patternIndex := 0
Severity: Minor
Found in leetcode/10_regular_expression_matching/10_regular_expression_matching.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function myAtoi has 66 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func myAtoi(s string) int {
    currentIndex := 0

    // Step 1: Leading space
    for _, c := range s {
Severity: Minor
Found in leetcode/08_string_to_integer_atoi/08_string_to_integer_atoi.go - About 1 hr to fix

    Function myAtoi has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
    Open

    func myAtoi(s string) int {
    currentIndex := 0

    // Step 1: Leading space
    for _, c := range s {
    Severity: Minor
    Found in leetcode/08_string_to_integer_atoi/08_string_to_integer_atoi.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function main has 58 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func main() {
    arr_cases := [][][]int32{
        {
            {1, 1, 1, 0, 0, 0},
            {0, 1, 0, 0, 0, 0},
    Severity: Minor
    Found in hackerrank/arrays/two_d_array_ds/main.go - About 1 hr to fix

      Function main has 54 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func main() {
    queries_cases := [][][]int32{
        {
            {1, 1},
            {2, 2},
      Severity: Minor
      Found in hackerrank/dictionaries_and_hashmaps/frequency_queries/main.go - About 1 hr to fix

        Function isMatch has 52 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func isMatch(s string, p string) bool {
    stringIndex := 0
    currentChar := ""

    patternIndex := 0
        Severity: Minor
        Found in leetcode/10_regular_expression_matching/10_regular_expression_matching.go - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func main() {
    s_cases := []string{
        "aba",
        "aba",
        "aba",
          Severity: Minor
          Found in hackerrank/warm_up_challenges/repeated_string/main.go and 1 other location - About 50 mins to fix
          hackerrank/dictionaries_and_hashmaps/two_strings/main.go on lines 20..62

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 120.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func main() {
    s1_cases := []string{
        "hello",
        "hi",
        "wouldyoulikefries",
          Severity: Minor
          Found in hackerrank/dictionaries_and_hashmaps/two_strings/main.go and 1 other location - About 50 mins to fix
          hackerrank/warm_up_challenges/repeated_string/main.go on lines 22..64

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 120.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function myAtoi has 7 return statements (exceeds 4 allowed).
          Open

          func myAtoi(s string) int {
    currentIndex := 0

    // Step 1: Leading space
    for _, c := range s {
          Severity: Major
          Found in leetcode/08_string_to_integer_atoi/08_string_to_integer_atoi.go - About 45 mins to fix

            Method common_child has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            def common_child(s1, s2)
  s1_a = s1.chars
  s2_a = s2.chars

  # Remove non-shared characters
            Severity: Minor
            Found in hackerrank/string_manipulation/common_child/main.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language