Sign upLogin

ianheggie/cruisecontrol.rb

View on GitHub
Star
app/models/build.rb

Summary

Maintainability
D
1 day
Test Coverage

Class Build has 49 methods (exceeds 20 allowed). Consider refactoring.
Open

class Build
  include CommandLine

  class ConfigError < StandardError; end
Severity: Minor
Found in app/models/build.rb - About 6 hrs to fix

    File build.rb has 265 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class Build
  include CommandLine

  class ConfigError < StandardError; end
    Severity: Minor
    Found in app/models/build.rb - About 2 hrs to fix

      Method run has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

        def run
    build_log = artifact('build.log')
    build_log_path = build_log.expand_path.to_s
    artifact('cruise_config.rb').open('w') {|f| f << @project.config_file_content }
      Severity: Minor
      Found in app/models/build.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method run has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def run
    build_log = artifact('build.log')
    build_log_path = build_log.expand_path.to_s
    artifact('cruise_config.rb').open('w') {|f| f << @project.config_file_content }
      Severity: Minor
      Found in app/models/build.rb - About 1 hr to fix

        Method add_release_label has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def add_release_label(to_revision , label)
    return false if ( to_revision.nil? or label.to_s.strip.empty? )
    release_label_log = artifact('release_label.log')
    release_label_log_path = release_label_log.expand_path.to_s
    begin
        Severity: Minor
        Found in app/models/build.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            begin
      in_clean_environment_on_local_copy do
        ENV['RELEASE_REVISION'] = to_revision 
        ENV['RELEASE_LABEL'] = label
        execute "rake add_release_tag --TRACE" , :stdout => release_label_log_path, :stderr => release_label_log_path, :env => project.environment
        Severity: Minor
        Found in app/models/build.rb and 1 other location - About 50 mins to fix
        app/models/build.rb on lines 80..90

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            begin
      in_clean_environment_on_local_copy do
        ENV['RELEASE_NOTE_FROM'] = from_revision 
        ENV['RELEASE_NOTE_TO'] = to_revision
        execute "rake send_release_note --TRACE" , :stdout => release_note_log_path, :stderr => release_note_log_path, :env => project.environment
        Severity: Minor
        Found in app/models/build.rb and 1 other location - About 50 mins to fix
        app/models/build.rb on lines 97..107

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 43.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status