Sign upLogin

ianheggie/cruisecontrol.rb

View on GitHub
Star
daemon/daemon_helper.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method stop has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def stop
  failed = false
  cruise_pid = read_cruise_pid
  unless cruise_pid
    error_msg = "unable to read cruisecontrol.rb pid file #{cruise_pid_file}, cannot stop"
Severity: Minor
Found in daemon/daemon_helper.rb - About 1 hr to fix

    Method stop has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    def stop
  failed = false
  cruise_pid = read_cruise_pid
  unless cruise_pid
    error_msg = "unable to read cruisecontrol.rb pid file #{cruise_pid_file}, cannot stop"
    Severity: Minor
    Found in daemon/daemon_helper.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method start has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def start(start_cmd)
  cmd = start_cmd || "cd #{CRUISE_HOME} && ./cruise start -d"
  log(:env, ENV.inspect)

  # remove cruise pid file if process is no longer running
    Severity: Minor
    Found in daemon/daemon_helper.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status