ianheggie/cruisecontrol.rb

View on GitHub
lib/builder_plugins/jabber_notifier.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method notify_of_build_outcome has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def notify_of_build_outcome(build, fixed = nil)
    if @subscribers.empty?
      CruiseControl::Log.debug("Jabber notifier: no subscribers registered")
    else
      status = if build.failed?
Severity: Minor
Found in lib/builder_plugins/jabber_notifier.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method notify has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def notify(message)
    #connect
    begin
      CruiseControl::Log.debug("Jabber notifier: sending notice: '#{message}'")
      @subscribers.each do |subscriber|
Severity: Minor
Found in lib/builder_plugins/jabber_notifier.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status