ibudasov/php7-iptc-manager

View on GitHub
src/Manager.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '150', column '23').
Open

            throw new \Exception('Can not write IPTC tags to file: '.$this->pathToFile);
Severity: Minor
Found in src/Manager.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '165', column '23').
Open

            throw new \InvalidArgumentException(
Severity: Minor
Found in src/Manager.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '177', column '23').
Open

            throw new \InvalidArgumentException('File not found');
Severity: Minor
Found in src/Manager.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '85', column '27').
Open

                throw new \LogicException(
Severity: Minor
Found in src/Manager.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '108', column '19').
Open

        throw new \InvalidArgumentException(
Severity: Minor
Found in src/Manager.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Define and throw a dedicated exception instead of using a generic one.
Open

            throw new \Exception('Can not write IPTC tags to file: '.$this->pathToFile);
Severity: Major
Found in src/Manager.php by sonar-php

If you throw a general exception type, such as ErrorException, RuntimeException, or Exception in a library or framework, it forces consumers to catch all exceptions, including unknown exceptions that they do not know how to handle.

Instead, either throw a subtype that already exists in the Standard PHP Library, or create your own type that derives from Exception.

Noncompliant Code Example

throw new Exception();  // Noncompliant

Compliant Solution

throw new InvalidArgumentException();
// or
throw new UnexpectedValueException();

See

Avoid unused local variables such as '$key'.
Open

        foreach ($this->tags as $key => $existingTag) {
Severity: Minor
Found in src/Manager.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Avoid excessively long variable names like $updatedBinaryFileContent. Keep variable name length under 20.
Open

        $updatedBinaryFileContent = $this->image->writeIptcTags($this->pathToFile, $binaryString);
Severity: Minor
Found in src/Manager.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

There are no issues that match your filters.

Category
Status