icanhazstring/systemctl-php

View on GitHub

Showing 11 of 11 total issues

SystemCtl has 29 functions (exceeds 20 allowed). Consider refactoring.
Open

class SystemCtl
{
    /** @var string systemctl binary path */
    private static $binary = '/bin/systemctl';

Severity: Minor
Found in src/SystemCtl.php - About 3 hrs to fix

    File SystemCtl.php has 264 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    namespace icanhazstring\SystemCtl;
    
    use icanhazstring\SystemCtl\Command\CommandDispatcherInterface;
    Severity: Minor
    Found in src/SystemCtl.php - About 2 hrs to fix

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

          public function getSlice(string $name): Slice
          {
              $units = $this->listUnits($name, [Slice::UNIT]);
      
              $unitName = $this->searchForUnitInUnits($name, $units);
      Severity: Major
      Found in src/SystemCtl.php and 8 other locations - About 40 mins to fix
      src/SystemCtl.php on lines 181..192
      src/SystemCtl.php on lines 213..224
      src/SystemCtl.php on lines 245..256
      src/SystemCtl.php on lines 309..320
      src/SystemCtl.php on lines 341..352
      src/SystemCtl.php on lines 423..434
      src/SystemCtl.php on lines 455..466
      src/SystemCtl.php on lines 488..499

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

          public function getMount(string $name): Mount
          {
              $units = $this->listUnits($name, [Mount::UNIT]);
      
              $unitName = $this->searchForUnitInUnits($name, $units);
      Severity: Major
      Found in src/SystemCtl.php and 8 other locations - About 40 mins to fix
      src/SystemCtl.php on lines 181..192
      src/SystemCtl.php on lines 213..224
      src/SystemCtl.php on lines 245..256
      src/SystemCtl.php on lines 277..288
      src/SystemCtl.php on lines 309..320
      src/SystemCtl.php on lines 341..352
      src/SystemCtl.php on lines 423..434
      src/SystemCtl.php on lines 455..466

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

          public function getTarget(string $name): Target
          {
              $units = $this->listUnits($name, [Target::UNIT]);
      
              $unitName = $this->searchForUnitInUnits($name, $units);
      Severity: Major
      Found in src/SystemCtl.php and 8 other locations - About 40 mins to fix
      src/SystemCtl.php on lines 181..192
      src/SystemCtl.php on lines 213..224
      src/SystemCtl.php on lines 245..256
      src/SystemCtl.php on lines 277..288
      src/SystemCtl.php on lines 341..352
      src/SystemCtl.php on lines 423..434
      src/SystemCtl.php on lines 455..466
      src/SystemCtl.php on lines 488..499

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

          public function getAutomount(string $name): Automount
          {
              $units = $this->listUnits($name, [Automount::UNIT]);
      
              $unitName = $this->searchForUnitInUnits($name, $units);
      Severity: Major
      Found in src/SystemCtl.php and 8 other locations - About 40 mins to fix
      src/SystemCtl.php on lines 181..192
      src/SystemCtl.php on lines 213..224
      src/SystemCtl.php on lines 245..256
      src/SystemCtl.php on lines 277..288
      src/SystemCtl.php on lines 309..320
      src/SystemCtl.php on lines 341..352
      src/SystemCtl.php on lines 423..434
      src/SystemCtl.php on lines 488..499

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

          public function getTimer(string $name): Timer
          {
              $units = $this->listUnits($name, [Timer::UNIT]);
      
              $unitName = $this->searchForUnitInUnits($name, $units);
      Severity: Major
      Found in src/SystemCtl.php and 8 other locations - About 40 mins to fix
      src/SystemCtl.php on lines 213..224
      src/SystemCtl.php on lines 245..256
      src/SystemCtl.php on lines 277..288
      src/SystemCtl.php on lines 309..320
      src/SystemCtl.php on lines 341..352
      src/SystemCtl.php on lines 423..434
      src/SystemCtl.php on lines 455..466
      src/SystemCtl.php on lines 488..499

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

          public function getDevice(string $name): Device
          {
              $units = $this->listUnits($name, [Device::UNIT]);
      
              $unitName = $this->searchForUnitInUnits($name, $units);
      Severity: Major
      Found in src/SystemCtl.php and 8 other locations - About 40 mins to fix
      src/SystemCtl.php on lines 181..192
      src/SystemCtl.php on lines 213..224
      src/SystemCtl.php on lines 245..256
      src/SystemCtl.php on lines 277..288
      src/SystemCtl.php on lines 309..320
      src/SystemCtl.php on lines 341..352
      src/SystemCtl.php on lines 455..466
      src/SystemCtl.php on lines 488..499

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

          public function getScope(string $name): Scope
          {
              $units = $this->listUnits($name, [Scope::UNIT]);
      
              $unitName = $this->searchForUnitInUnits($name, $units);
      Severity: Major
      Found in src/SystemCtl.php and 8 other locations - About 40 mins to fix
      src/SystemCtl.php on lines 181..192
      src/SystemCtl.php on lines 213..224
      src/SystemCtl.php on lines 277..288
      src/SystemCtl.php on lines 309..320
      src/SystemCtl.php on lines 341..352
      src/SystemCtl.php on lines 423..434
      src/SystemCtl.php on lines 455..466
      src/SystemCtl.php on lines 488..499

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

          public function getSocket(string $name): Socket
          {
              $units = $this->listUnits($name, [Socket::UNIT]);
      
              $unitName = $this->searchForUnitInUnits($name, $units);
      Severity: Major
      Found in src/SystemCtl.php and 8 other locations - About 40 mins to fix
      src/SystemCtl.php on lines 181..192
      src/SystemCtl.php on lines 245..256
      src/SystemCtl.php on lines 277..288
      src/SystemCtl.php on lines 309..320
      src/SystemCtl.php on lines 341..352
      src/SystemCtl.php on lines 423..434
      src/SystemCtl.php on lines 455..466
      src/SystemCtl.php on lines 488..499

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

          public function getSwap(string $name): Swap
          {
              $units = $this->listUnits($name, [Swap::UNIT]);
      
              $unitName = $this->searchForUnitInUnits($name, $units);
      Severity: Major
      Found in src/SystemCtl.php and 8 other locations - About 40 mins to fix
      src/SystemCtl.php on lines 181..192
      src/SystemCtl.php on lines 213..224
      src/SystemCtl.php on lines 245..256
      src/SystemCtl.php on lines 277..288
      src/SystemCtl.php on lines 309..320
      src/SystemCtl.php on lines 423..434
      src/SystemCtl.php on lines 455..466
      src/SystemCtl.php on lines 488..499

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language