Sign upLogin

icostan/cryptos-ruby

View on GitHub
Star

Showing 7 of 7 total issues

File wallet.rb has 259 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'zlib'

module Cryptos
  module Monero
    # Deterministic wallet
Severity: Minor
Found in lib/cryptos/monero/wallet.rb - About 2 hrs to fix

Method run has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

      def run(args, run_mode: :system, debug: false)
        cmd = "#{program} -#{network} #{args}"
        puts "==> #{cmd} run_mode=#{run_mode} verbose=#{debug}" if debug || verbose
        case run_mode
        when :inline
Severity: Minor
Found in lib/cryptos/connectors/cli.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sign_atomic_swap has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def sign_atomic_swap(secret, secret_hash, to_address, locktime, from_address, sighash_type = 0x01)
Severity: Minor
Found in lib/cryptos/transaction.rb - About 45 mins to fix

Method ec_add has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def ec_add(ax, ay, bx, by, pn)
Severity: Minor
Found in lib/cryptos/elliptic_curve.rb - About 35 mins to fix

Method atomic_swap has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def self.atomic_swap(secret_hash, to_address, locktime, from_address, amount)
Severity: Minor
Found in lib/cryptos/output.rb - About 35 mins to fix

Method bignum_to_bytes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def bignum_to_bytes(n, length=nil, stringify=true, little=false)
        a = []
        while n > 0
          a << (n & 0xFF)
          n >>= 8
Severity: Minor
Found in lib/cryptos/utils/bytes.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method from_mnemonic has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def self.from_mnemonic(mnemonic)
        words = mnemonic.split
        raise ArgumentError, "invalid mnemonic size: expected=25, got=#{words.length}" if words.length != 25

        last_word = words.pop
Severity: Minor
Found in lib/cryptos/monero/wallet.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language