idealo/php-rdkafka-ffi

View on GitHub
src/RdKafka/Admin/Client.php

Summary

Maintainability
F
1 wk
Test Coverage
B
83%

File Client.php has 309 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace RdKafka\Admin;
Severity: Minor
Found in src/RdKafka/Admin/Client.php - About 3 hrs to fix

    Client has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Client
    {
        private RdKafka $kafka;
        private int $waitForResultEventTimeoutMs = 50;
    
    
    Severity: Minor
    Found in src/RdKafka/Admin/Client.php - About 2 hrs to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          public function deleteTopics(array $topics, ?DeleteTopicsOptions $options = null): array
          {
              $this->assertArray($topics, 'topics', DeleteTopic::class);
      
              $queue = Queue::fromRdKafka($this->kafka);
      Severity: Major
      Found in src/RdKafka/Admin/Client.php and 2 other locations - About 1 day to fix
      src/RdKafka/Admin/Client.php on lines 136..168
      src/RdKafka/Admin/Client.php on lines 175..207

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 290.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function alterConfigs(array $resources, ?AlterConfigsOptions $options = null): array
          {
              $this->assertArray($resources, 'resources', ConfigResource::class);
      
              $queue = Queue::fromRdKafka($this->kafka);
      Severity: Major
      Found in src/RdKafka/Admin/Client.php and 1 other location - About 1 day to fix
      src/RdKafka/Admin/Client.php on lines 96..129

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 290.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          public function createTopics(array $topics, ?CreateTopicsOptions $options = null): array
          {
              $this->assertArray($topics, 'topics', NewTopic::class);
      
              $queue = Queue::fromRdKafka($this->kafka);
      Severity: Major
      Found in src/RdKafka/Admin/Client.php and 2 other locations - About 1 day to fix
      src/RdKafka/Admin/Client.php on lines 136..168
      src/RdKafka/Admin/Client.php on lines 214..246

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 290.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          public function createPartitions(array $partitions, ?CreatePartitionsOptions $options = null): array
          {
              $this->assertArray($partitions, 'partitions', NewPartitions::class);
      
              $queue = Queue::fromRdKafka($this->kafka);
      Severity: Major
      Found in src/RdKafka/Admin/Client.php and 2 other locations - About 1 day to fix
      src/RdKafka/Admin/Client.php on lines 175..207
      src/RdKafka/Admin/Client.php on lines 214..246

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 290.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function describeConfigs(array $resources, ?DescribeConfigsOptions $options = null): array
          {
              $this->assertArray($resources, 'resources', ConfigResource::class);
      
              $queue = Queue::fromRdKafka($this->kafka);
      Severity: Major
      Found in src/RdKafka/Admin/Client.php and 1 other location - About 1 day to fix
      src/RdKafka/Admin/Client.php on lines 56..89

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 290.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status