Sign upLogin

idlesign/django-xross

View on GitHub
Star

Showing 10 of 10 total issues

Function xross has 281 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var xross = (function () {
    "use strict";

    return {
Severity: Major
Found in xross/static/js/xross/xross.js - About 1 day to fix

    Function xross has a Cognitive Complexity of 67 (exceeds 5 allowed). Consider refactoring.
    Open

    var xross = (function () {
    "use strict";

    return {
    Severity: Minor
    Found in xross/static/js/xross/xross.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function xross_view has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
    Open

    def xross_view(*op_functions: Callable) -> Callable:
    """This decorator should be used to decorate application views that require xross functionality.

    :param list op_functions: operations (functions, methods) responsible for handling xross requests.
    Severity: Minor
    Found in xross/utils.py - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File xross.js has 284 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * django-xross
 * https://github.com/idlesign/django-xross
 *
 * Distributed under BSD License.
    Severity: Minor
    Found in xross/static/js/xross/xross.js - About 2 hrs to fix

      Function attach has 58 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                      attach: function ($el, defaultParams) {
                    var operation = $el.attr('id'),
                        elSelector = '#' + operation,

                        // Populate params with those from element's data attributes.
      Severity: Major
      Found in xross/static/js/xross/xross.js - About 2 hrs to fix

        Function dispatch has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            def dispatch(self):

        if not self.request.is_ajax():
            return
        Severity: Minor
        Found in xross/utils.py - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        get_ajax_test_base('auto event button',
    function () {
        xross.describe('#btn');
        $('#btn').trigger('click');
    },
        Severity: Major
        Found in tests_js/tests.js and 1 other location - About 1 hr to fix
        tests_js/tests.js on lines 153..160

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 68.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        get_ajax_test_base('auto event link',
    function () {
        xross.describe('#a');
        $('#a').trigger('click');
    },
        Severity: Major
        Found in tests_js/tests.js and 1 other location - About 1 hr to fix
        tests_js/tests.js on lines 143..150

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 68.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function describe has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                describe: function (el, handlerName, params) {
            if (typeof handlerName !== 'string') {
                params = handlerName;
                handlerName = this._defaultHandler;
            }
        Severity: Minor
        Found in xross/static/js/xross/xross.js - About 1 hr to fix

          Function _get_handler_args has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              def _get_handler_args(cls, handler: Callable) -> Tuple[List[str], List[str]]:
        signature_params = signature(handler).parameters

        args = []
        kwargs = []
          Severity: Minor
          Found in xross/utils.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language