Showing 61 of 61 total issues
Method ScanInterceptor.Handle
has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring. Open
Open
func (c *ScanInterceptor) Handle(w http.ResponseWriter, req *http.Request, body io.Reader) bool {
//
// Don't care unless we have some content. When the length is unknown, the length will be -1,
// but we attempt anyway to read the body.
//
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method Forwarder.HandleRequest
has 55 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func (f *Forwarder) HandleRequest(w http.ResponseWriter, req *http.Request) {
// Catch panics and return a 500 Internal Server Error
defer func() {
if err := recover(); err != nil {
f.logger.Printf("ERROR %s", err)
Method ScanInterceptor.Handle
has 55 lines of code (exceeds 50 allowed). Consider refactoring. Open
Open
func (c *ScanInterceptor) Handle(w http.ResponseWriter, req *http.Request, body io.Reader) bool {
//
// Don't care unless we have some content. When the length is unknown, the length will be -1,
// but we attempt anyway to read the body.
//
Method ScanInterceptor.Handle
has 7 return statements (exceeds 4 allowed). Open
Open
func (c *ScanInterceptor) Handle(w http.ResponseWriter, req *http.Request, body io.Reader) bool {
//
// Don't care unless we have some content. When the length is unknown, the length will be -1,
// but we attempt anyway to read the body.
//
Method Forwarder.HandleRequest
has 5 return statements (exceeds 4 allowed). Open
Open
func (f *Forwarder) HandleRequest(w http.ResponseWriter, req *http.Request) {
// Catch panics and return a 500 Internal Server Error
defer func() {
if err := recover(); err != nil {
f.logger.Printf("ERROR %s", err)
exported method MultiReader.GetReadCloser should have comment or be unexported Open
Open
func (m *MultiReader) GetReadCloser() (io.ReadCloser, error) {
- Exclude checks
exported type ScratchArea should have comment or be unexported Open
Open
type ScratchArea struct {
- Exclude checks
comment on exported function NewScratchArea should be of the form "NewScratchArea ..." Open
Open
/*
- Exclude checks
if block ends with a return statement, so drop this else and outdent its block Open
Open
} else {
- Exclude checks
exported method Clamav.Scan should have comment or be unexported Open
Open
func (c *Clamav) Scan(reader io.Reader) (*Result, error) {
- Exclude checks
don't use ALL_CAPS in Go names; use CamelCase Open
Open
RES_CLEAN = "CLEAN"
- Exclude checks
package comment should be of the form "Package scratch ..." Open
Open
/*
- Exclude checks
comment on exported method ScratchArea.Cleanup should be of the form "Cleanup ..." Open
Open
/*
- Exclude checks
comment on exported type Config should be of the form "Config ..." (with optional leading article) Open
Open
// Configuration structure, designed for gcfg
- Exclude checks
exported type ApplicationConfig should have comment or be unexported Open
Open
type ApplicationConfig struct {
- Exclude checks
exported method MultiReader.ContentLength should have comment or be unexported Open
Open
func (m *MultiReader) ContentLength() int64 {
- Exclude checks
exported method Clamav.SetAddress should have comment or be unexported Open
Open
func (c *Clamav) SetAddress(url string) {
- Exclude checks
comment on exported type Engine should be of the form "Engine ..." (with optional leading article) Open
Open
/*
- Exclude checks
if block ends with a return statement, so drop this else and outdent its block Open
Open
} else {
- Exclude checks
comment on exported type Info should be of the form "Info ..." (with optional leading article) Open
Open
// JSON server information response
- Exclude checks