Sign upLogin

ifad/clammit

View on GitHub
Star

Showing 61 of 61 total issues

Method ScanInterceptor.Handle has a Cognitive Complexity of 34 (exceeds 20 allowed). Consider refactoring.
Open

func (c *ScanInterceptor) Handle(w http.ResponseWriter, req *http.Request, body io.Reader) bool {
    //
    // Don't care unless we have some content. When the length is unknown, the length will be -1,
    // but we attempt anyway to read the body.
    //
Severity: Minor
Found in scan_interceptor.go - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ScanInterceptor.Handle has 55 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (c *ScanInterceptor) Handle(w http.ResponseWriter, req *http.Request, body io.Reader) bool {
    //
    // Don't care unless we have some content. When the length is unknown, the length will be -1,
    // but we attempt anyway to read the body.
    //
Severity: Minor
Found in scan_interceptor.go - About 1 hr to fix

    Method Forwarder.HandleRequest has 55 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (f *Forwarder) HandleRequest(w http.ResponseWriter, req *http.Request) {
    // Catch panics and return a 500 Internal Server Error
    defer func() {
        if err := recover(); err != nil {
            f.logger.Printf("ERROR %s", err)
    Severity: Minor
    Found in forwarder/forwarder.go - About 1 hr to fix

      Method ScanInterceptor.Handle has 7 return statements (exceeds 4 allowed).
      Open

      func (c *ScanInterceptor) Handle(w http.ResponseWriter, req *http.Request, body io.Reader) bool {
    //
    // Don't care unless we have some content. When the length is unknown, the length will be -1,
    // but we attempt anyway to read the body.
    //
      Severity: Major
      Found in scan_interceptor.go - About 45 mins to fix

        Method Forwarder.HandleRequest has 5 return statements (exceeds 4 allowed).
        Open

        func (f *Forwarder) HandleRequest(w http.ResponseWriter, req *http.Request) {
    // Catch panics and return a 500 Internal Server Error
    defer func() {
        if err := recover(); err != nil {
            f.logger.Printf("ERROR %s", err)
        Severity: Major
        Found in forwarder/forwarder.go - About 35 mins to fix

          exported const CONTENT_LENGTH should have comment (or a comment on this block) or be unexported
          Open

              CONTENT_LENGTH = 1024 * 1024 // 1MB
          Severity: Minor
          Found in forwarder/body.go by golint

          exported var EICAR should have comment or be unexported
          Open

          var EICAR = []byte(`X5O!P%@AP[4\PZX54(P^)7CC)7}$EICAR-STANDARD-ANTIVIRUS-TEST-FILE!$H+H*`)
          Severity: Minor
          Found in main.go by golint

          exported method MultiReader.ContentLength should have comment or be unexported
          Open

          func (m *MultiReader) ContentLength() int64 {
          Severity: Minor
          Found in multireader/multireader.go by golint

          package comment should not have leading space
          Open

          /*
          Severity: Minor
          Found in scan_interceptor.go by golint

          comment on exported method Forwarder.SetLogger should be of the form "SetLogger ..."
          Open

          /*
          Severity: Minor
          Found in forwarder/forwarder.go by golint

          don't use ALL_CAPS in Go names; use CamelCase
          Open

              RES_CLEAN = "CLEAN"
          Severity: Minor
          Found in scanner/scanner.go by golint

          if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary)
          Open

              } else {
          Severity: Minor
          Found in scratch/scratch.go by golint

          don't use ALL_CAPS in Go names; use CamelCase
          Open

              CONTENT_LENGTH = 1024 * 1024 // 1MB
          Severity: Minor
          Found in forwarder/body.go by golint

          comment on exported type BodyHolder should be of the form "BodyHolder ..." (with optional leading article)
          Open

          /*
          Severity: Minor
          Found in forwarder/body.go by golint

          package comment should not have leading space
          Open

          /*
          Severity: Minor
          Found in forwarder/forwarder.go by golint

          comment on exported method Engine.Address should be of the form "Address ..."
          Open

          /*
          Severity: Minor
          Found in scanner/scanner.go by golint

          exported type ScratchArea should have comment or be unexported
          Open

          type ScratchArea struct {
          Severity: Minor
          Found in scratch/scratch.go by golint

          if block ends with a return statement, so drop this else and outdent its block
          Open

              } else {
          Severity: Minor
          Found in forwarder/forwarder.go by golint

          comment on exported type Ctx should be of the form "Ctx ..." (with optional leading article)
          Open

          // Application context
          Severity: Minor
          Found in main.go by golint

          don't use ALL_CAPS in Go names; use CamelCase
          Open

              RES_FOUND = "FOUND"
          Severity: Minor
          Found in scanner/scanner.go by golint
          Severity
          Category
          Status
          Source
          Language