Sign upLogin

ifgi-webteam/Campusplan

View on GitHub
Star

Showing 13 of 13 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

campusplanApp.controller('WohnheimeController', function($scope, $rootScope, $http) {
    $rootScope.$currentPageName = 'Wohnheime';
    $rootScope.pageTitle = 'Wohnheime';

    $scope.WohnheimeLoading = $http.get('api/wohnheime.php')
Severity: Major
Found in app/js/controllers/wohnheime.js and 1 other location - About 1 day to fix
app/js/controllers/hoersaele.js on lines 6..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 232.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

campusplanApp.controller('HoersaeleController', 
    function($scope, $rootScope, $http) {

    $rootScope.$currentPageName = 'Hoersaele';
    $rootScope.pageTitle = 'Hörsäle';
Severity: Major
Found in app/js/controllers/hoersaele.js and 1 other location - About 1 day to fix
app/js/controllers/wohnheime.js on lines 6..26

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 232.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

campusplanApp.controller('WetterController', 
    function($scope, $rootScope, $route, $routeParams, $location) {

    $scope.$route = $route;
    $scope.$location = $location;
Severity: Major
Found in app/js/controllers/wetter.js and 1 other location - About 2 hrs to fix
app/js/controllers/ulb.js on lines 5..13

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

campusplanApp.controller('UlbController', 
    function($scope, $rootScope, $route, $routeParams, $location) {

    $scope.$route = $route;
    $scope.$location = $location;
Severity: Major
Found in app/js/controllers/ulb.js and 1 other location - About 2 hrs to fix
app/js/controllers/wetter.js on lines 5..13

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function exports has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(config) {
  config.set({

    // base path that will be used to resolve all patterns (eg. files, exclude)
    basePath: '',
Severity: Minor
Found in karma.conf.js - About 1 hr to fix

    Function getRoute has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                $scope.getRoute = function(position) {
                $scope.userPosition = position;
                $scope.waitForGeolocation = false;

                $scope.routeLoading = $http.post('api/routing.php', {
    Severity: Minor
    Found in app/js/controllers/orga.js - About 1 hr to fix

      Function file_get_contents_cached has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      function file_get_contents_cached($url, $expiry=604800, $opts=array()) {
    try {
        $urlMd5 = md5($url);
        $cachedFile = "cache/".$urlMd5;
        $now = time();
      Severity: Minor
      Found in app/api/functions.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getOrgDetails has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function getOrgDetails($identifier, $lang = "de") {
    $org = "http://data.uni-muenster.de/context/".$identifier;
    $orga = sparql_get("

prefix foaf: <http://xmlns.com/foaf/0.1/>
      Severity: Minor
      Found in app/api/functions.php - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    iconBlue: {
                iconUrl: 'img/awesomemarkers-blue.png',
                iconSize: [30, 46],
                iconAnchor: [14, 43],
                popupAnchor: [1, -40],
        Severity: Major
        Found in app/js/campusplan.js and 1 other location - About 1 hr to fix
        app/js/campusplan.js on lines 50..58

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    iconGreen: {
                iconUrl: 'img/awesomemarkers-green.png',
                iconSize: [30, 46],
                iconAnchor: [14, 43],
                popupAnchor: [1, -40],
        Severity: Major
        Found in app/js/campusplan.js and 1 other location - About 1 hr to fix
        app/js/campusplan.js on lines 41..49

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method file_get_contents_cached has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function file_get_contents_cached($url, $expiry=604800, $opts=array()) {
    try {
        $urlMd5 = md5($url);
        $cachedFile = "cache/".$urlMd5;
        $now = time();
        Severity: Minor
        Found in app/api/functions.php - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              $('#content').on('show.bs.collapse', 'div.mensa-table', function(e){
        $(this).find('.fa.fa-angle-right').removeClass('fa-angle-right').addClass('fa-angle-down');
    });
          Severity: Minor
          Found in app/js/controllers/mensen.js and 1 other location - About 55 mins to fix
          app/js/controllers/mensen.js on lines 42..44

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              $('#content').on('hide.bs.collapse', 'div.mensa-table', function(e){
        $(this).find('.fa.fa-angle-down').removeClass('fa-angle-down').addClass('fa-angle-right');
    });
          Severity: Minor
          Found in app/js/controllers/mensen.js and 1 other location - About 55 mins to fix
          app/js/controllers/mensen.js on lines 39..41

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language