Sign upLogin

ifmeorg/ifme

View on GitHub
Star
app/helpers/assets_helper.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
95%

Rails.public_path is a Pathname so you can just append #read.
Open

      File.read(Rails.public_path.join(asset_path(path)))
Severity: Minor
Found in app/helpers/assets_helper.rb by rubocop

Rails.public_path is a Pathname so you can just append #read.
Open

      File.read(Rails.public_path.join(webpack_folder, path))
Severity: Minor
Found in app/helpers/assets_helper.rb by rubocop

Prefer keyword arguments for arguments with a boolean default value; use css: false instead of css = false.
Open

  def inline_file(path, css = false)
Severity: Minor
Found in app/helpers/assets_helper.rb by rubocop

Checks for places where keyword arguments can be used instead of boolean arguments when defining methods. respond_to_missing? method is allowed by default. These are customizable with AllowedMethods option.

Safety:

This cop is unsafe because changing a method signature will implicitly change behavior.

Example:

# bad
def some_method(bar = false)
  puts bar
end

# bad - common hack before keyword args were introduced
def some_method(options = {})
  bar = options.fetch(:bar, false)
  puts bar
end

# good
def some_method(bar: false)
  puts bar
end

Example: AllowedMethods: ['some_method']

# good
def some_method(bar = false)
  puts bar
end

There are no issues that match your filters.

Category
Status