Sign upLogin

igara/syonet_seven

View on GitHub
Star

Showing 138 of 138 total issues

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  useEffect(() => {
    if (process.browser) {
      (async () => {
        await requestWebpush();
        await loadCheckAuth();
Severity: Major
Found in nodejs/www/pages/login/index.tsx and 6 other locations - About 50 mins to fix
nodejs/www/pages/_error.tsx on lines 23..30
nodejs/www/pages/blogs/index.tsx on lines 32..39
nodejs/www/pages/tools/index.tsx on lines 31..38
nodejs/www/pages/tools/scraping.tsx on lines 66..73
nodejs/www/pages/tools/sound/index.tsx on lines 126..133
nodejs/www/pages/tools/ssb.tsx on lines 31..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export const sheets = (oauth2Client: GoogleAuthLibrary.OAuth2Client) => {
  return googleapis.google.sheets({
    version: "v4",
    auth: oauth2Client,
  });
Severity: Minor
Found in nodejs/api/src/libs/googleapis.ts and 1 other location - About 50 mins to fix
nodejs/api/src/libs/googleapis.ts on lines 20..25

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  useEffect(() => {
    if (process.browser) {
      (async () => {
        await requestWebpush();
        await loadCheckAuth();
Severity: Major
Found in nodejs/www/pages/_error.tsx and 6 other locations - About 50 mins to fix
nodejs/www/pages/blogs/index.tsx on lines 32..39
nodejs/www/pages/login/index.tsx on lines 33..40
nodejs/www/pages/tools/index.tsx on lines 31..38
nodejs/www/pages/tools/scraping.tsx on lines 66..73
nodejs/www/pages/tools/sound/index.tsx on lines 126..133
nodejs/www/pages/tools/ssb.tsx on lines 31..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function _getMultiFormatDateTimeOptions has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

const _getMultiFormatDateTimeOptions = (
  options: GetMultiFormatDateTimeParamOption,
): GetMultiFormatDateTimeReturnOption => {
  const newOptions: GetMultiFormatDateTimeReturnOption = {
    Date: new Date(),
Severity: Minor
Found in nodejs/api/src/libs/datetime.ts - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                if (results[i].isFinal) {
                  const text = results[results.length - 1][0].transcript;
                  jpTextElementRef.current.innerText = text;

                  logText = `${logText}
Severity: Major
Found in nodejs/www/pages/tools/speech.tsx - About 45 mins to fix

    Function _getMultiFormatDateTimeOptions has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    const _getMultiFormatDateTimeOptions = (
  options: GetMultiFormatDateTimeParamOption,
): GetMultiFormatDateTimeReturnOption => {
  const newOptions: GetMultiFormatDateTimeReturnOption = {
    Date: new Date(),
    Severity: Minor
    Found in nodejs/www/libs/datetime.ts - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      const apiGatewayManagementApi = process.env.IS_OFFLINE
    ? new AWS.ApiGatewayManagementApi({
        region: "localhost",
        endpoint: "http://localhost:9000",
      })
    Severity: Minor
    Found in nodejs/websocket/ssb/src/lambda.ts and 1 other location - About 35 mins to fix
    nodejs/websocket/ssb/src/lambda.ts on lines 64..69

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      const apiGatewayManagementApi = process.env.IS_OFFLINE
    ? new AWS.ApiGatewayManagementApi({
        region: "localhost",
        endpoint: "http://localhost:9000",
      })
    Severity: Minor
    Found in nodejs/websocket/ssb/src/lambda.ts and 1 other location - About 35 mins to fix
    nodejs/websocket/ssb/src/lambda.ts on lines 261..266

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

          return Promise.all(
        items.map(async (item) => {
          return apiGatewayManagementApi
            .postToConnection({
              ConnectionId: item.id,
    Severity: Major
    Found in nodejs/websocket/ssb/src/lambda.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return false;
      Severity: Major
      Found in nodejs/api/src/models/typeorm/helper.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return Promise.all(
        items.map(async (item) => {
          return apiGatewayManagementApi
            .postToConnection({
              ConnectionId: item.id,
        Severity: Major
        Found in nodejs/websocket/ssb/src/lambda.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            return { message: "no event." };
          Severity: Major
          Found in nodejs/websocket/ssb/src/lambda.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return Promise.all(
        items.map(async (item) => {
          return apiGatewayManagementApi
            .postToConnection({
              ConnectionId: item.id,
            Severity: Major
            Found in nodejs/websocket/ssb/src/lambda.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return Promise.all(
        items.map(async (item) => {
          return apiGatewayManagementApi
            .postToConnection({
              ConnectionId: item.id,
              Severity: Major
              Found in nodejs/websocket/ssb/src/lambda.ts - About 30 mins to fix

                Function getServerSideProps has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                export const getServerSideProps = wrapper.getServerSideProps(async context => {
  let name = context.query.name;
  name = name ? name.toString() : "";
  await context.store.dispatch<any>(getEntry.action(encodeURI(name)));
  const state: AppState = context.store.getState();
                Severity: Minor
                Found in nodejs/www/pages/blogs/hatena/[name].tsx - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function SidebarComponent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                export const SidebarComponent = () => {
  const states = useSelector((state: AppState) => state);
  const dispatch = useDispatch();

  return (
                Severity: Minor
                Found in nodejs/www/components/common/sidebar.tsx - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function authenticate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                export const authenticate = (req: any, res: any) =>
  new Promise((resolve, reject) => {
    passport.authenticate("jwt", (err, payload) => {
      if (err) reject(err);
      if (!payload) reject("not payload");
                Severity: Minor
                Found in nodejs/api/src/passport/jwt.ts - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function getServerSideProps has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                export const getServerSideProps = wrapper.getServerSideProps(async context => {
  let name = context.query.name;
  name = name ? name.toString() : "";
  await context.store.dispatch<any>(getItem.action(encodeURI(name)));
  const state: AppState = context.store.getState();
                Severity: Minor
                Found in nodejs/www/pages/blogs/qiita/[name].tsx - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language