Sign upLogin

igara/syonet_seven

View on GitHub
Star
nodejs/websocket/ssb/src/lambda.ts

Summary

Maintainability
F
3 days
Test Coverage

Function connectHandler has 156 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const connectHandler = async (event: APIGatewayEvent) => {
  const connectionId = event.requestContext.connectionId;
  if (!connectionId) return;

  const body = event.body as any;
Severity: Major
Found in nodejs/websocket/ssb/src/lambda.ts - About 6 hrs to fix

    Function connectHandler has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

    export const connectHandler = async (event: APIGatewayEvent) => {
  const connectionId = event.requestContext.connectionId;
  if (!connectionId) return;

  const body = event.body as any;
    Severity: Minor
    Found in nodejs/websocket/ssb/src/lambda.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

          return Promise.all(
        items.map(async (item) => {
          return apiGatewayManagementApi
            .postToConnection({
              ConnectionId: item.id,
    Severity: Major
    Found in nodejs/websocket/ssb/src/lambda.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return Promise.all(
        items.map(async (item) => {
          return apiGatewayManagementApi
            .postToConnection({
              ConnectionId: item.id,
      Severity: Major
      Found in nodejs/websocket/ssb/src/lambda.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

          return { message: "no event." };
        Severity: Major
        Found in nodejs/websocket/ssb/src/lambda.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return Promise.all(
        items.map(async (item) => {
          return apiGatewayManagementApi
            .postToConnection({
              ConnectionId: item.id,
          Severity: Major
          Found in nodejs/websocket/ssb/src/lambda.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return Promise.all(
        items.map(async (item) => {
          return apiGatewayManagementApi
            .postToConnection({
              ConnectionId: item.id,
            Severity: Major
            Found in nodejs/websocket/ssb/src/lambda.ts - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if (userData.webSocketStatus === WebSocketStatus.BATTLE) {
      const userDataJsonString = JSON.stringify(userData);
      const result = await dynamodb
        .scan({
          TableName: "ssbs",
              Severity: Major
              Found in nodejs/websocket/ssb/src/lambda.ts and 1 other location - About 5 hrs to fix
              nodejs/websocket/ssb/src/lambda.ts on lines 199..219

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 147.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if (userData.webSocketStatus === WebSocketStatus.DEAD) {
      const userDataJsonString = JSON.stringify(userData);

      const result = await dynamodb
        .scan({
              Severity: Major
              Found in nodejs/websocket/ssb/src/lambda.ts and 1 other location - About 5 hrs to fix
              nodejs/websocket/ssb/src/lambda.ts on lines 140..159

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 147.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    if (userData.playerType == PlayerType.MAN) {
        const content = `${userData.name} dead`;
        const url: string = process.env.DISCORD_WEBHOCK
          ? process.env.DISCORD_WEBHOCK
          : "";
              Severity: Major
              Found in nodejs/websocket/ssb/src/lambda.ts and 1 other location - About 2 hrs to fix
              nodejs/websocket/ssb/src/lambda.ts on lines 90..104

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 82.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    if (userData.playerType == PlayerType.MAN) {
        const content = `${userData.name} is fighting`;
        const url: string = process.env.DISCORD_WEBHOCK
          ? process.env.DISCORD_WEBHOCK
          : "";
              Severity: Major
              Found in nodejs/websocket/ssb/src/lambda.ts and 1 other location - About 2 hrs to fix
              nodejs/websocket/ssb/src/lambda.ts on lines 164..178

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 82.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                const dynamodb = process.env.IS_OFFLINE
    ? new AWS.DynamoDB.DocumentClient({
        region: "localhost",
        endpoint: "http://localhost:5000",
      })
              Severity: Major
              Found in nodejs/websocket/ssb/src/lambda.ts and 1 other location - About 1 hr to fix
              nodejs/websocket/ssb/src/lambda.ts on lines 71..76

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 55.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                const dynamodb = process.env.IS_OFFLINE
    ? new AWS.DynamoDB.DocumentClient({
        region: "localhost",
        endpoint: "http://localhost:5000",
      })
              Severity: Major
              Found in nodejs/websocket/ssb/src/lambda.ts and 1 other location - About 1 hr to fix
              nodejs/websocket/ssb/src/lambda.ts on lines 268..273

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 55.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                const apiGatewayManagementApi = process.env.IS_OFFLINE
    ? new AWS.ApiGatewayManagementApi({
        region: "localhost",
        endpoint: "http://localhost:9000",
      })
              Severity: Minor
              Found in nodejs/websocket/ssb/src/lambda.ts and 1 other location - About 35 mins to fix
              nodejs/websocket/ssb/src/lambda.ts on lines 261..266

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                const apiGatewayManagementApi = process.env.IS_OFFLINE
    ? new AWS.ApiGatewayManagementApi({
        region: "localhost",
        endpoint: "http://localhost:9000",
      })
              Severity: Minor
              Found in nodejs/websocket/ssb/src/lambda.ts and 1 other location - About 35 mins to fix
              nodejs/websocket/ssb/src/lambda.ts on lines 64..69

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status