Sign upLogin

igbopie/spherov2.js

View on GitHub
Star
lib/src/commands/decoder.ts

Summary

Maintainability
C
1 day
Test Coverage
C
73%

Function factory has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

export function factory(
  callback: (err: string, response?: ICommandWithRaw) => void
) {
  let msg: number[] = [];
  let checksum = 0;
Severity: Minor
Found in lib/src/commands/decoder.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function factory has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function factory(
  callback: (err: string, response?: ICommandWithRaw) => void
) {
  let msg: number[] = [];
  let checksum = 0;
Severity: Major
Found in lib/src/commands/decoder.ts - About 2 hrs to fix

    Function add has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        add(byte: number) {
      switch (byte) {
        case APIConstants.startOfPacket:
          if (msg.length !== 0) {
            init();
    Severity: Minor
    Found in lib/src/commands/decoder.ts - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

              return error('Invalid no escape char end found');
      Severity: Major
      Found in lib/src/commands/decoder.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                  return;
        Severity: Major
        Found in lib/src/commands/decoder.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                    return init();
          Severity: Major
          Found in lib/src/commands/decoder.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return error('Invalid escape char position');
            Severity: Major
            Found in lib/src/commands/decoder.ts - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status