Sign upLogin

igbopie/spherov2.js

View on GitHub
Star
lib/src/toys/r2d2.ts

Summary

Maintainability
C
1 day
Test Coverage
F
0%

Function calculateDomeAngle has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  private calculateDomeAngle(angle: number) {
    const result = new Uint8Array(2);
    switch (angle) {
      case -1:
        result[0] = 0xbf;
Severity: Minor
Found in lib/src/toys/r2d2.ts - About 1 hr to fix

    Function calculateDomeAngle has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      private calculateDomeAngle(angle: number) {
    const result = new Uint8Array(2);
    switch (angle) {
      case -1:
        result[0] = 0xbf;
    Severity: Minor
    Found in lib/src/toys/r2d2.ts - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      public setR2D2LEDColor(r: number, g: number, b: number) {
    return this.queueCommand(this.commands.userIo.setR2D2LEDColor(r, g, b));
  }
    Severity: Major
    Found in lib/src/toys/r2d2.ts and 2 other locations - About 50 mins to fix
    lib/src/toys/r2d2.ts on lines 42..46
    lib/src/toys/r2d2.ts on lines 48..50

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      public playAudioFile(idx: number): Promise<IQueuePayload> {
    return this.queueCommand(this.commands.userIo.playAudioFile(idx));
  }
    Severity: Minor
    Found in lib/src/toys/r2d2.ts and 1 other location - About 50 mins to fix
    lib/src/toys/r2d2.ts on lines 34..36

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      public playAnimation(animation: number): Promise<IQueuePayload> {
    return this.queueCommand(this.commands.userIo.playAnimation(animation));
  }
    Severity: Minor
    Found in lib/src/toys/r2d2.ts and 1 other location - About 50 mins to fix
    lib/src/toys/r2d2.ts on lines 21..23

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      public setR2D2BackLEDcolor(r: number, g: number, b: number) {
    return this.queueCommand(this.commands.userIo.setR2D2BackLEDcolor(r, g, b));
  }
    Severity: Major
    Found in lib/src/toys/r2d2.ts and 2 other locations - About 50 mins to fix
    lib/src/toys/r2d2.ts on lines 38..40
    lib/src/toys/r2d2.ts on lines 42..46

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      public setR2D2FrontLEDColor(r: number, g: number, b: number) {
    return this.queueCommand(
      this.commands.userIo.setR2D2FrontLEDColor(r, g, b)
    );
  }
    Severity: Major
    Found in lib/src/toys/r2d2.ts and 2 other locations - About 50 mins to fix
    lib/src/toys/r2d2.ts on lines 38..40
    lib/src/toys/r2d2.ts on lines 48..50

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

      public wake(): Promise<IQueuePayload> {
    return this.queueCommand(this.commands.power.wake());
  }
    Severity: Major
    Found in lib/src/toys/r2d2.ts and 10 other locations - About 35 mins to fix
    lib/src/toys/core.ts on lines 197..199
    lib/src/toys/r2d2.ts on lines 18..20
    lib/src/toys/r2d2.ts on lines 64..66
    lib/src/toys/sphero-mini.ts on lines 15..17
    lib/src/toys/sphero-mini.ts on lines 19..21
    lib/src/toys/sphero-mini.ts on lines 23..25
    lib/src/toys/sphero-mini.ts on lines 27..29
    lib/src/toys/sphero-mini.ts on lines 31..33
    lib/src/toys/sphero-mini.ts on lines 35..37
    lib/src/toys/sphero-mini.ts on lines 39..41

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

      public sleep(): Promise<IQueuePayload> {
    return this.queueCommand(this.commands.power.sleep());
  }
    Severity: Major
    Found in lib/src/toys/r2d2.ts and 10 other locations - About 35 mins to fix
    lib/src/toys/core.ts on lines 197..199
    lib/src/toys/r2d2.ts on lines 15..17
    lib/src/toys/r2d2.ts on lines 64..66
    lib/src/toys/sphero-mini.ts on lines 15..17
    lib/src/toys/sphero-mini.ts on lines 19..21
    lib/src/toys/sphero-mini.ts on lines 23..25
    lib/src/toys/sphero-mini.ts on lines 27..29
    lib/src/toys/sphero-mini.ts on lines 31..33
    lib/src/toys/sphero-mini.ts on lines 35..37
    lib/src/toys/sphero-mini.ts on lines 39..41

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

      public startIdleLedAnimation(): Promise<IQueuePayload> {
    return this.queueCommand(this.commands.userIo.startIdleLedAnimation());
  }
    Severity: Major
    Found in lib/src/toys/r2d2.ts and 10 other locations - About 35 mins to fix
    lib/src/toys/core.ts on lines 197..199
    lib/src/toys/r2d2.ts on lines 15..17
    lib/src/toys/r2d2.ts on lines 18..20
    lib/src/toys/sphero-mini.ts on lines 15..17
    lib/src/toys/sphero-mini.ts on lines 19..21
    lib/src/toys/sphero-mini.ts on lines 23..25
    lib/src/toys/sphero-mini.ts on lines 27..29
    lib/src/toys/sphero-mini.ts on lines 31..33
    lib/src/toys/sphero-mini.ts on lines 35..37
    lib/src/toys/sphero-mini.ts on lines 39..41

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status