Sign upLogin

ignar/katas

View on GitHub
Star

Showing 5 of 5 total issues

Method merge has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def merge(left, right)
      return [] if left.empty? && right.empty?
      return right if left.empty?
      return left if right.empty?
Severity: Minor
Found in lib/sort/merge.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method binary_search has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

def binary_search(int, array, start_index, end_index)
  return -1 if array.empty?
  return -1 if int < array.first
  return -1 if int > array.last
Severity: Minor
Found in lib/kata-2_binary-search/binary_search.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method merge has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def merge(left, right)
      return [] if left.empty? && right.empty?
      return right if left.empty?
      return left if right.empty?
Severity: Minor
Found in lib/sort/merge.rb - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

        return mindex
    Severity: Major
    Found in lib/kata-2_binary-search/binary_search.rb - About 30 mins to fix

      Method number_on_place has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def number_on_place(place_num)
      return nil if place_num <= 0
      return 1 if place_num == 1
      return 1 if place_num == 2
      return 2 if place_num == 3
      Severity: Minor
      Found in lib/fibonacci/fibonacci.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language