igor-starostenko/report_factory-web

View on GitHub
src/containers/update_user.jsx

Summary

Maintainability
D
1 day
Test Coverage

Function UpdateUser has 89 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function UpdateUser(props) {
  const [isUpdatePasswordModalOpen, setUpdatePasswordModal] = useState(false);
  const [isDeleteUserModalOpen, setDeleteUserModal] = useState(false);

  const {
Severity: Major
Found in src/containers/update_user.jsx - About 3 hrs to fix

    Function UpdatePasswordModal has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function UpdatePasswordModal(props) {
      function resetForm() {
        props.dispatch(reset('editPasswordForm'));
        props.toggle();
      }
    Severity: Minor
    Found in src/containers/update_user.jsx - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        function handleDelete() {
          props.deleteUser(userId, xApiKey).then(response => {
            if (response.payload.errors) {
              return dispatch(editUserFailure(response.payload));
            }
      Severity: Major
      Found in src/containers/update_user.jsx and 1 other location - About 2 hrs to fix
      src/containers/update_project.jsx on lines 79..87

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 94.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          data: PropTypes.shape({
            id: PropTypes.string.isRequired,
            type: PropTypes.string.isRequired,
            attributes: PropTypes.shape({
              name: PropTypes.string.isRequired,
      Severity: Major
      Found in src/containers/update_user.jsx and 1 other location - About 2 hrs to fix
      src/containers/update_password_form.jsx on lines 63..70

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 84.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      const mapDispatchToProps = dispatch => ({
        getUser: (...args) => dispatch(getUser(...args)),
        updateUser: (...args) => dispatch(updateUser(...args)),
        deleteUser: (...args) => dispatch(deleteUser(...args)),
        dispatch,
      Severity: Major
      Found in src/containers/update_user.jsx and 1 other location - About 2 hrs to fix
      src/containers/update_project.jsx on lines 148..153

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 80.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      DeleteUserModal.propTypes = {
        isOpen: PropTypes.bool.isRequired,
        toggle: PropTypes.func.isRequired,
        handleDelete: PropTypes.func.isRequired,
        userName: PropTypes.string.isRequired,
      Severity: Major
      Found in src/containers/update_user.jsx and 4 other locations - About 1 hr to fix
      src/components/pagination.jsx on lines 61..66
      src/components/pagination_connection.jsx on lines 103..108
      src/containers/update_project.jsx on lines 43..48
      src/containers/users.jsx on lines 29..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          <ConfirmModal
            isOpen={props.isOpen}
            toggle={props.toggle}
            title={`Delete ${props.userName}?`}
            cancel={{ children: 'Cancel' }}
      Severity: Minor
      Found in src/containers/update_user.jsx and 1 other location - About 40 mins to fix
      src/containers/update_project.jsx on lines 24..39

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status