Sign upLogin

ihavalyova/DiAtomic

View on GitHub
Star

Showing 129 of 135 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        rule_ss2_2so = \
            (lambda_diff == -1.0 * sigma_diff == 2.0) or \
            (lambda_diff == -1.0 * sigma_diff == -2.0)
Severity: Major
Found in diatomic/operator.py and 1 other location - About 1 hr to fix
diatomic/operator.py on lines 853..855

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function __init__ has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, objs, pair_states, label, model='pointwise', rotc=0.0,
Severity: Major
Found in diatomic/operator.py - About 1 hr to fix

    Function __init__ has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, objs, pair_states, label, model='pointwise', rotc=0.0,
    Severity: Major
    Found in diatomic/operator.py - About 1 hr to fix

      Function plot_radial_functions has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def plot_radial_functions(self, ops, show=False, fname=None, subplots=None,
      Severity: Major
      Found in diatomic/hamiltonian.py - About 1 hr to fix

        Function optimize has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def optimize(self, ypar, yfixed, calculate_data, niter, derivative,
        Severity: Major
        Found in diatomic/optimizer.py - About 1 hr to fix

          Function __init__ has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def __init__(self, objs=None, pair_states=None, label='', model='pointwise',
          Severity: Major
          Found in diatomic/operator.py - About 1 hr to fix

            Function __init__ has 8 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def __init__(self, objs, pair_states, label, model='pointwise', rotc=0.0,
            Severity: Major
            Found in diatomic/operator.py - About 1 hr to fix

              Function __init__ has 8 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def __init__(self, objs, pair_states, label, model='pointwise', rotc=0.0,
              Severity: Major
              Found in diatomic/operator.py - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        rule_ss1_1so = \
            (lambda_diff == -1.0 * sigma_diff == 1.0) or \
            (lambda_diff == -1.0 * sigma_diff == -1.0)
                Severity: Major
                Found in diatomic/operator.py and 1 other location - About 1 hr to fix
                diatomic/operator.py on lines 858..860

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 38.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function set_constraints has 8 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def set_constraints(self, uenr_range=None, lenr_range=None, lsymm=None,
                Severity: Major
                Found in diatomic/spectrum.py - About 1 hr to fix

                  Function __init__ has 8 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def __init__(self, objs, pair_states, label, model='pointwise', rotc=0.0,
                  Severity: Major
                  Found in diatomic/operator.py - About 1 hr to fix

                    Function _remove_layout has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def _remove_layout(self, layout):
        print(layout)
        for i in range(len(layout)):
            print(i, layout[i])
            temp_layout = layout[i]
                    Severity: Minor
                    Found in diatomic/gui.py - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function optimize_levels_by_svd_regular has 7 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def optimize_levels_by_svd_regular(self, niter=1, derivative='n',
                    Severity: Major
                    Found in diatomic/optimizer.py - About 50 mins to fix

                      Function _write_fit_progress has 7 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          def _write_fit_progress(self, rank, sing_values, tol, ypar, dypar, yfixed):
                      Severity: Major
                      Found in diatomic/optimizer.py - About 50 mins to fix

                        Function plot_levels_hist has 7 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            def plot_levels_hist(self, data=None, show=False, fname=None,
                        Severity: Major
                        Found in diatomic/hamiltonian.py - About 50 mins to fix

                          Function _get_dydp_elem has 7 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              def _get_dydp_elem(self, indices, sk, sk_grid, sk_coef, j, evecs_found):
                          Severity: Major
                          Found in diatomic/optimizer.py - About 50 mins to fix

                            Function _five_diagonal_matrix has 7 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                def _five_diagonal_matrix(self, a, b, c, k1=0, k2=1, k3=2):
                            Severity: Major
                            Found in diatomic/hamiltonian.py - About 50 mins to fix

                              Function _rule_spin_spin_nondiag has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  def _rule_spin_spin_nondiag(self):

        lambda_diff = self.state1._lambda - self.state2._lambda
        sigma_diff = self.state2.sigma - self.state1.sigma
                              Severity: Minor
                              Found in diatomic/operator.py - About 45 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function optimize_wavenumbers_by_svd has 6 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  def optimize_wavenumbers_by_svd(self, niter=1, derivative='n', tol=0.1,
                              Severity: Minor
                              Found in diatomic/optimizer.py - About 45 mins to fix

                                Similar blocks of code found in 4 locations. Consider refactoring.
                                Open

                                        b = self.calculate_coeff_B(xgrid, self.x[inds], self.x[inds-1])
                                Severity: Major
                                Found in diatomic/interpolator.py and 3 other locations - About 45 mins to fix
                                diatomic/interpolator.py on lines 148..148
                                diatomic/interpolator.py on lines 150..150
                                diatomic/interpolator.py on lines 151..151

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 35.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Severity
                                Category
                                Status
                                Source
                                Language