Sign upLogin

ikeisuke/node-easy-concurrent-stream

View on GitHub
Star

Showing 14 of 14 total issues

Function _read has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

ConcurrentTransform.prototype._read = function(n) {
  const ts = this._transformState;
  const backlog = ts.backlog;
  if (backlog) {
    ts.backlog = null;
Severity: Minor
Found in lib/transform.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _read has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

ConcurrentTransform.prototype._read = function(n) {
  const ts = this._transformState;
  const backlog = ts.backlog;
  if (backlog) {
    ts.backlog = null;
Severity: Minor
Found in lib/transform.js - About 1 hr to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

          ts = new Transform({
        transform: function(chunk, encoding, callback) {
          setImmediate(()  => {
            callback(null, chunk);
          });
    Severity: Major
    Found in benchmark/index.js and 2 other locations - About 1 hr to fix
    benchmark/index.js on lines 62..71
    benchmark/index.js on lines 90..99

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                  ts = new ConcurrentTransform({
                transform: function(chunk, encoding, callback) {
                  setImmediate(() => {
                    callback(null, chunk);
                  });
    Severity: Major
    Found in benchmark/index.js and 2 other locations - About 1 hr to fix
    benchmark/index.js on lines 34..43
    benchmark/index.js on lines 62..71

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

              ts = new ConcurrentTransform({
            transform: function(chunk, encoding, callback) {
              setImmediate(() => {
                callback(null, chunk);
              });
    Severity: Major
    Found in benchmark/index.js and 2 other locations - About 1 hr to fix
    benchmark/index.js on lines 34..43
    benchmark/index.js on lines 90..99

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 62.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid deeply nested control flow statements.
    Open

              if (k.charAt(0) === '_') continue;
    Severity: Major
    Found in lib/transform.js - About 45 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              ts = new ConcurrentTransform({
          transform: function(chunk, encoding, callback) {
            callback(null, chunk);
          },
          flush: function(callback) {
      Severity: Major
      Found in benchmark/index.js and 2 other locations - About 45 mins to fix
      benchmark/index.js on lines 21..28
      benchmark/index.js on lines 77..84

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid deeply nested control flow statements.
      Open

                if (!this.hasOwnProperty(k)) continue;
      Severity: Major
      Found in lib/transform.js - About 45 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                    ts = new ConcurrentTransform({
              transform: function(chunk, encoding, callback) {
                callback(null, chunk);
              },
              flush: function(callback) {
        Severity: Major
        Found in benchmark/index.js and 2 other locations - About 45 mins to fix
        benchmark/index.js on lines 21..28
        benchmark/index.js on lines 49..56

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            ts = new Transform({
      transform: function(chunk, encoding, callback) {
        callback(null, chunk);
      },
      flush: function(callback) {
        Severity: Major
        Found in benchmark/index.js and 2 other locations - About 45 mins to fix
        benchmark/index.js on lines 49..56
        benchmark/index.js on lines 77..84

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid deeply nested control flow statements.
        Open

                  if (typeof this[k] === "function") continue;
        Severity: Major
        Found in lib/transform.js - About 45 mins to fix

          Function afterTransform has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          function afterTransform(stream, err, data) {
  const ts = stream._transformState;
  ts.transforming--;

  const context = ts.context;
          Severity: Minor
          Found in lib/transform.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                    if (defaultProperties.some((key)=>{ return key === k })) continue;
          Severity: Major
          Found in lib/transform.js - About 45 mins to fix

            Function ConcurrentTransform has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            function ConcurrentTransform(options) {
  if (!(this instanceof ConcurrentTransform)) {
    return new ConcurrentTransform(options);
  }
            Severity: Minor
            Found in lib/transform.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language