ikuseiGmbH/Goldencobra

View on GitHub
lib/tasks/attribute_validator.rake

Summary

Maintainability
Test Coverage

Complex method namespace(attribute_validator)::task#url (22.5)
Open

  task :url => :environment do
    model_name      = ENV['MODEL_NAME']
    attribute_name  = ENV['ATTRIBUTE_NAME']

    raise "No model name given! (rake attribute_validator:url MODEL_NAME=MyModel)" if model_name.blank?
Severity: Minor
Found in lib/tasks/attribute_validator.rake by flog

Flog calculates the ABC score for methods. The ABC score is based on assignments, branches (method calls), and conditions.

You can read more about ABC metrics or the flog tool

Line is too long. [115/100]
Open

    raise "No attribute name given! (rake attribute_validator:url ATTRIBUTE_NAME=MyModel)" if attribute_name.blank?
Severity: Minor
Found in lib/tasks/attribute_validator.rake by rubocop

This cop checks the length of lines in the source code. The maximum length is configurable. The tab size is configured in the IndentationWidth of the Layout/Tab cop.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Open

    attribute_name  = ENV['ATTRIBUTE_NAME']
Severity: Minor
Found in lib/tasks/attribute_validator.rake by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Open

    model_name      = ENV['MODEL_NAME']
Severity: Minor
Found in lib/tasks/attribute_validator.rake by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [103/100]
Open

    raise "No model name given! (rake attribute_validator:url MODEL_NAME=MyModel)" if model_name.blank?
Severity: Minor
Found in lib/tasks/attribute_validator.rake by rubocop

This cop checks the length of lines in the source code. The maximum length is configurable. The tab size is configured in the IndentationWidth of the Layout/Tab cop.

Use the new Ruby 1.9 hash syntax.
Open

  task :url => :environment do
Severity: Minor
Found in lib/tasks/attribute_validator.rake by rubocop

This cop checks hash literal syntax.

It can enforce either the use of the class hash rocket syntax or the use of the newer Ruby 1.9 syntax (when applicable).

A separate offense is registered for each problematic pair.

The supported styles are:

  • ruby19 - forces use of the 1.9 syntax (e.g. {a: 1}) when hashes have all symbols for keys
  • hash_rockets - forces use of hash rockets for all hashes
  • nomixedkeys - simply checks for hashes with mixed syntaxes
  • ruby19nomixed_keys - forces use of ruby 1.9 syntax and forbids mixed syntax hashes

Example: EnforcedStyle: ruby19 (default)

# bad
{:a => 2}
{b: 1, :c => 2}

# good
{a: 2, b: 1}
{:c => 2, 'd' => 2} # acceptable since 'd' isn't a symbol
{d: 1, 'e' => 2} # technically not forbidden

Example: EnforcedStyle: hash_rockets

# bad
{a: 1, b: 2}
{c: 1, 'd' => 5}

# good
{:a => 1, :b => 2}

Example: EnforcedStyle: nomixedkeys

# bad
{:a => 1, b: 2}
{c: 1, 'd' => 2}

# good
{:a => 1, :b => 2}
{c: 1, d: 2}

Example: EnforcedStyle: ruby19nomixed_keys

# bad
{:a => 1, :b => 2}
{c: 2, 'd' => 3} # should just use hash rockets

# good
{a: 1, b: 2}
{:c => 3, 'd' => 4}

There are no issues that match your filters.

Category
Status