Sign upLogin

ilkkao/mas

View on GitHub
Star

Showing 254 of 254 total issues

Function create has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  static async create(props, { skipSetters = false } = {}) {
    trimWhiteSpace(props);

    if (!skipSetters) {
      const passwordValidation = validatePassword(props.password);
Severity: Minor
Found in server/models/user.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _calculateSpaceForCursor has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  _calculateSpaceForCursor(x, y, cursor) {
    let width = Math.round(CURSORWIDTH / 2);
    const rows = this.dimensions.length;
    const columns = this.dimensions[y].length;
Severity: Minor
Found in client/app/pods/components/window-grid/component.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _addScrollHandler has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  _addScrollHandler() {
    const handler = function () {
      if (this.animating) {
        return;
      }
Severity: Minor
Found in client/app/pods/components/discussion-window/component.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _goToBottom has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  _goToBottom(animate, callback) {
    if (this.scrollLock || !this.$messagesEndAnchor) {
      return;
    }
Severity: Minor
Found in client/app/pods/components/discussion-window/component.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _whichSection has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  _whichSection(windowDim, x, y) {
    // -----------------
    // |\      t      /|
    // | \           / |
    // |  -----------  |
Severity: Minor
Found in client/app/pods/components/window-grid/component.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function processCookie has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

exports.processCookie = async function processCookie(ctx, next) {
  ctx.mas = ctx.mas || {};
  ctx.mas.user = null;

  const sessionCookie = ctx.cookies.get('mas');
Severity: Minor
Found in server/lib/authSessionChecker.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function dispatch has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

export function dispatch(type, data = {}, acceptCb = noopCb, rejectCb = noopCb) {
  let consumed = false;
  const name = type
    .split('_')
    .map(part => part.toLowerCase().capitalize())
Severity: Minor
Found in client/app/utils/dispatcher.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function decoratedTitle has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  get decoratedTitle(): string {
    let title = '';
    const type = this.type;
    const network = this.network;
    const name = this.name;
Severity: Minor
Found in new-client/src/models/Window.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function newMessageAlert has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  private newMessageAlert(window: WindowModel, message: Message) {
    if (!message.isNotable || message.isFromMe || !this.initDone) {
      return;
    }
Severity: Minor
Found in new-client/src/stores/WindowStore.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                <FormControl mt={4} isInvalid={!!form.errors.username}>
                  <Input {...field} id="username" placeholder="Username or email" />
                  <FormErrorMessage>{form.errors.username}</FormErrorMessage>
                </FormControl>
Severity: Minor
Found in website/src/components/LoginModal.tsx and 1 other location - About 35 mins to fix
website/src/components/LoginModal.tsx on lines 146..149

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                <FormControl mt={4}>
                  <Input {...field} id="email" placeholder="Your email address" />
                  <FormErrorMessage>{form.errors.email}</FormErrorMessage>
                </FormControl>
Severity: Minor
Found in website/src/components/LoginModal.tsx and 1 other location - About 35 mins to fix
website/src/components/LoginModal.tsx on lines 111..114

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

    return false;
Severity: Major
Found in server/models/user.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

      return courier.call(backend, 'textCommand', {
    userId: user.id,
    conversationId: conversation.id,
    command: name,
    commandParams: params
    Severity: Major
    Found in server/controllers/request.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return message.body;
      Severity: Major
      Found in new-client/src/components/MessageRenderer.tsx - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

          return { status: 'OK' };
        Severity: Major
        Found in server/controllers/request.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return start1on1(user, targetUserGId, targetUserGId.isMASUser ? 'mas' : network);
          Severity: Major
          Found in server/controllers/request.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return { valid: true, value: nickName };
            Severity: Major
            Found in server/models/user.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                return { status: 'OK' };
              Severity: Major
              Found in server/controllers/request.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return <Text color="red.600">{message.body}</Text>;
                Severity: Major
                Found in new-client/src/components/MessageRenderer.tsx - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return null;
                  Severity: Major
                  Found in client/app/pods/components/window-grid/component.js - About 30 mins to fix
                    Severity
                    Category
                    Status
                    Source
                    Language