Sign upLogin

ilkkao/mas

View on GitHub
Star

Showing 254 of 254 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      indices: {
        srcUserId: {
          uniq: false,
          fields: ['srcUserId']
        },
Severity: Major
Found in server/bin/create-db.ts and 2 other locations - About 1 hr to fix
server/bin/create-db.ts on lines 103..116
server/bin/create-db.ts on lines 180..193

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      indices: {
        userId: {
          uniq: false,
          fields: ['userId']
        },
Severity: Major
Found in server/bin/create-db.ts and 2 other locations - About 1 hr to fix
server/bin/create-db.ts on lines 137..150
server/bin/create-db.ts on lines 180..193

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      indices: {
        userGId: {
          uniq: false,
          fields: ['userGId']
        },
Severity: Major
Found in server/bin/create-db.ts and 2 other locations - About 1 hr to fix
server/bin/create-db.ts on lines 103..116
server/bin/create-db.ts on lines 137..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function handleIdentConnection has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function handleIdentConnection(socket) {
  const timer = setTimeout(() => {
    if (socket) {
      socket.destroy();
    }
Severity: Minor
Found in server/backends/irc/connection-manager/connectionManager.js - About 1 hr to fix

    Function createReset has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.createReset = async function createReset(ctx) {
  const form = await decodeForm(ctx.req, registrationFormReset);
  const userId = await redis.get(`frontend:password_reset_token:${form.data.token}`);

  async function renderForm() {
    Severity: Minor
    Found in server/controllers/register.js - About 1 hr to fix

      Function create has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        static async create(props, { skipSetters = false } = {}) {
    trimWhiteSpace(props);

    if (!skipSetters) {
      const passwordValidation = validatePassword(props.password);
      Severity: Minor
      Found in server/models/user.js - About 1 hr to fix

        Function createNodeSpec has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          createNodeSpec(extra: ApplySchemaAttributes, override: NodeSpecOverride): NodeExtensionSpec {
    return {
      selectable: true,
      draggable: false,
      ...override,
        Severity: Minor
        Found in new-client/src/lib/remirrorMessageEmojiExtension.ts - About 1 hr to fix

          Function handleUpdateWindowServer has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

            handleUpdateWindowServer({
    windowId = mandatory(),
    userId,
    network,
    windowType,
          Severity: Minor
          Found in client/app/stores/WindowStore.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function handleCommand has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

          async function handleCommand({ command, conversation, user, backend }) {
  const { command: name, params } = command;

  if (!conversation) {
    return { status: 'ERROR', errorMsg: 'Invalid windowId.' };
          Severity: Minor
          Found in server/controllers/request.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function handleProcessLine has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            handleProcessLine({ window = mandatory(), body = mandatory() }) {
    let command = false;
    let commandParams;

    if (body.charAt(0) === '/') {
          Severity: Minor
          Found in client/app/stores/WindowStore.js - About 1 hr to fix

            Function sendText has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              async sendText(window: WindowModel, text: string, doc?: RemirrorJSON): Promise<void> {
    let sent = false;

    setTimeout(() => {
      if (!sent) {
            Severity: Minor
            Found in new-client/src/stores/WindowStore.ts - About 1 hr to fix

              Function getMessageRange has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export async function getMessageRange(conversationId, start, end, amount) {
  if (!elasticSearchAvailable()) {
    return [];
  }
              Severity: Minor
              Found in server/lib/search.ts - About 1 hr to fix

                Function dispatch has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                export function dispatch(type, data = {}, acceptCb = noopCb, rejectCb = noopCb) {
  let consumed = false;
  const name = type
    .split('_')
    .map(part => part.toLowerCase().capitalize())
                Severity: Minor
                Found in client/app/utils/dispatcher.js - About 1 hr to fix

                  Function _whichSection has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    _whichSection(windowDim, x, y) {
    // -----------------
    // |\      t      /|
    // | \           / |
    // |  -----------  |
                  Severity: Minor
                  Found in client/app/pods/components/window-grid/component.js - About 1 hr to fix

                    Function process has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    exports.process = async function process(session, command) {
  const { windowId } = command;
  const network = typeof command.network === 'string' ? command.network.toLowerCase() : null;
  const user = session.user;
                    Severity: Minor
                    Found in server/controllers/request.js - About 1 hr to fix

                      Function useMessageRemirror has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      export function useMessageRemirror(): MessageRemirror {
  const extensions = useMemo(
    () => () =>
      [
        new BoldExtension(),
                      Severity: Minor
                      Found in new-client/src/hooks/remirror.ts - About 1 hr to fix

                        Function deleteConversationMember has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        async function deleteConversationMember(conversation, member, options) {
  log.info(`User: ${member.get('userGId')} removed from conversation: ${conversation.id}`);

  if (!options.silent && conversation.get('type') === 'group') {
    await broadcastAddMessage(conversation, {
                        Severity: Minor
                        Found in server/services/conversations.js - About 1 hr to fix

                          Function updateMembers has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                            updateMembers(id: number, members: Array<{ userId: string; role: Role }>, reset: boolean): void {
    const window = this.windows.get(id);

    if (!window) {
      return;
                          Severity: Minor
                          Found in new-client/src/stores/WindowStore.ts - About 1 hr to fix

                            Identical blocks of code found in 2 locations. Consider refactoring.
                            Open

                                alerts: {
      email: window.get('emailAlert'),
      notification: window.get('notificationAlert'),
      sound: window.get('soundAlert'),
      title: window.get('titleAlert')
                            Severity: Major
                            Found in server/services/windows.js and 1 other location - About 1 hr to fix
                            server/services/session.js on lines 73..78

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 58.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                            function sendJoin(user, network, channel, password) {
  courier.callNoWait('connectionmanager', 'write', {
    userId: user.id,
    network,
    line: `JOIN ${channel} ${password}`
                            Severity: Major
                            Found in server/backends/irc/controller.js and 1 other location - About 1 hr to fix
                            server/backends/irc/controller.js on lines 1331..1337

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 58.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Severity
                            Category
                            Status
                            Source
                            Language