Showing 254 of 254 total issues
Similar blocks of code found in 3 locations. Consider refactoring. Open
indices: {
userId: {
uniq: false,
fields: ['userId']
},
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 61.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
indices: {
userGId: {
uniq: false,
fields: ['userGId']
},
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 61.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
indices: {
srcUserId: {
uniq: false,
fields: ['srcUserId']
},
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 61.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function createReset
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
exports.createReset = async function createReset(ctx) {
const form = await decodeForm(ctx.req, registrationFormReset);
const userId = await redis.get(`frontend:password_reset_token:${form.data.token}`);
async function renderForm() {
Function handleIdentConnection
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
function handleIdentConnection(socket) {
const timer = setTimeout(() => {
if (socket) {
socket.destroy();
}
Function create
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
static async create(props, { skipSetters = false } = {}) {
trimWhiteSpace(props);
if (!skipSetters) {
const passwordValidation = validatePassword(props.password);
Function createNodeSpec
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
createNodeSpec(extra: ApplySchemaAttributes, override: NodeSpecOverride): NodeExtensionSpec {
return {
selectable: true,
draggable: false,
...override,
Function handleCommand
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
async function handleCommand({ command, conversation, user, backend }) {
const { command: name, params } = command;
if (!conversation) {
return { status: 'ERROR', errorMsg: 'Invalid windowId.' };
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function handleUpdateWindowServer
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
handleUpdateWindowServer({
windowId = mandatory(),
userId,
network,
windowType,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function handleProcessLine
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
handleProcessLine({ window = mandatory(), body = mandatory() }) {
let command = false;
let commandParams;
if (body.charAt(0) === '/') {
Function sendText
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
async sendText(window: WindowModel, text: string, doc?: RemirrorJSON): Promise<void> {
let sent = false;
setTimeout(() => {
if (!sent) {
Function _whichSection
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
_whichSection(windowDim, x, y) {
// -----------------
// |\ t /|
// | \ / |
// | ----------- |
Function dispatch
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function dispatch(type, data = {}, acceptCb = noopCb, rejectCb = noopCb) {
let consumed = false;
const name = type
.split('_')
.map(part => part.toLowerCase().capitalize())
Function getMessageRange
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
export async function getMessageRange(conversationId, start, end, amount) {
if (!elasticSearchAvailable()) {
return [];
}
Function process
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
exports.process = async function process(session, command) {
const { windowId } = command;
const network = typeof command.network === 'string' ? command.network.toLowerCase() : null;
const user = session.user;
Function deleteConversationMember
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
async function deleteConversationMember(conversation, member, options) {
log.info(`User: ${member.get('userGId')} removed from conversation: ${conversation.id}`);
if (!options.silent && conversation.get('type') === 'group') {
await broadcastAddMessage(conversation, {
Function useMessageRemirror
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
export function useMessageRemirror(): MessageRemirror {
const extensions = useMemo(
() => () =>
[
new BoldExtension(),
Function updateMembers
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
updateMembers(id: number, members: Array<{ userId: string; role: Role }>, reset: boolean): void {
const window = this.windows.get(id);
if (!window) {
return;
Similar blocks of code found in 2 locations. Consider refactoring. Open
function sendJoin(user, network, channel, password) {
courier.callNoWait('connectionmanager', 'write', {
userId: user.id,
network,
line: `JOIN ${channel} ${password}`
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 58.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
alerts: {
email: window.get('emailAlert'),
notification: window.get('notificationAlert'),
sound: window.get('soundAlert'),
title: window.get('titleAlert')
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 58.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76