ilscipio/scipio-erp

View on GitHub
applications/manufacturing/src/org/ofbiz/manufacturing/bom/BOMNode.java

Summary

Maintainability
C
1 day
Test Coverage

BOMNode has 40 methods (exceeds 20 allowed). Consider refactoring.
Open

public class BOMNode {
    private static final Debug.OfbizLogger module = Debug.getOfbizLogger(java.lang.invoke.MethodHandles.lookup().lookupClass());

    protected LocalDispatcher dispatcher = null;
    protected Delegator delegator = null;

    Method createManufacturingOrder has 11 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public Map<String, Object> createManufacturingOrder(String facilityId, Date date, String workEffortName, String description, String routingId, String orderId, String orderItemSeqId, String shipGroupSeqId, String shipmentId, boolean useSubstitute, boolean ignoreSupplierProducts) throws GenericEntityException {

      Avoid deeply nested control flow statements.
      Open

                              if (UtilValidate.isNotEmpty(genericNodeRules)) {
                                  // FIXME
                                  //...
                              }
      Severity: Major
      Found in applications/manufacturing/src/org/ofbiz/manufacturing/bom/BOMNode.java - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if (newNode.equals(oneChildNode)) {
                                    Map<String, String> selectedFeatures = new HashMap<String, String>();
                                    if (productFeatures != null) {
                                        GenericValue feature = null;
                                        for (int j = 0; j < productFeatures.size(); j++) {
        Severity: Major
        Found in applications/manufacturing/src/org/ofbiz/manufacturing/bom/BOMNode.java - About 45 mins to fix

          There are no issues that match your filters.

          Category
          Status