ilscipio/scipio-erp

View on GitHub
applications/order/src/org/ofbiz/order/order/OrderReturnServices.java

Summary

Maintainability
F
6 days
Test Coverage

OrderReturnServices has 30 methods (exceeds 20 allowed). Consider refactoring.
Open

public class OrderReturnServices {

    private static final Debug.OfbizLogger module = Debug.getOfbizLogger(java.lang.invoke.MethodHandles.lookup().lookupClass());
    public static final String resource = "OrderUiLabels";
    public static final String resource_error = "OrderErrorUiLabels";
Severity: Minor
Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 3 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                            if (billingAccountBalance.signum() == -1) {
                                billingAccountId = thisBillingAccountId;
                            }
    Severity: Major
    Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if (UtilValidate.isNotEmpty(billingAccounts)) {
                                  billingAccountId = EntityUtil.getFirst(billingAccounts).getString("billingAccountId");
                              } else {
                                  // create new BillingAccount w/ 0 balance
                                  Map<String, Object> results = createBillingAccountFromReturn(returnHeader, returnItems, dctx, context);
      Severity: Major
      Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if (inventoryItem.get("unitCost") != null) {
                                    itemCost = inventoryItem.getBigDecimal("unitCost");
                                } else {
                                    Debug.logInfo("Found item cost; but cost was null. Returning default amount (0.00)", module);
                                }
        Severity: Major
        Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 45 mins to fix

          Method groupReturnItemsByOrder has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public static void groupReturnItemsByOrder(List<GenericValue> returnItems, Map<String, List<GenericValue>> returnItemsByOrderId, Map<String, BigDecimal> totalByOrder, Delegator delegator, String returnId, String returnTypeId) {
          Severity: Minor
          Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                        if (returnItemResponse != null) {
                                            String replacementOrderId = returnItemResponse.getString("replacementOrderId");
                                            Map<String, Object> svcCtx = UtilMisc.<String, Object>toMap("orderId", replacementOrderId, "userLogin", userLogin);
                                            GenericValue orderHeader = EntityQuery.use(delegator).from("OrderHeader").where("orderId", replacementOrderId).queryOne();
                                            if ("ORDER_HOLD".equals(orderHeader.getString("statusId"))) {
            Severity: Major
            Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      if (prefSplitMap.containsKey(paymentMethodTypeId)) {
                                          (prefSplitMap.get(paymentMethodTypeId)).add(orderPayPrefDetails);
                                      } else {
                                          prefSplitMap.put(paymentMethodTypeId, UtilMisc.toList(orderPayPrefDetails));
                                      }
              Severity: Major
              Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        for (GenericValue itemAdjustment : itemAdjustments) {
                                            returnInfo = new HashMap<>();
                                            returnInfo.put("returnableQuantity", BigDecimal.ONE);
                                             // TODO: the returnablePrice should be set to the amount minus the already returned amount
                                            returnInfo.put("returnablePrice", itemAdjustment.get("amount"));
                Severity: Major
                Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                          if (UtilValidate.isEmpty(quantityIssued) || quantityIssued.compareTo(BigDecimal.ZERO) == 0) {
                                              try {
                                                  GenericValue itemProduct = item.getRelatedOne("Product", false);
                                                  if (ProductWorker.isPhysical(itemProduct)) {
                                                      continue;
                  Severity: Major
                  Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                                if (parties == null) {
                                                    parties = new LinkedList<>();
                                                    orderRolesMap.put(orderRole.getString("roleTypeId"), parties);
                                                }
                    Severity: Major
                    Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                                  if (ServiceUtil.isError(updateReturnItemResult)) {
                                                      return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                              "OrderProblemStoringReturnItemUpdates", locale), null, null, updateReturnItemResult);
                                                  }
                      Severity: Major
                      Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                                if (paymentMethodId != null || "FIN_ACCOUNT".equals(paymentMethodTypeId)) {
                                                    opp.set("statusId", "PAYMENT_NOT_AUTH");
                                                } else if (paymentMethodTypeId != null) {
                                                    // external payment method types require notification when received
                                                    // internal payment method types are assumed to be in-hand
                        Severity: Major
                        Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                                  if (amount == null) {
                                                      amount = BigDecimal.ZERO;
                                                  }
                          Severity: Major
                          Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                                    if (orderItem != null) {
                                                        BigDecimal quantity = returnItem.getBigDecimal("returnQuantity");
                                                        BigDecimal unitPrice = returnItem.getBigDecimal("returnPrice");
                                                        if (quantity != null && unitPrice != null) {
                                                            orderPriceTotal = orderPriceTotal.add(quantity.multiply(unitPrice));
                            Severity: Major
                            Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                                          if (ServiceUtil.isError(serviceResult)) {
                                                              return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
                                                          }
                              Severity: Major
                              Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 45 mins to fix

                                Avoid deeply nested control flow statements.
                                Open

                                                        if (ServiceUtil.isError(serviceResult)) {
                                                            return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
                                                        }
                                Severity: Major
                                Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 45 mins to fix

                                  Avoid deeply nested control flow statements.
                                  Open

                                                          if (quantity == null) {
                                                              quantity = BigDecimal.ZERO;
                                                          }
                                  Severity: Major
                                  Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 45 mins to fix

                                    Avoid deeply nested control flow statements.
                                    Open

                                                            while (pmtppit.hasNext() && amountLeftToRefund.compareTo(ZERO) == 1) {
                                                                Map<String, Object> orderPaymentPrefDetails = pmtppit.next();
                                                                GenericValue orderPaymentPreference = (GenericValue) orderPaymentPrefDetails.get("orderPaymentPreference");
                                                                BigDecimal orderPaymentPreferenceAvailable = (BigDecimal) orderPaymentPrefDetails.get("availableTotal");
                                                                GenericValue refundOrderPaymentPreference=null;
                                    Severity: Major
                                    Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 45 mins to fix

                                      Avoid deeply nested control flow statements.
                                      Open

                                                              if (thruDate == null || thruDate.after(now)) {
                                                                  subscription.set("thruDate", now);
                                                                  try {
                                                                      delegator.store(subscription);
                                                                  } catch (GenericEntityException e) {
                                      Severity: Major
                                      Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 45 mins to fix

                                        Avoid deeply nested control flow statements.
                                        Open

                                                                if ("RTN_CSREPLACE".equals(returnTypeId)) {
                                                                    opp.set("maxAmount", orderPriceTotal);
                                                                }
                                        Severity: Major
                                        Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 45 mins to fix

                                          Avoid too many return statements within this method.
                                          Open

                                                                  return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                          "OrderErrorUnableToCreateReturnStatusHistory", locale));
                                          Severity: Major
                                          Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                            Avoid too many return statements within this method.
                                            Open

                                                                            return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                    "OrderProblemsCreatingReturnItemResponseEntity", locale));
                                            Severity: Major
                                            Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                              Avoid too many return statements within this method.
                                              Open

                                                                          return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                  "OrderProblemCreatingReturnItemResponseRecord", locale),
                                                                                  null, null, createReturnItemResponseResult);
                                              Severity: Major
                                              Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                Avoid too many return statements within this method.
                                                Open

                                                                                return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                        "OrderNoAvailableBillingAccount", locale));
                                                Severity: Major
                                                Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                  Avoid too many return statements within this method.
                                                  Open

                                                                      return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                              "OrderProblemCreatingPaymentApplicationRecord", locale));
                                                  Severity: Major
                                                  Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                    Avoid too many return statements within this method.
                                                    Open

                                                                            return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
                                                    Severity: Major
                                                    Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                      Avoid too many return statements within this method.
                                                      Open

                                                              return ServiceUtil.returnSuccess();
                                                      Severity: Major
                                                      Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                        Avoid too many return statements within this method.
                                                        Open

                                                                                    return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                            "OrderProblemStoringReturnItemUpdates", locale));
                                                        Severity: Major
                                                        Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                          Avoid too many return statements within this method.
                                                          Open

                                                                  return ServiceUtil.returnSuccess(successMessage.toString());
                                                          Severity: Major
                                                          Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                            Avoid too many return statements within this method.
                                                            Open

                                                                                        return ServiceUtil.returnError(e.getMessage());
                                                            Severity: Major
                                                            Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                              Avoid too many return statements within this method.
                                                              Open

                                                                                  return ServiceUtil.returnError(ServiceUtil.getErrorMessage(finAccountTransResult));
                                                              Severity: Major
                                                              Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                Avoid too many return statements within this method.
                                                                Open

                                                                                return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                        "OrderProblemCreatingPaymentRecord", locale));
                                                                Severity: Major
                                                                Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                  Avoid too many return statements within this method.
                                                                  Open

                                                                                      return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                              "OrderProblemCreatingReturnItemResponseRecord", locale), null, null, serviceResults);
                                                                  Severity: Major
                                                                  Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                    Avoid too many return statements within this method.
                                                                    Open

                                                                                                        return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                "OrderProblemsWithTheRefundSeeLogs", locale));
                                                                    Severity: Major
                                                                    Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                      Avoid too many return statements within this method.
                                                                      Open

                                                                                                      return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                              "OrderProblemUpdatingReturnItemReturnItemResponseId", locale));
                                                                      Severity: Major
                                                                      Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                        Avoid too many return statements within this method.
                                                                        Open

                                                                                                return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                        "OrderErrorUnableToGetTheItemReturnableQuantity", locale));
                                                                        Severity: Major
                                                                        Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                          Avoid too many return statements within this method.
                                                                          Open

                                                                                                              return ServiceUtil.returnError(e.getMessage());
                                                                          Severity: Major
                                                                          Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                            Avoid too many return statements within this method.
                                                                            Open

                                                                                                                        return ServiceUtil.returnError(ServiceUtil.getErrorMessage(result));
                                                                            Severity: Major
                                                                            Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                              Avoid too many return statements within this method.
                                                                              Open

                                                                                                                  return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,"OrderProblemsWithTheRefundSeeLogs", locale));
                                                                              Severity: Major
                                                                              Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                Avoid too many return statements within this method.
                                                                                Open

                                                                                                                    return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                            "OrderProblemUpdatingReturnItemReturnItemResponseId", locale));
                                                                                Severity: Major
                                                                                Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                  Avoid too many return statements within this method.
                                                                                  Open

                                                                                                          return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                  "OrderProblemsWithGetPartyAcctgPreferences", locale));
                                                                                  Severity: Major
                                                                                  Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                    Avoid too many return statements within this method.
                                                                                    Open

                                                                                                        return ServiceUtil.returnError(UtilProperties.getMessage(resource,
                                                                                                                "OrderOrderPaymentApplicationFailed",
                                                                                                                UtilMisc.toMap("errorString", e.getMessage()), locale));
                                                                                    Severity: Major
                                                                                    Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                      Avoid too many return statements within this method.
                                                                                      Open

                                                                                                                  return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
                                                                                      Severity: Major
                                                                                      Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                        Avoid too many return statements within this method.
                                                                                        Open

                                                                                                return result;
                                                                                        Severity: Major
                                                                                        Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                          Avoid too many return statements within this method.
                                                                                          Open

                                                                                                  return result;
                                                                                          Severity: Major
                                                                                          Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                            Avoid too many return statements within this method.
                                                                                            Open

                                                                                                                            return ServiceUtil.returnError(ServiceUtil.getErrorMessage(createAccountResult));
                                                                                            Severity: Major
                                                                                            Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                              Avoid too many return statements within this method.
                                                                                              Open

                                                                                                                  return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                          "OrderProblemStoringReturnItemUpdates", locale));
                                                                                              Severity: Major
                                                                                              Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                Avoid too many return statements within this method.
                                                                                                Open

                                                                                                                    return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                            "OrderProblemCreatingPaymentApplicationRecord", locale));
                                                                                                Severity: Major
                                                                                                Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                  Avoid too many return statements within this method.
                                                                                                  Open

                                                                                                              return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                      "OrderProblemsCreatingBillingAccount", locale));
                                                                                                  Severity: Major
                                                                                                  Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                    Avoid too many return statements within this method.
                                                                                                    Open

                                                                                                                                                return ServiceUtil.returnError(UtilProperties.getMessage(resource_error, "OrderProblemsWithTheRefundSeeLogs", locale));
                                                                                                    Severity: Major
                                                                                                    Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                      Avoid too many return statements within this method.
                                                                                                      Open

                                                                                                              return result;
                                                                                                      Severity: Major
                                                                                                      Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                        Avoid too many return statements within this method.
                                                                                                        Open

                                                                                                                            return ServiceUtil.returnError(e.getMessage());
                                                                                                        Severity: Major
                                                                                                        Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                          Avoid too many return statements within this method.
                                                                                                          Open

                                                                                                                                          return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                  "OrderNoAvailableFinAccount", locale));
                                                                                                          Severity: Major
                                                                                                          Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                            Avoid too many return statements within this method.
                                                                                                            Open

                                                                                                                                                    return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                            "OrderProblemUpdatingReturnItemReturnItemResponseId", locale), null, null, serviceResults);
                                                                                                            Severity: Major
                                                                                                            Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                              Avoid too many return statements within this method.
                                                                                                              Open

                                                                                                                                          return ServiceUtil.returnError(e.getMessage());
                                                                                                              Severity: Major
                                                                                                              Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                Avoid too many return statements within this method.
                                                                                                                Open

                                                                                                                        return ServiceUtil.returnSuccess();
                                                                                                                Severity: Major
                                                                                                                Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                  Avoid too many return statements within this method.
                                                                                                                  Open

                                                                                                                                      return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                              "OrderProblemSendingEmail", locale));
                                                                                                                  Severity: Major
                                                                                                                  Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                    Avoid too many return statements within this method.
                                                                                                                    Open

                                                                                                                                                    return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                            "OrderProblemsCreatingFinAccountForStore", locale));
                                                                                                                    Severity: Major
                                                                                                                    Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                      Avoid too many return statements within this method.
                                                                                                                      Open

                                                                                                                                              return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                      "OrderProblemStoringReturnItemUpdates", locale), null, null, serviceResults);
                                                                                                                      Severity: Major
                                                                                                                      Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                        Avoid too many return statements within this method.
                                                                                                                        Open

                                                                                                                                                return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                        "OrderProblemSendingEmail", locale), null, null, sendResp);
                                                                                                                        Severity: Major
                                                                                                                        Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                          Avoid too many return statements within this method.
                                                                                                                          Open

                                                                                                                                                      return ServiceUtil.returnError(e.getMessage());
                                                                                                                          Severity: Major
                                                                                                                          Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                            Avoid too many return statements within this method.
                                                                                                                            Open

                                                                                                                                    return ServiceUtil.returnFailure(UtilProperties.getMessage(resourceProduct,
                                                                                                                                            "ProductProductStoreEmailSettingsNotValid",
                                                                                                                                                UtilMisc.toMap("productStoreId", productStoreId,
                                                                                                                                                        "emailType", emailType), locale));
                                                                                                                            Severity: Major
                                                                                                                            Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                              Avoid too many return statements within this method.
                                                                                                                              Open

                                                                                                                                                              return ServiceUtil.returnError(ServiceUtil.getErrorMessage(finAccountRoleResult));
                                                                                                                              Severity: Major
                                                                                                                              Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                Avoid too many return statements within this method.
                                                                                                                                Open

                                                                                                                                            return ServiceUtil.returnError(UtilProperties.getMessage(resource,
                                                                                                                                                    "OrderOrderPaymentFailed", UtilMisc.toMap("errorString", ""), locale));
                                                                                                                                Severity: Major
                                                                                                                                Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                  Avoid too many return statements within this method.
                                                                                                                                  Open

                                                                                                                                                                  return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                          "OrderProblemStoringReturnItemUpdates", locale), null, null, updateReturnItemResult);
                                                                                                                                  Severity: Major
                                                                                                                                  Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                    Avoid too many return statements within this method.
                                                                                                                                    Open

                                                                                                                                                        return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                "OrderRefundAmountExceedsOrderTotal", locale));
                                                                                                                                    Severity: Major
                                                                                                                                    Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                      Avoid too many return statements within this method.
                                                                                                                                      Open

                                                                                                                                                              return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                      "OrderErrorUnableToGetOrderAdjustmentsFromItem", locale));
                                                                                                                                      Severity: Major
                                                                                                                                      Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                        Avoid too many return statements within this method.
                                                                                                                                        Open

                                                                                                                                                                return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                        "OrderErrorUnableToCreateReturnStatusHistory", locale));
                                                                                                                                        Severity: Major
                                                                                                                                        Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                          Avoid too many return statements within this method.
                                                                                                                                          Open

                                                                                                                                                                          return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                  "OrderProblemCreatingFinAccountRoleRecord", locale));
                                                                                                                                          Severity: Major
                                                                                                                                          Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                            Avoid too many return statements within this method.
                                                                                                                                            Open

                                                                                                                                                                    return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                            "OrderProblemCreatingPaymentApplicationRecord", locale), null, null, serviceResults);
                                                                                                                                            Severity: Major
                                                                                                                                            Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                              Avoid too many return statements within this method.
                                                                                                                                              Open

                                                                                                                                                              return ServiceUtil.returnSuccess();
                                                                                                                                              Severity: Major
                                                                                                                                              Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                                Avoid too many return statements within this method.
                                                                                                                                                Open

                                                                                                                                                                    return ServiceUtil.returnError(UtilProperties.getMessage(resource,
                                                                                                                                                                            "OrderOrderPaymentPreferencesCannotGetPaymentMethodTypes",
                                                                                                                                                                            UtilMisc.toMap("errorString", e.toString()), locale));
                                                                                                                                                Severity: Major
                                                                                                                                                Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                                  Avoid too many return statements within this method.
                                                                                                                                                  Open

                                                                                                                                                                                      return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                              "OrderProblemsCreatingReturnItemResponseEntity", locale), null, null, serviceResults);
                                                                                                                                                  Severity: Major
                                                                                                                                                  Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                                    Avoid too many return statements within this method.
                                                                                                                                                    Open

                                                                                                                                                                                return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
                                                                                                                                                    Severity: Major
                                                                                                                                                    Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                                      Avoid too many return statements within this method.
                                                                                                                                                      Open

                                                                                                                                                                              return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                      "OrderErrorUnableToGetOrderItemInformation", locale));
                                                                                                                                                      Severity: Major
                                                                                                                                                      Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                                        Avoid too many return statements within this method.
                                                                                                                                                        Open

                                                                                                                                                                                    return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                            "OrderErrorUnableToGetOrderItemInformation", locale));
                                                                                                                                                        Severity: Major
                                                                                                                                                        Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                                          Avoid too many return statements within this method.
                                                                                                                                                          Open

                                                                                                                                                                                          return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                                  "OrderErrorWithCreateBillingAccount", locale) + results.get(ModelService.ERROR_MESSAGE));
                                                                                                                                                          Severity: Major
                                                                                                                                                          Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                                            Avoid too many return statements within this method.
                                                                                                                                                            Open

                                                                                                                                                                    return serviceResult;
                                                                                                                                                            Severity: Major
                                                                                                                                                            Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                                              Avoid too many return statements within this method.
                                                                                                                                                              Open

                                                                                                                                                                                                  return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                                          "OrderProblemUpdatingReturnItemReturnItemResponseId", locale), null, null, serviceResults);
                                                                                                                                                              Severity: Major
                                                                                                                                                              Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                                                Avoid too many return statements within this method.
                                                                                                                                                                Open

                                                                                                                                                                                        return ServiceUtil.returnError(ServiceUtil.getErrorMessage(paymentApplResult));
                                                                                                                                                                Severity: Major
                                                                                                                                                                Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                                                  Avoid too many return statements within this method.
                                                                                                                                                                  Open

                                                                                                                                                                                                  return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                                          "OrderErrorUnableToGetTheItemReturnableProduct", locale));
                                                                                                                                                                  Severity: Major
                                                                                                                                                                  Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                                                    Avoid too many return statements within this method.
                                                                                                                                                                    Open

                                                                                                                                                                                    return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                            "OrderProblemCreatingReturnItemResponseRecord", locale));
                                                                                                                                                                    Severity: Major
                                                                                                                                                                    Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                                                      Avoid too many return statements within this method.
                                                                                                                                                                      Open

                                                                                                                                                                              return ServiceUtil.returnSuccess();
                                                                                                                                                                      Severity: Major
                                                                                                                                                                      Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                                                        Avoid too many return statements within this method.
                                                                                                                                                                        Open

                                                                                                                                                                                                    return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                                        "OrderErrorUnableToCreateReturnStatusHistory", locale));
                                                                                                                                                                        Severity: Major
                                                                                                                                                                        Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                                                          Avoid too many return statements within this method.
                                                                                                                                                                          Open

                                                                                                                                                                                              return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                                      "OrderProblemCreatingFinAccountTransRecord", locale));
                                                                                                                                                                          Severity: Major
                                                                                                                                                                          Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                                                            Avoid too many return statements within this method.
                                                                                                                                                                            Open

                                                                                                                                                                                                            return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
                                                                                                                                                                            Severity: Major
                                                                                                                                                                            Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                                                              Avoid too many return statements within this method.
                                                                                                                                                                              Open

                                                                                                                                                                                                      return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                                              "OrderProblemCreatingReturnItemResponseRecord", locale));
                                                                                                                                                                              Severity: Major
                                                                                                                                                                              Found in applications/order/src/org/ofbiz/order/order/OrderReturnServices.java - About 30 mins to fix

                                                                                                                                                                                There are no issues that match your filters.

                                                                                                                                                                                Category
                                                                                                                                                                                Status