applications/order/src/org/ofbiz/order/order/OrderReturnServices.java
OrderReturnServices has 30 methods (exceeds 20 allowed). Consider refactoring. Open
Open
public class OrderReturnServices {
private static final Debug.OfbizLogger module = Debug.getOfbizLogger(java.lang.invoke.MethodHandles.lookup().lookupClass());
public static final String resource = "OrderUiLabels";
public static final String resource_error = "OrderErrorUiLabels";Avoid deeply nested control flow statements. Open
Open
if (billingAccountBalance.signum() == -1) {
billingAccountId = thisBillingAccountId;
}Avoid deeply nested control flow statements. Open
Open
if (UtilValidate.isNotEmpty(billingAccounts)) {
billingAccountId = EntityUtil.getFirst(billingAccounts).getString("billingAccountId");
} else {
// create new BillingAccount w/ 0 balance
Map<String, Object> results = createBillingAccountFromReturn(returnHeader, returnItems, dctx, context);Avoid deeply nested control flow statements. Open
Open
if (inventoryItem.get("unitCost") != null) {
itemCost = inventoryItem.getBigDecimal("unitCost");
} else {
Debug.logInfo("Found item cost; but cost was null. Returning default amount (0.00)", module);
}Method groupReturnItemsByOrder has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
public static void groupReturnItemsByOrder(List<GenericValue> returnItems, Map<String, List<GenericValue>> returnItemsByOrderId, Map<String, BigDecimal> totalByOrder, Delegator delegator, String returnId, String returnTypeId) {Avoid deeply nested control flow statements. Open
Open
if (returnItemResponse != null) {
String replacementOrderId = returnItemResponse.getString("replacementOrderId");
Map<String, Object> svcCtx = UtilMisc.<String, Object>toMap("orderId", replacementOrderId, "userLogin", userLogin);
GenericValue orderHeader = EntityQuery.use(delegator).from("OrderHeader").where("orderId", replacementOrderId).queryOne();
if ("ORDER_HOLD".equals(orderHeader.getString("statusId"))) {Avoid deeply nested control flow statements. Open
Open
if (prefSplitMap.containsKey(paymentMethodTypeId)) {
(prefSplitMap.get(paymentMethodTypeId)).add(orderPayPrefDetails);
} else {
prefSplitMap.put(paymentMethodTypeId, UtilMisc.toList(orderPayPrefDetails));
}Avoid deeply nested control flow statements. Open
Open
for (GenericValue itemAdjustment : itemAdjustments) {
returnInfo = new HashMap<>();
returnInfo.put("returnableQuantity", BigDecimal.ONE);
// TODO: the returnablePrice should be set to the amount minus the already returned amount
returnInfo.put("returnablePrice", itemAdjustment.get("amount"));Avoid deeply nested control flow statements. Open
Open
if (UtilValidate.isEmpty(quantityIssued) || quantityIssued.compareTo(BigDecimal.ZERO) == 0) {
try {
GenericValue itemProduct = item.getRelatedOne("Product", false);
if (ProductWorker.isPhysical(itemProduct)) {
continue;Avoid deeply nested control flow statements. Open
Open
if (parties == null) {
parties = new LinkedList<>();
orderRolesMap.put(orderRole.getString("roleTypeId"), parties);
}Avoid deeply nested control flow statements. Open
Open
if (ServiceUtil.isError(updateReturnItemResult)) {
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemStoringReturnItemUpdates", locale), null, null, updateReturnItemResult);
}Avoid deeply nested control flow statements. Open
Open
if (paymentMethodId != null || "FIN_ACCOUNT".equals(paymentMethodTypeId)) {
opp.set("statusId", "PAYMENT_NOT_AUTH");
} else if (paymentMethodTypeId != null) {
// external payment method types require notification when received
// internal payment method types are assumed to be in-handAvoid deeply nested control flow statements. Open
Open
if (amount == null) {
amount = BigDecimal.ZERO;
}Avoid deeply nested control flow statements. Open
Open
if (orderItem != null) {
BigDecimal quantity = returnItem.getBigDecimal("returnQuantity");
BigDecimal unitPrice = returnItem.getBigDecimal("returnPrice");
if (quantity != null && unitPrice != null) {
orderPriceTotal = orderPriceTotal.add(quantity.multiply(unitPrice));Avoid deeply nested control flow statements. Open
Open
if (ServiceUtil.isError(serviceResult)) {
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
}Avoid deeply nested control flow statements. Open
Open
if (ServiceUtil.isError(serviceResult)) {
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
}Avoid deeply nested control flow statements. Open
Open
if (quantity == null) {
quantity = BigDecimal.ZERO;
}Avoid deeply nested control flow statements. Open
Open
while (pmtppit.hasNext() && amountLeftToRefund.compareTo(ZERO) == 1) {
Map<String, Object> orderPaymentPrefDetails = pmtppit.next();
GenericValue orderPaymentPreference = (GenericValue) orderPaymentPrefDetails.get("orderPaymentPreference");
BigDecimal orderPaymentPreferenceAvailable = (BigDecimal) orderPaymentPrefDetails.get("availableTotal");
GenericValue refundOrderPaymentPreference=null;Avoid deeply nested control flow statements. Open
Open
if (thruDate == null || thruDate.after(now)) {
subscription.set("thruDate", now);
try {
delegator.store(subscription);
} catch (GenericEntityException e) {Avoid deeply nested control flow statements. Open
Open
if ("RTN_CSREPLACE".equals(returnTypeId)) {
opp.set("maxAmount", orderPriceTotal);
}Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderErrorUnableToCreateReturnStatusHistory", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemsCreatingReturnItemResponseEntity", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemCreatingReturnItemResponseRecord", locale),
null, null, createReturnItemResponseResult);Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderNoAvailableBillingAccount", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemCreatingPaymentApplicationRecord", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnSuccess();Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemStoringReturnItemUpdates", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnSuccess(successMessage.toString());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(finAccountTransResult));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemCreatingPaymentRecord", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemCreatingReturnItemResponseRecord", locale), null, null, serviceResults);Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemsWithTheRefundSeeLogs", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemUpdatingReturnItemReturnItemResponseId", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderErrorUnableToGetTheItemReturnableQuantity", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(result));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,"OrderProblemsWithTheRefundSeeLogs", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemUpdatingReturnItemReturnItemResponseId", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemsWithGetPartyAcctgPreferences", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource,
"OrderOrderPaymentApplicationFailed",
UtilMisc.toMap("errorString", e.getMessage()), locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));Avoid too many return statements within this method. Open
Open
return result;Avoid too many return statements within this method. Open
Open
return result;Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(createAccountResult));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemStoringReturnItemUpdates", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemCreatingPaymentApplicationRecord", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemsCreatingBillingAccount", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error, "OrderProblemsWithTheRefundSeeLogs", locale));Avoid too many return statements within this method. Open
Open
return result;Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderNoAvailableFinAccount", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemUpdatingReturnItemReturnItemResponseId", locale), null, null, serviceResults);Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnSuccess();Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemSendingEmail", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemsCreatingFinAccountForStore", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemStoringReturnItemUpdates", locale), null, null, serviceResults);Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemSendingEmail", locale), null, null, sendResp);Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnFailure(UtilProperties.getMessage(resourceProduct,
"ProductProductStoreEmailSettingsNotValid",
UtilMisc.toMap("productStoreId", productStoreId,
"emailType", emailType), locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(finAccountRoleResult));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource,
"OrderOrderPaymentFailed", UtilMisc.toMap("errorString", ""), locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemStoringReturnItemUpdates", locale), null, null, updateReturnItemResult);Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderRefundAmountExceedsOrderTotal", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderErrorUnableToGetOrderAdjustmentsFromItem", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderErrorUnableToCreateReturnStatusHistory", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemCreatingFinAccountRoleRecord", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemCreatingPaymentApplicationRecord", locale), null, null, serviceResults);Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnSuccess();Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource,
"OrderOrderPaymentPreferencesCannotGetPaymentMethodTypes",
UtilMisc.toMap("errorString", e.toString()), locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemsCreatingReturnItemResponseEntity", locale), null, null, serviceResults);Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderErrorUnableToGetOrderItemInformation", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderErrorUnableToGetOrderItemInformation", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderErrorWithCreateBillingAccount", locale) + results.get(ModelService.ERROR_MESSAGE));Avoid too many return statements within this method. Open
Open
return serviceResult;Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemUpdatingReturnItemReturnItemResponseId", locale), null, null, serviceResults);Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(paymentApplResult));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderErrorUnableToGetTheItemReturnableProduct", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemCreatingReturnItemResponseRecord", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnSuccess();Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderErrorUnableToCreateReturnStatusHistory", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemCreatingFinAccountTransRecord", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
"OrderProblemCreatingReturnItemResponseRecord", locale));