ilscipio/scipio-erp

View on GitHub
applications/order/src/org/ofbiz/order/order/OrderServices.java

Summary

Maintainability
F
1 wk
Test Coverage

OrderServices has 81 methods (exceeds 20 allowed). Consider refactoring.
Open

public class OrderServices {

    private static final Debug.OfbizLogger module = Debug.getOfbizLogger(java.lang.invoke.MethodHandles.lookup().lookupClass());
    public static final String resource = "OrderUiLabels";
    public static final String resource_error = "OrderErrorUiLabels";
Severity: Major
Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 1 day to fix

    Method reserveInventory has 10 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public static void reserveInventory(Delegator delegator, LocalDispatcher dispatcher, GenericValue userLogin, Locale locale, List<GenericValue> orderItemShipGroupInfo, List<String> dropShipGroupIds, Map<String, GenericValue> itemValuesBySeqId, String orderTypeId, String productStoreId, List<String> resErrorMessages) throws GeneralException {
    Severity: Major
    Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 1 hr to fix

      Method saveUpdatedCartToOrder has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private static void saveUpdatedCartToOrder(LocalDispatcher dispatcher, Delegator delegator, ShoppingCart cart,
                  Locale locale, GenericValue userLogin, String orderId, Map<String, Object> changeMap, boolean calcTax,
                  boolean deleteItems) throws GeneralException {
      Severity: Major
      Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 1 hr to fix

        Method validateOrderItemShipGroupAssoc has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private static String validateOrderItemShipGroupAssoc(Delegator delegator, LocalDispatcher dispatcher, GenericValue orderItem, BigDecimal totalQuantity, GenericValue lastOISGAssoc, GenericValue userLogin, Locale locale)
        Severity: Major
        Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 50 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if ("FixedAsset".equals(currentValue.getEntityName()) && currentValue.getString("fixedAssetId").equals(workEffort.getString("fixedAssetId"))) {
                                      fixedAsset = currentValue;
                                      break;
                                  }
          Severity: Major
          Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if ("TechDataCalendar".equals(currentValue.getEntityName()) && currentValue.getString("calendarId").equals(fixedAsset.getString("calendarId"))) {
                                        techDataCalendar = currentValue;
                                        break;
                                    }
            Severity: Major
            Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      for (GenericValue currentValue : tempList) {
                                          if ("TechDataCalendarExcDay".equals(currentValue.getEntityName()) && currentValue.getString("calendarId").equals(fixedAsset.getString("calendarId"))
                                                  && currentValue.getTimestamp("exceptionDateStartTime").equals(exceptionDateStartTime)) {
                                              techDataCalendarExcDay = currentValue;
                                              break;
              Severity: Major
              Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        if (UtilValidate.isNotEmpty(selFixedAssetProduct)) {
                                            Iterator<GenericValue> firstOne = selFixedAssetProduct.iterator();
                                            if (firstOne.hasNext()) {
                                                GenericValue fixedAssetProduct = delegator.makeValue("FixedAssetProduct");
                                                fixedAssetProduct = firstOne.next();
                Severity: Major
                Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                         if (newUsedCapacity.compareTo(techDataCalendarExcDay.getBigDecimal("exceptionCapacity")) > 0)    {
                                              String errMsg = UtilProperties.getMessage(resource_error, "OrderFixedAssetSoldOut", UtilMisc.toMap("fixedAssetId", workEffort.get("fixedAssetId"), "exceptionDateStartTime", techDataCalendarExcDay.getString("exceptionDateStartTime")), locale);
                                              Debug.logError(errMsg, module);
                                              errorMessages.add(errMsg);
                                              continue;
                  Severity: Major
                  Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                                if (EntityTypeUtil.hasParentType(delegator, "ProductType", "productTypeId", product.getString("productTypeId"), "parentTypeId", "MARKETING_PKG_AUTO")) {
                                                    // do something tricky here: run as the "system" user
                                                    // that can actually create and run a production run
                                                    GenericValue permUserLogin = EntityQuery.use(delegator).from("UserLogin").where("userLoginId", "system").cache().queryOne();
                                                    Map<String, Object> inputMap = new HashMap<>();
                    Severity: Major
                    Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                              if (isDigital != null && "Y".equalsIgnoreCase(isDigital)) {
                                                  // we only invoice APPROVED items
                                                  if ("ITEM_APPROVED".equals(item.getString("statusId"))) {
                                                      digitalItems.add(item);
                                                  }
                      Severity: Major
                      Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                                for (int i = 0; i < itemAdj.size(); i++) {
                                                    List<GenericValue> itemAdjustments = itemAdj.get(i);
                                                    for (GenericValue ia : itemAdjustments) {
                                                        if (ia.get("amount") != null) {
                                                            totalNewOrderTax = totalNewOrderTax.add(ia.getBigDecimal("amount").setScale(taxDecimals, taxRounding));
                        Severity: Major
                        Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                                  if (UtilValidate.isNotEmpty(itemReasonMap)) {
                                                      reasonEnumId = itemReasonMap.get(orderItem.getString("orderItemSeqId"));
                                                  }
                          Severity: Major
                          Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                                    if ((isDigital != null && "Y".equalsIgnoreCase(isDigital)) &&
                                                            (isPhysical == null || !"Y".equalsIgnoreCase(isPhysical))) {
                                                        markComplete = true;
                                                    }
                            Severity: Major
                            Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                                      if (("SHIPPING_CHARGES".equals(stored.get("orderAdjustmentTypeId")) ||
                                                             "SALES_TAX".equals(stored.get("orderAdjustmentTypeId"))) &&
                                                              stored.get("orderId").equals(orderId)) {
                                                          // Removing objects from toStore list for old Shipping and Handling Charges Adjustment and Sales Tax Adjustment.
                                                          removeList.add(stored);
                              Severity: Major
                              Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                Avoid deeply nested control flow statements.
                                Open

                                                            for (GenericValue item : items) {
                                                                try {
                                                                    int itemIndex = cart.addOrIncreaseItem(item.getString("productId"),
                                                                                                           null, // amount
                                                                                                           item.getBigDecimal("quantity"),
                                Severity: Major
                                Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                  Avoid deeply nested control flow statements.
                                  Open

                                                          if (billingAddressList.size() > 0) {
                                                              shippingAddress = billingAddressList.get(0);
                                                          }
                                  Severity: Major
                                  Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                    Avoid deeply nested control flow statements.
                                    Open

                                                                if (ServiceUtil.isError(serviceResult)) {
                                                                    return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
                                                                }
                                    Severity: Major
                                    Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                      Avoid deeply nested control flow statements.
                                      Open

                                                              if (!"ITEM_COMPLETED".equals(statusId)) {
                                                                  allComplete = false;
                                                                  if (!"ITEM_APPROVED".equals(statusId)) {
                                                                      allApproved = false;
                                                                      break;
                                      Severity: Major
                                      Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                        Avoid deeply nested control flow statements.
                                        Open

                                                                if (availableQuantity.compareTo(thisCancelQty) == 0) {
                                                                    try {
                                                                        resp= dispatcher.runSync("deleteOrderItemShipGroupAssoc", localCtx);
                                                                        if (ServiceUtil.isError(resp)) {
                                                                            return ServiceUtil.returnError(ServiceUtil.getErrorMessage(resp));
                                        Severity: Major
                                        Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                          Avoid deeply nested control flow statements.
                                          Open

                                                                      if (orderItemSeqId.equals(orderItem.get("orderItemSeqId"))) {
                                          
                                                                          // Add tax- and shipping-adjustment amounts to the total adjustments for the target order item
                                                                          itemAdjustments = itemAdjustments.add(amount);
                                                                      }
                                          Severity: Major
                                          Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                            Avoid deeply nested control flow statements.
                                            Open

                                                                    if ("ITEM_COMPLETED".equals(itemStatus) && "SALES_ORDER".equals(orh.getOrderTypeId())) {
                                                                        //If partial item shipped then release remaining inventory of SO item and marked SO item as completed.
                                                                        Map<String, Object> cancelOrderItemInvResCtx = UtilMisc.toMap("orderId", orderId, "orderItemSeqId", orderItem.getString("orderItemSeqId"), "shipGroupSeqId",
                                                                                shipGroupSeqId, "cancelQuantity", thisCancelQty, "userLogin", userLogin);
                                                                        try {
                                            Severity: Major
                                            Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                              Avoid deeply nested control flow statements.
                                              Open

                                                                      if ("Y".equals(stored.getString("isManual"))) {
                                                                          // Removing objects from toStore list for Manually added Adjustment.
                                                                          removeList.add(stored);
                                                                      }
                                              Severity: Major
                                              Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                                Avoid deeply nested control flow statements.
                                                Open

                                                                                if (ServiceUtil.isError(ripResult)) {
                                                                                    String errMsg = ServiceUtil.getErrorMessage(ripResult);
                                                                                    @SuppressWarnings("unchecked")
                                                                                    Collection<? extends String> map = (Collection<? extends String>) UtilMisc.<String, String>toMap("reasonCode", "ReceiveInventoryServiceError", "description", errMsg);
                                                                                    resErrorMessages.addAll(map);
                                                Severity: Major
                                                Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                                  Avoid deeply nested control flow statements.
                                                  Open

                                                                              if (product == null) {
                                                                                  Debug.logError("Error when looking up product in reserveInventory service", module);
                                                                                  resErrorMessages.add("Error when looking up product in reserveInventory service");
                                                                                  continue;
                                                                              }
                                                  Severity: Major
                                                  Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                                    Avoid deeply nested control flow statements.
                                                    Open

                                                                                        if (orderStatusList.size() <= 1) {
                                                                                            changeToApprove = false;
                                                                                        }
                                                    Severity: Major
                                                    Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                                      Avoid deeply nested control flow statements.
                                                      Open

                                                                                  if ("ASSET_USAGE_OUT_IN".equals(productType)) {
                                                                                      if (reserveInventory) {
                                                                                          // for MARKETING_PKG_PICK reserve the components
                                                                                          if (EntityTypeUtil.hasParentType(delegator, "ProductType", "productTypeId", product.getString("productTypeId"), "parentTypeId", "MARKETING_PKG_PICK")) {
                                                                                              Map<String, Object> componentsRes = dispatcher.runSync("getAssociatedProducts", UtilMisc.toMap("productId", orderItem.getString("productId"), "type", "PRODUCT_COMPONENT"));
                                                      Severity: Major
                                                      Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                                        Avoid deeply nested control flow statements.
                                                        Open

                                                                                if (facilityId != null) {
                                                                                    GenericValue facilityContactMech = ContactMechWorker.getFacilityContactMechByPurpose(delegator, facilityId, UtilMisc.toList("SHIP_ORIG_LOCATION", "PRIMARY_LOCATION"));
                                                                                    if (facilityContactMech != null) {
                                                                                        try {
                                                                                            shippingAddress = EntityQuery.use(delegator).from("PostalAddress").where("contactMechId", facilityContactMech.getString("contactMechId")).queryOne();
                                                        Severity: Major
                                                        Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                                          Avoid deeply nested control flow statements.
                                                          Open

                                                                                  if (availableQuantity.compareTo(BigDecimal.ZERO) == 0) {
                                                                                      continue;  //OrderItemShipGroupAssoc already cancelled
                                                                                  }
                                                          Severity: Major
                                                          Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                                            Avoid deeply nested control flow statements.
                                                            Open

                                                                                    if ("FULFILLMENT_EXTASYNC".equals(fulfillmentType) || "FULFILLMENT_EXTSYNC".equals(fulfillmentType)) {
                                                                                        // external service fulfillment
                                                                                        String fulfillmentService = (String) content.get("serviceName"); // Kept for backward compatibility
                                                                                        GenericValue custMethod = null;
                                                                                        if (UtilValidate.isNotEmpty(content.getString("customMethodId"))) {
                                                            Severity: Major
                                                            Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                                              Avoid deeply nested control flow statements.
                                                              Open

                                                                                      for (GenericValue oa : orderAdj) {
                                                                                          if (oa.get("amount") != null) {
                                                                                              totalNewOrderTax = totalNewOrderTax.add(oa.getBigDecimal("amount").setScale(taxDecimals, taxRounding));
                                                                                          }
                                                                                      }
                                                              Severity: Major
                                                              Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                                                Avoid deeply nested control flow statements.
                                                                Open

                                                                                            if (UtilValidate.isEmpty(inventoryFacilityId)) {
                                                                                                Debug.logWarning("ProductStore with id " + productStoreId + " has Y for oneInventoryFacility but inventoryFacilityId is empty, returning false for inventory check", module);
                                                                                            }
                                                                Severity: Major
                                                                Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                                                  Avoid deeply nested control flow statements.
                                                                  Open

                                                                                          if (UtilValidate.isNotEmpty(itemCommentMap)) {
                                                                                              changeComments = itemCommentMap.get(orderItem.getString("orderItemSeqId"));
                                                                                          }
                                                                  Severity: Major
                                                                  Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                                                    Avoid deeply nested control flow statements.
                                                                    Open

                                                                                                if (ServiceUtil.isError(resp)) {
                                                                                                    return ServiceUtil.returnError(ServiceUtil.getErrorMessage(resp));
                                                                                                }
                                                                    Severity: Major
                                                                    Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                                                      Avoid deeply nested control flow statements.
                                                                      Open

                                                                                              if (UtilValidate.isNotEmpty(attrName)) {
                                                                                                  cartItem.setOrderItemAttribute(attrName, attrValue);
                                                                                                  Debug.logInfo("Set item attribute Name: [" + itemSeqId + "] " + attrName + " , Value:" + attrValue, module);
                                                                                              }
                                                                      Severity: Major
                                                                      Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                                                        Avoid deeply nested control flow statements.
                                                                        Open

                                                                                                    if (reserveInventory) {
                                                                                                        // for MARKETING_PKG_PICK reserve the components
                                                                                                        if (EntityTypeUtil.hasParentType(delegator, "ProductType", "productTypeId", product.getString("productTypeId"), "parentTypeId", "MARKETING_PKG_PICK")) {
                                                                                                            Map<String, Object> componentsRes = dispatcher.runSync("getAssociatedProducts", UtilMisc.toMap("productId", orderItem.getString("productId"), "type", "PRODUCT_COMPONENT"));
                                                                                                            if (ServiceUtil.isError(componentsRes)) {
                                                                        Severity: Major
                                                                        Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                                                          Avoid deeply nested control flow statements.
                                                                          Open

                                                                                                              if (ServiceUtil.isError(serviceResult)) {
                                                                                                                  return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
                                                                                                              }
                                                                          Severity: Major
                                                                          Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                                                            Avoid deeply nested control flow statements.
                                                                            Open

                                                                                                        if (product == null) {
                                                                                                            Debug.logError("Error when looking up product in reserveInventory service", module);
                                                                                                            resErrorMessages.add("Error when looking up product in reserveInventory service");
                                                                                                            continue;
                                                                                                        }
                                                                            Severity: Major
                                                                            Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 45 mins to fix

                                                                              Method hasPermission has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                                              Open

                                                                                  private static boolean hasPermission(String orderId, GenericValue userLogin, String action, Security security, Delegator delegator) {
                                                                              Severity: Minor
                                                                              Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 35 mins to fix

                                                                                Method hasPermission has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                                                Open

                                                                                    private static boolean hasPermission(String orderTypeId, String partyId, GenericValue userLogin, String action, Security security) {
                                                                                Severity: Minor
                                                                                Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 35 mins to fix

                                                                                  Avoid too many return statements within this method.
                                                                                  Open

                                                                                                  return ServiceUtil.returnError(e.getMessage());
                                                                                  Severity: Major
                                                                                  Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                    Avoid too many return statements within this method.
                                                                                    Open

                                                                                            return ServiceUtil.returnSuccess(UtilProperties.getMessage(resource, "OrderOrderItemCancelled", locale));
                                                                                    Severity: Major
                                                                                    Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                      Avoid too many return statements within this method.
                                                                                      Open

                                                                                              return ServiceUtil.returnSuccess();
                                                                                      Severity: Major
                                                                                      Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                        Avoid too many return statements within this method.
                                                                                        Open

                                                                                                        return ServiceUtil.returnError(e.getMessage());
                                                                                        Severity: Major
                                                                                        Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                          Avoid too many return statements within this method.
                                                                                          Open

                                                                                                          return ServiceUtil.returnError(ServiceUtil.getErrorMessage(result));
                                                                                          Severity: Major
                                                                                          Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                            Avoid too many return statements within this method.
                                                                                            Open

                                                                                                        return ServiceUtil.returnError(ServiceUtil.getErrorMessage(createResp));
                                                                                            Severity: Major
                                                                                            Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                              Avoid too many return statements within this method.
                                                                                              Open

                                                                                                              return ServiceUtil.returnError(errMsg);
                                                                                              Severity: Major
                                                                                              Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                Avoid too many return statements within this method.
                                                                                                Open

                                                                                                                        return ServiceUtil.returnError(errMsg, null, null, getNextOrderIdResult);
                                                                                                Severity: Major
                                                                                                Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                  Avoid too many return statements within this method.
                                                                                                  Open

                                                                                                                          return ServiceUtil.returnError(UtilProperties.getMessage(resource,
                                                                                                                                  "OrderOrderNoteCannotBeCreated", UtilMisc.toMap("errorString", ""), locale),
                                                                                                                                  null, null, noteOutputMap);
                                                                                                  Severity: Major
                                                                                                  Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                    Avoid too many return statements within this method.
                                                                                                    Open

                                                                                                                                return ServiceUtil.returnError(e.getMessage());
                                                                                                    Severity: Major
                                                                                                    Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                      Avoid too many return statements within this method.
                                                                                                      Open

                                                                                                                                  return ServiceUtil.returnError(ServiceUtil.getErrorMessage(resp));
                                                                                                      Severity: Major
                                                                                                      Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                        Avoid too many return statements within this method.
                                                                                                        Open

                                                                                                                        return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                "OrderCannotUpdateProblemSettingOrderShipmentPreference", locale));
                                                                                                        Severity: Major
                                                                                                        Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                          Avoid too many return statements within this method.
                                                                                                          Open

                                                                                                                          return ServiceUtil.returnError(mainErrorMessage + ServiceUtil.getErrorMessage(result)); // SCIPIO: 2018-10-09: Kept mainErrorMessage
                                                                                                          Severity: Major
                                                                                                          Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                            Avoid too many return statements within this method.
                                                                                                            Open

                                                                                                                                return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                        "OrderFixedAssetNotFoundFixedAssetId",
                                                                                                                                        UtilMisc.toMap("fixedAssetId",workEffort.get("fixedAssetId")), locale));
                                                                                                            Severity: Major
                                                                                                            Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                              Avoid too many return statements within this method.
                                                                                                              Open

                                                                                                                                      return ServiceUtil.returnSuccess();
                                                                                                              Severity: Major
                                                                                                              Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                Avoid too many return statements within this method.
                                                                                                                Open

                                                                                                                                            return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                    "OrderUnableToCancelOrderLine", UtilMisc.toMap("itemMsgInfo",itemMsgInfo), locale));
                                                                                                                Severity: Major
                                                                                                                Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                  Avoid too many return statements within this method.
                                                                                                                  Open

                                                                                                                                      return ServiceUtil.returnError(UtilProperties.getMessage(resource_error, "cart.addToCart.quantityInDecimalNotAllowed", locale));
                                                                                                                  Severity: Major
                                                                                                                  Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                    Avoid too many return statements within this method.
                                                                                                                    Open

                                                                                                                                    return ServiceUtil.returnError(resErrorMessages);
                                                                                                                    Severity: Major
                                                                                                                    Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                      Avoid too many return statements within this method.
                                                                                                                      Open

                                                                                                                                              return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                      "OrderProblemOccurredInTaxService",locale));
                                                                                                                      Severity: Major
                                                                                                                      Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                        Avoid too many return statements within this method.
                                                                                                                        Open

                                                                                                                                            return ServiceUtil.returnError(createOrderAdjErrMsg);
                                                                                                                        Severity: Major
                                                                                                                        Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                          Avoid too many return statements within this method.
                                                                                                                          Open

                                                                                                                                      return ServiceUtil.returnError(e.getMessage());
                                                                                                                          Severity: Major
                                                                                                                          Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                            Avoid too many return statements within this method.
                                                                                                                            Open

                                                                                                                                        return ServiceUtil.returnError(e.getMessage());
                                                                                                                            Severity: Major
                                                                                                                            Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                              Avoid too many return statements within this method.
                                                                                                                              Open

                                                                                                                                          return(ServiceUtil.returnError(ex.getMessage()));
                                                                                                                              Severity: Major
                                                                                                                              Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                Avoid too many return statements within this method.
                                                                                                                                Open

                                                                                                                                                    return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                            "OrderRentalOrderItems",locale));
                                                                                                                                Severity: Major
                                                                                                                                Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                  Avoid too many return statements within this method.
                                                                                                                                  Open

                                                                                                                                          return ServiceUtil.returnSuccess();
                                                                                                                                  Severity: Major
                                                                                                                                  Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                    Avoid too many return statements within this method.
                                                                                                                                    Open

                                                                                                                                                        return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                "OrderErrorCannotStoreStatusChanges", locale) + e.getMessage());
                                                                                                                                    Severity: Major
                                                                                                                                    Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                      Avoid too many return statements within this method.
                                                                                                                                      Open

                                                                                                                                                  return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                          "OrderServiceExceptionSeeLogs",locale));
                                                                                                                                      Severity: Major
                                                                                                                                      Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                        Avoid too many return statements within this method.
                                                                                                                                        Open

                                                                                                                                                                return ServiceUtil.returnError(UtilProperties.getMessage(resource,
                                                                                                                                                                        "OrderItemDescriptionCannotBeEmpty", locale));
                                                                                                                                        Severity: Major
                                                                                                                                        Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                          Avoid too many return statements within this method.
                                                                                                                                          Open

                                                                                                                                                      return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                              "OrderErrorTheProductStoreIdCanOnlyBeNullForPurchaseOrders",locale));
                                                                                                                                          Severity: Major
                                                                                                                                          Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                            Avoid too many return statements within this method.
                                                                                                                                            Open

                                                                                                                                                        return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                "OrderOrderCreationFailedPleaseNotifyCustomerService",locale));
                                                                                                                                            Severity: Major
                                                                                                                                            Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                              Avoid too many return statements within this method.
                                                                                                                                              Open

                                                                                                                                                                      return ServiceUtil.returnError(UtilProperties.getMessage(resource,
                                                                                                                                                                          "OrderOrderNoteCannotBeCreated", UtilMisc.toMap("errorString", ""), locale),
                                                                                                                                                                          null, null, noteOutputMap);
                                                                                                                                              Severity: Major
                                                                                                                                              Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                Avoid too many return statements within this method.
                                                                                                                                                Open

                                                                                                                                                                        return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
                                                                                                                                                Severity: Major
                                                                                                                                                Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                  Avoid too many return statements within this method.
                                                                                                                                                  Open

                                                                                                                                                                      return ServiceUtil.returnError(createOrderAdjErrMsg);
                                                                                                                                                  Severity: Major
                                                                                                                                                  Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                    Avoid too many return statements within this method.
                                                                                                                                                    Open

                                                                                                                                                                            return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                    "OrderErrorCouldNotChangeItemStatus", locale) + newItemStatusId, null, null, resp);
                                                                                                                                                    Severity: Major
                                                                                                                                                    Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                      Avoid too many return statements within this method.
                                                                                                                                                      Open

                                                                                                                                                                      return ServiceUtil.returnError(ServiceUtil.getErrorMessage(result));
                                                                                                                                                      Severity: Major
                                                                                                                                                      Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                        Avoid too many return statements within this method.
                                                                                                                                                        Open

                                                                                                                                                                return ServiceUtil.returnSuccess();
                                                                                                                                                        Severity: Major
                                                                                                                                                        Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                          Avoid too many return statements within this method.
                                                                                                                                                          Open

                                                                                                                                                                                  return ServiceUtil.returnError(errMsg);
                                                                                                                                                          Severity: Major
                                                                                                                                                          Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                            Avoid too many return statements within this method.
                                                                                                                                                            Open

                                                                                                                                                                                return ServiceUtil.returnError(errMsg);
                                                                                                                                                            Severity: Major
                                                                                                                                                            Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                              Avoid too many return statements within this method.
                                                                                                                                                              Open

                                                                                                                                                                                  return ServiceUtil.returnError(UtilProperties.getMessage(resource,
                                                                                                                                                                                          "OrderOrderNoteCannotBeCreated", UtilMisc.toMap("errorString", e.toString()), locale));
                                                                                                                                                              Severity: Major
                                                                                                                                                              Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                Avoid too many return statements within this method.
                                                                                                                                                                Open

                                                                                                                                                                            return ServiceUtil.returnError(errorMessages);
                                                                                                                                                                Severity: Major
                                                                                                                                                                Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                  Avoid too many return statements within this method.
                                                                                                                                                                  Open

                                                                                                                                                                                      return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                              "OrderErrorCouldNotGetNextSequenceIdForOrderItemPriceInfoCannotCreateOrder",locale));
                                                                                                                                                                  Severity: Major
                                                                                                                                                                  Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                    Avoid too many return statements within this method.
                                                                                                                                                                    Open

                                                                                                                                                                            return ServiceUtil.returnSuccess();
                                                                                                                                                                    Severity: Major
                                                                                                                                                                    Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                      Avoid too many return statements within this method.
                                                                                                                                                                      Open

                                                                                                                                                                                          return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                                  "OrderInvalidCancelQuantityCannotCancel", UtilMisc.toMap("thisCancelQty",thisCancelQty), locale));
                                                                                                                                                                      Severity: Major
                                                                                                                                                                      Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                        Avoid too many return statements within this method.
                                                                                                                                                                        Open

                                                                                                                                                                                            return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                                    "OrderErrorCouldNotChangeItemStatus", locale) + newItemStatusId + ": " + e.toString());
                                                                                                                                                                        Severity: Major
                                                                                                                                                                        Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                          Avoid too many return statements within this method.
                                                                                                                                                                          Open

                                                                                                                                                                                                      return ServiceUtil.returnError(UtilProperties.getMessage(resource_error, "cart.addToCart.quantityInDecimalNotAllowed", locale));
                                                                                                                                                                          Severity: Major
                                                                                                                                                                          Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                            Avoid too many return statements within this method.
                                                                                                                                                                            Open

                                                                                                                                                                                    return ServiceUtil.returnSuccess();
                                                                                                                                                                            Severity: Major
                                                                                                                                                                            Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                              Avoid too many return statements within this method.
                                                                                                                                                                              Open

                                                                                                                                                                                      return ServiceUtil.returnSuccess();
                                                                                                                                                                              Severity: Major
                                                                                                                                                                              Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                Avoid too many return statements within this method.
                                                                                                                                                                                Open

                                                                                                                                                                                        return ServiceUtil.returnSuccess(UtilProperties.getMessage(resource,
                                                                                                                                                                                                "OrderRunSubscriptionAutoReorders", UtilMisc.toMap("count", count), locale));
                                                                                                                                                                                Severity: Major
                                                                                                                                                                                Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                  Avoid too many return statements within this method.
                                                                                                                                                                                  Open

                                                                                                                                                                                                  return ServiceUtil.returnError(errMsg);
                                                                                                                                                                                  Severity: Major
                                                                                                                                                                                  Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                    Avoid too many return statements within this method.
                                                                                                                                                                                    Open

                                                                                                                                                                                                                return ServiceUtil.returnError(errMsg);
                                                                                                                                                                                    Severity: Major
                                                                                                                                                                                    Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                      Avoid too many return statements within this method.
                                                                                                                                                                                      Open

                                                                                                                                                                                                      return result;
                                                                                                                                                                                      Severity: Major
                                                                                                                                                                                      Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                        Avoid too many return statements within this method.
                                                                                                                                                                                        Open

                                                                                                                                                                                                return result;
                                                                                                                                                                                        Severity: Major
                                                                                                                                                                                        Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                          Avoid too many return statements within this method.
                                                                                                                                                                                          Open

                                                                                                                                                                                                      return ServiceUtil.returnError(UtilProperties.getMessage(resource_error, "items.none", locale));
                                                                                                                                                                                          Severity: Major
                                                                                                                                                                                          Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                            Avoid too many return statements within this method.
                                                                                                                                                                                            Open

                                                                                                                                                                                                                return ServiceUtil.returnError(UtilProperties.getMessage(resource,
                                                                                                                                                                                                                        "OrderOrderNoteCannotBeCreated", UtilMisc.toMap("errorString", e.toString()), locale));
                                                                                                                                                                                            Severity: Major
                                                                                                                                                                                            Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                              Avoid too many return statements within this method.
                                                                                                                                                                                              Open

                                                                                                                                                                                                      return ServiceUtil.returnSuccess();
                                                                                                                                                                                              Severity: Major
                                                                                                                                                                                              Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                Avoid too many return statements within this method.
                                                                                                                                                                                                Open

                                                                                                                                                                                                                    return ServiceUtil.returnError(ServiceUtil.getErrorMessage(newSttsResult));
                                                                                                                                                                                                Severity: Major
                                                                                                                                                                                                Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                  Avoid too many return statements within this method.
                                                                                                                                                                                                  Open

                                                                                                                                                                                                                          return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                                                                  "OrderUnableToSetCancelQuantity", UtilMisc.toMap("itemMsgInfo",itemMsgInfo), locale));
                                                                                                                                                                                                  Severity: Major
                                                                                                                                                                                                  Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                    Avoid too many return statements within this method.
                                                                                                                                                                                                    Open

                                                                                                                                                                                                                                    return ServiceUtil.returnError(e.getMessage());
                                                                                                                                                                                                    Severity: Major
                                                                                                                                                                                                    Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                      Avoid too many return statements within this method.
                                                                                                                                                                                                      Open

                                                                                                                                                                                                                                  return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                                                                          "OrderUnableToUpdateInventoryReservations", UtilMisc.toMap("itemMsgInfo",itemMsgInfo), locale));
                                                                                                                                                                                                      Severity: Major
                                                                                                                                                                                                      Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                        Avoid too many return statements within this method.
                                                                                                                                                                                                        Open

                                                                                                                                                                                                                    return result;
                                                                                                                                                                                                        Severity: Major
                                                                                                                                                                                                        Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                          Avoid too many return statements within this method.
                                                                                                                                                                                                          Open

                                                                                                                                                                                                                      return ServiceUtil.returnError(e.getMessage());
                                                                                                                                                                                                          Severity: Major
                                                                                                                                                                                                          Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                            Avoid too many return statements within this method.
                                                                                                                                                                                                            Open

                                                                                                                                                                                                                                                return ServiceUtil.returnError(ServiceUtil.getErrorMessage(resp));
                                                                                                                                                                                                            Severity: Major
                                                                                                                                                                                                            Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                              Avoid too many return statements within this method.
                                                                                                                                                                                                              Open

                                                                                                                                                                                                                              return ServiceUtil.returnError(ServiceUtil.getErrorMessage(sendResp));
                                                                                                                                                                                                              Severity: Major
                                                                                                                                                                                                              Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                Avoid too many return statements within this method.
                                                                                                                                                                                                                Open

                                                                                                                                                                                                                                return ServiceUtil.returnSuccess((String)fulfillResult.get(ModelService.ERROR_MESSAGE));
                                                                                                                                                                                                                Severity: Major
                                                                                                                                                                                                                Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                  Avoid too many return statements within this method.
                                                                                                                                                                                                                  Open

                                                                                                                                                                                                                          return result;
                                                                                                                                                                                                                  Severity: Major
                                                                                                                                                                                                                  Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                    Avoid too many return statements within this method.
                                                                                                                                                                                                                    Open

                                                                                                                                                                                                                                return ServiceUtil.returnSuccess();
                                                                                                                                                                                                                    Severity: Major
                                                                                                                                                                                                                    Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                      Avoid too many return statements within this method.
                                                                                                                                                                                                                      Open

                                                                                                                                                                                                                                                      return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,"OrderUnableToUpdateInventoryReservations", UtilMisc.toMap("itemMsgInfo",itemMsgInfo), locale));
                                                                                                                                                                                                                      Severity: Major
                                                                                                                                                                                                                      Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                        Avoid too many return statements within this method.
                                                                                                                                                                                                                        Open

                                                                                                                                                                                                                                                    return ServiceUtil.returnError(UtilProperties.getMessage(resource_error, "cart.addToCart.quantityInDecimalNotAllowed", locale));
                                                                                                                                                                                                                        Severity: Major
                                                                                                                                                                                                                        Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                          Avoid too many return statements within this method.
                                                                                                                                                                                                                          Open

                                                                                                                                                                                                                                              return ServiceUtil.returnError(e.getMessage());
                                                                                                                                                                                                                          Severity: Major
                                                                                                                                                                                                                          Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                            Avoid too many return statements within this method.
                                                                                                                                                                                                                            Open

                                                                                                                                                                                                                                                return ServiceUtil.returnError(e.toString());
                                                                                                                                                                                                                            Severity: Major
                                                                                                                                                                                                                            Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                              Avoid too many return statements within this method.
                                                                                                                                                                                                                              Open

                                                                                                                                                                                                                                                  return ServiceUtil.returnError(UtilProperties.getMessage(resource_error, 
                                                                                                                                                                                                                                                          "OrderErrorCallingCountProductQuantityOrderedService",locale) + e1.toString());
                                                                                                                                                                                                                              Severity: Major
                                                                                                                                                                                                                              Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                Avoid too many return statements within this method.
                                                                                                                                                                                                                                Open

                                                                                                                                                                                                                                                    return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                                                                                            "OrderFixedAssetNotFoundFixedAssetId",
                                                                                                                                                                                                                                                            UtilMisc.toMap("fixedAssetId",workEffort.get("fixedAssetId")), locale));
                                                                                                                                                                                                                                Severity: Major
                                                                                                                                                                                                                                Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                  Avoid too many return statements within this method.
                                                                                                                                                                                                                                  Open

                                                                                                                                                                                                                                                              return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                                                                                                      "OrderCannotReadTheOrderItemEntity",locale));
                                                                                                                                                                                                                                  Severity: Major
                                                                                                                                                                                                                                  Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                    Avoid too many return statements within this method.
                                                                                                                                                                                                                                    Open

                                                                                                                                                                                                                                                    return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                                                                                            "OrderErrorCouldNotChangeOrderStatus",locale) + " (" + e.getMessage() + ").");
                                                                                                                                                                                                                                    Severity: Major
                                                                                                                                                                                                                                    Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                      Avoid too many return statements within this method.
                                                                                                                                                                                                                                      Open

                                                                                                                                                                                                                                              return successResult;
                                                                                                                                                                                                                                      Severity: Major
                                                                                                                                                                                                                                      Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                        Avoid too many return statements within this method.
                                                                                                                                                                                                                                        Open

                                                                                                                                                                                                                                                    return ServiceUtil.returnError(errMsg);
                                                                                                                                                                                                                                        Severity: Major
                                                                                                                                                                                                                                        Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                          Avoid too many return statements within this method.
                                                                                                                                                                                                                                          Open

                                                                                                                                                                                                                                                      return ServiceUtil.returnError(errorMessages);
                                                                                                                                                                                                                                          Severity: Major
                                                                                                                                                                                                                                          Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                            Avoid too many return statements within this method.
                                                                                                                                                                                                                                            Open

                                                                                                                                                                                                                                                                return ServiceUtil.returnError(ServiceUtil.getErrorMessage(createOrderAdjResponse));
                                                                                                                                                                                                                                            Severity: Major
                                                                                                                                                                                                                                            Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                              Avoid too many return statements within this method.
                                                                                                                                                                                                                                              Open

                                                                                                                                                                                                                                                      return sendResp;
                                                                                                                                                                                                                                              Severity: Major
                                                                                                                                                                                                                                              Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                Avoid too many return statements within this method.
                                                                                                                                                                                                                                                Open

                                                                                                                                                                                                                                                        return result;
                                                                                                                                                                                                                                                Severity: Major
                                                                                                                                                                                                                                                Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                  Avoid too many return statements within this method.
                                                                                                                                                                                                                                                  Open

                                                                                                                                                                                                                                                                              return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                                                                                                                      "OrderCouldNotFindRelatedFixedAssetForTheProduct",UtilMisc.toMap("productId",orderItem.getString("productId")), locale));
                                                                                                                                                                                                                                                  Severity: Major
                                                                                                                                                                                                                                                  Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                    Avoid too many return statements within this method.
                                                                                                                                                                                                                                                    Open

                                                                                                                                                                                                                                                            return successResult;
                                                                                                                                                                                                                                                    Severity: Major
                                                                                                                                                                                                                                                    Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                      Avoid too many return statements within this method.
                                                                                                                                                                                                                                                      Open

                                                                                                                                                                                                                                                              return ServiceUtil.returnSuccess();
                                                                                                                                                                                                                                                      Severity: Major
                                                                                                                                                                                                                                                      Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                        Avoid too many return statements within this method.
                                                                                                                                                                                                                                                        Open

                                                                                                                                                                                                                                                                return ServiceUtil.returnSuccess();
                                                                                                                                                                                                                                                        Severity: Major
                                                                                                                                                                                                                                                        Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                          Avoid too many return statements within this method.
                                                                                                                                                                                                                                                          Open

                                                                                                                                                                                                                                                                          return ServiceUtil.returnError(e.getMessage());
                                                                                                                                                                                                                                                          Severity: Major
                                                                                                                                                                                                                                                          Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                            Avoid too many return statements within this method.
                                                                                                                                                                                                                                                            Open

                                                                                                                                                                                                                                                                        return ServiceUtil.returnError(e.getMessage());
                                                                                                                                                                                                                                                            Severity: Major
                                                                                                                                                                                                                                                            Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                              Avoid too many return statements within this method.
                                                                                                                                                                                                                                                              Open

                                                                                                                                                                                                                                                                                  return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                                                                                                                          "OrderErrorCouldNotGetNextSequenceIdForOrderAdjustmentCannotCreateOrder",locale));
                                                                                                                                                                                                                                                              Severity: Major
                                                                                                                                                                                                                                                              Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                                Avoid too many return statements within this method.
                                                                                                                                                                                                                                                                Open

                                                                                                                                                                                                                                                                                        return ServiceUtil.returnError(ServiceUtil.getErrorMessage(localResult));
                                                                                                                                                                                                                                                                Severity: Major
                                                                                                                                                                                                                                                                Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                                  Avoid too many return statements within this method.
                                                                                                                                                                                                                                                                  Open

                                                                                                                                                                                                                                                                          return ServiceUtil.returnSuccess();
                                                                                                                                                                                                                                                                  Severity: Major
                                                                                                                                                                                                                                                                  Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                                    Avoid too many return statements within this method.
                                                                                                                                                                                                                                                                    Open

                                                                                                                                                                                                                                                                                return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                                                                                                                        "OrderErrorCouldNotChangeOrderStatus",locale) + " (" + e.getMessage() + ").");
                                                                                                                                                                                                                                                                    Severity: Major
                                                                                                                                                                                                                                                                    Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                                      Avoid too many return statements within this method.
                                                                                                                                                                                                                                                                      Open

                                                                                                                                                                                                                                                                                  return ServiceUtil.returnError(UtilProperties.getMessage(resource, "OrderShoppingCartEmpty", locale));
                                                                                                                                                                                                                                                                      Severity: Major
                                                                                                                                                                                                                                                                      Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                                        Avoid too many return statements within this method.
                                                                                                                                                                                                                                                                        Open

                                                                                                                                                                                                                                                                                                    return ServiceUtil.returnError(e.getMessage());
                                                                                                                                                                                                                                                                        Severity: Major
                                                                                                                                                                                                                                                                        Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                                          Avoid too many return statements within this method.
                                                                                                                                                                                                                                                                          Open

                                                                                                                                                                                                                                                                                  return ServiceUtil.returnSuccess();
                                                                                                                                                                                                                                                                          Severity: Major
                                                                                                                                                                                                                                                                          Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                                            Avoid too many return statements within this method.
                                                                                                                                                                                                                                                                            Open

                                                                                                                                                                                                                                                                                            return ServiceUtil.returnError(errMsg);
                                                                                                                                                                                                                                                                            Severity: Major
                                                                                                                                                                                                                                                                            Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                                              Avoid too many return statements within this method.
                                                                                                                                                                                                                                                                              Open

                                                                                                                                                                                                                                                                                                                      return ServiceUtil.returnError(UtilProperties.getMessage(resource,
                                                                                                                                                                                                                                                                                                                              "OrderOrderExternalFulfillmentError", locale), null, null, resp);
                                                                                                                                                                                                                                                                              Severity: Major
                                                                                                                                                                                                                                                                              Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                                                Avoid too many return statements within this method.
                                                                                                                                                                                                                                                                                Open

                                                                                                                                                                                                                                                                                            return ServiceUtil.returnError(e.getMessage());
                                                                                                                                                                                                                                                                                Severity: Major
                                                                                                                                                                                                                                                                                Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                                                  Avoid too many return statements within this method.
                                                                                                                                                                                                                                                                                  Open

                                                                                                                                                                                                                                                                                          return result;
                                                                                                                                                                                                                                                                                  Severity: Major
                                                                                                                                                                                                                                                                                  Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                                                    Avoid too many return statements within this method.
                                                                                                                                                                                                                                                                                    Open

                                                                                                                                                                                                                                                                                                return ServiceUtil.returnError(ServiceUtil.getErrorMessage(authResp));
                                                                                                                                                                                                                                                                                    Severity: Major
                                                                                                                                                                                                                                                                                    Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                                                      Avoid too many return statements within this method.
                                                                                                                                                                                                                                                                                      Open

                                                                                                                                                                                                                                                                                              return result;
                                                                                                                                                                                                                                                                                      Severity: Major
                                                                                                                                                                                                                                                                                      Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                                                        Avoid too many return statements within this method.
                                                                                                                                                                                                                                                                                        Open

                                                                                                                                                                                                                                                                                                return ServiceUtil.returnError(errMsg);
                                                                                                                                                                                                                                                                                        Severity: Major
                                                                                                                                                                                                                                                                                        Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                                                          Avoid too many return statements within this method.
                                                                                                                                                                                                                                                                                          Open

                                                                                                                                                                                                                                                                                                                  return ServiceUtil.returnError(ServiceUtil.getErrorMessage(result));
                                                                                                                                                                                                                                                                                          Severity: Major
                                                                                                                                                                                                                                                                                          Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                                                            Avoid too many return statements within this method.
                                                                                                                                                                                                                                                                                            Open

                                                                                                                                                                                                                                                                                                        return ServiceUtil.returnError(UtilProperties.getMessage(resource_error,
                                                                                                                                                                                                                                                                                                                "OrderErrorCouldNotCreateOrderWriteError",locale) + e.getMessage() + ").");
                                                                                                                                                                                                                                                                                            Severity: Major
                                                                                                                                                                                                                                                                                            Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                                                              Avoid too many return statements within this method.
                                                                                                                                                                                                                                                                                              Open

                                                                                                                                                                                                                                                                                                                              return ServiceUtil.returnError(ServiceUtil.getErrorMessage(resp));
                                                                                                                                                                                                                                                                                              Severity: Major
                                                                                                                                                                                                                                                                                              Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                                                                Avoid too many return statements within this method.
                                                                                                                                                                                                                                                                                                Open

                                                                                                                                                                                                                                                                                                        return ServiceUtil.returnSuccess();
                                                                                                                                                                                                                                                                                                Severity: Major
                                                                                                                                                                                                                                                                                                Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                                                                  Avoid too many return statements within this method.
                                                                                                                                                                                                                                                                                                  Open

                                                                                                                                                                                                                                                                                                                  return ServiceUtil.returnError(ServiceUtil.getErrorMessage(result));
                                                                                                                                                                                                                                                                                                  Severity: Major
                                                                                                                                                                                                                                                                                                  Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                                                                    Avoid too many return statements within this method.
                                                                                                                                                                                                                                                                                                    Open

                                                                                                                                                                                                                                                                                                                    return ServiceUtil.returnError(errMsg);
                                                                                                                                                                                                                                                                                                    Severity: Major
                                                                                                                                                                                                                                                                                                    Found in applications/order/src/org/ofbiz/order/order/OrderServices.java - About 30 mins to fix

                                                                                                                                                                                                                                                                                                      There are no issues that match your filters.

                                                                                                                                                                                                                                                                                                      Category
                                                                                                                                                                                                                                                                                                      Status