Sign upLogin

ilscipio/scipio-erp

View on GitHub
Star
applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java

Summary

Maintainability
F
3 days
Test Coverage

CheckOutHelper has 44 methods (exceeds 20 allowed). Consider refactoring.
Open

public class CheckOutHelper {

    private static final Debug.OfbizLogger module = Debug.getOfbizLogger(java.lang.invoke.MethodHandles.lookup().lookupClass());
    public static final String resource = "OrderUiLabels";
    public static final String resource_error = "OrderErrorUiLabels";
Severity: Minor
Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 6 hrs to fix

    Method setCheckOutOptions has 13 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public Map<String, Object> setCheckOutOptions(String shippingMethod, String shippingContactMechId, Map<String, Map<String, Object>> selectedPaymentMethods,
            List<String> singleUsePayments, String billingAccountId, String shippingInstructions,
            String orderAdditionalEmails, String maySplit, String giftMessage, String isGift, String internalCode, String shipBeforeDate, String shipAfterDate) {
    Severity: Major
    Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 1 hr to fix

      Method finalizeOrderEntryOptions has 12 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public Map<String, Object> finalizeOrderEntryOptions(int shipGroupIndex, String shippingMethod, String shippingInstructions, String maySplit,
            String giftMessage, String isGift, String internalCode, String shipBeforeDate, String shipAfterDate, String internalOrderNotes, String shippingNotes, BigDecimal shipEstimate) {
      Severity: Major
      Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 1 hr to fix

        Method finalizeOrderEntryOptions has 11 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public Map<String, Object> finalizeOrderEntryOptions(int shipGroupIndex, String shippingMethod, String shippingInstructions, String maySplit,
            String giftMessage, String isGift, String internalCode, String shipBeforeDate, String shipAfterDate, String internalOrderNotes, String shippingNotes) {
        Severity: Major
        Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 1 hr to fix

          Method processPayment has 10 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public static Map<String, Object> processPayment(String orderId, BigDecimal orderTotal, String currencyUomId, GenericValue productStore, GenericValue userLogin, boolean faceToFace, boolean manualHold,
            LocalDispatcher dispatcher, Delegator delegator, Locale locale) throws GeneralException { // SCIPIO: 2019-03-07: Added locale
          Severity: Major
          Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 1 hr to fix

            Method finalizeOrderEntryOptions has 10 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public Map<String, Object> finalizeOrderEntryOptions(int shipGroupIndex, String shippingMethod, String shippingInstructions, String maySplit,
            String giftMessage, String isGift, String internalCode, String shipBeforeDate, String shipAfterDate, String orderAdditionalEmails) {
            Severity: Major
            Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 1 hr to fix

              Method processPayment has 9 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public static Map<String, Object> processPayment(String orderId, BigDecimal orderTotal, String currencyUomId, GenericValue productStore, GenericValue userLogin, boolean faceToFace, boolean manualHold,
            LocalDispatcher dispatcher, Delegator delegator) throws GeneralException {
              Severity: Major
              Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 1 hr to fix

                Method setCheckOutShippingOptionsInternal has 9 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    private List<String> setCheckOutShippingOptionsInternal(String shippingMethod, String shippingInstructions, String orderAdditionalEmails,
            String maySplit, String giftMessage, String isGift, String internalCode, String shipBeforeDate, String shipAfterDate) {
                Severity: Major
                Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 1 hr to fix

                  Method setCheckOutShippingOptions has 9 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public Map<String, Object> setCheckOutShippingOptions(String shippingMethod, String shippingInstructions,
            String orderAdditionalEmails, String maySplit, String giftMessage, String isGift, String internalCode, String shipBeforeDate, String shipAfterDate) {
                  Severity: Major
                  Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 1 hr to fix

                    Method processPayment has 7 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public Map<String, Object> processPayment(String orderId, BigDecimal orderTotal, String currencyUomId, GenericValue productStore, GenericValue userLogin, boolean faceToFace, boolean manualHold) throws GeneralException {
                    Severity: Major
                    Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 50 mins to fix

                      Method createOrder has 7 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public Map<String, Object> createOrder(GenericValue userLogin, String distributorId, String affiliateId,
            List<GenericValue> trackingCodeOrders, boolean areOrderItemsExploded, String visitId, String webSiteId) {
                      Severity: Major
                      Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 50 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                                    if (!cart.hasOrderTerm(billingAccountTerm.getString("termTypeId"))) {
                                cart.addOrderTerm(billingAccountTerm.getString("termTypeId"), billingAccountTerm.getBigDecimal("termValue"), billingAccountTerm.getLong("termDays"));
                            }
                        Severity: Major
                        Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                                              if (!ok) {
                                        throw new GeneralException("Problem with order change; see above error");
                                    }
                          Severity: Major
                          Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                                    if (UtilValidate.isEmail(email)) {
                            res.add(email);
                        } else {
                            errorMessages.add(UtilProperties.getMessage(resource_error, "checkhelper.value_not_valid_email", UtilMisc.toMap("email", email), (cart != null ? cart.getLocale() : Locale.getDefault())));
                        }
                            Severity: Major
                            Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                                      if (gcAmount.compareTo(BigDecimal.ZERO) > 0) {
                            giftCardAmount = gcAmount;
                        }
                              Severity: Major
                              Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 45 mins to fix

                                Method adjustFaceToFacePayment has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                    public static void adjustFaceToFacePayment(String orderId, BigDecimal cartTotal, List<GenericValue> allPaymentPrefs, GenericValue userLogin, Delegator delegator) throws GeneralException {
                                Severity: Minor
                                Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 35 mins to fix

                                  Method makeTaxContext has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                      private Map<String, Object> makeTaxContext(int shipGroup, GenericValue shipAddress, Map<Integer, ShoppingCartItem> shoppingCartItemIndexMap, String originFacilityId, boolean skipEmptyAddresses) {
                                  Severity: Minor
                                  Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 35 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                                        return ServiceUtil.returnError(errMsg);
                                    Severity: Major
                                    Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                                              return ServiceUtil.returnError(getStoreAuthMsg(productStore, "authErrorMessage", locale)); // SCIPIO: Refactored: ERROR_MESSAGE
                                      Severity: Major
                                      Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 30 mins to fix

                                        Avoid too many return statements within this method.
                                        Open

                                                            return ServiceUtil.returnError(messages);
                                        Severity: Major
                                        Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 30 mins to fix

                                          Avoid too many return statements within this method.
                                          Open

                                                  return result;
                                          Severity: Major
                                          Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 30 mins to fix

                                            Avoid too many return statements within this method.
                                            Open

                                                    return ServiceUtil.returnSuccess();
                                            Severity: Major
                                            Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 30 mins to fix

                                              Avoid too many return statements within this method.
                                              Open

                                                                      return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
                                              Severity: Major
                                              Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 30 mins to fix

                                                Avoid too many return statements within this method.
                                                Open

                                                                    return ServiceUtil.returnError(errMsg);
                                                Severity: Major
                                                Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 30 mins to fix

                                                  Avoid too many return statements within this method.
                                                  Open

                                                          return result;
                                                  Severity: Major
                                                  Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 30 mins to fix

                                                    Avoid too many return statements within this method.
                                                    Open

                                                                    return ServiceUtil.returnError(errMsg);
                                                    Severity: Major
                                                    Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 30 mins to fix

                                                      Avoid too many return statements within this method.
                                                      Open

                                                              return ServiceUtil.returnSuccess("success");
                                                      Severity: Major
                                                      Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 30 mins to fix

                                                        Avoid too many return statements within this method.
                                                        Open

                                                                            return ServiceUtil.returnError(messages);
                                                        Severity: Major
                                                        Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 30 mins to fix

                                                          Avoid too many return statements within this method.
                                                          Open

                                                                                  return ServiceUtil.returnError(getStoreAuthMsg(productStore, "authDeclinedMessage", locale)); // SCIPIO: Refactored: DECLINE_MESSAGE
                                                          Severity: Major
                                                          Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 30 mins to fix

                                                            Avoid too many return statements within this method.
                                                            Open

                                                                        return ServiceUtil.returnFailure(UtilProperties.getMessage(resource_error,"OrderFailed", cart.getLocale()));
                                                            Severity: Major
                                                            Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 30 mins to fix

                                                              Avoid too many return statements within this method.
                                                              Open

                                                                      return ServiceUtil.returnSuccess();
                                                              Severity: Major
                                                              Found in applications/order/src/org/ofbiz/order/shoppingcart/CheckOutHelper.java - About 30 mins to fix

                                                                There are no issues that match your filters.

                                                                Category
                                                                Status