applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java from ilscipio/scipio-erp

applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java

Summary

Maintainability

2 days

Test Coverage

`ShoppingCartEvents` has 64 methods (exceeds 20 allowed). Consider refactoring.
Open

public class ShoppingCartEvents {

    private static final Debug.OfbizLogger module = Debug.getOfbizLogger(java.lang.invoke.MethodHandles.lookup().lookupClass());
    public static final String resource = "OrderUiLabels";
    public static final String resource_error = "OrderErrorUiLabels";

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 1 day to fix

Avoid deeply nested control flow statements.
Open

                            if (productList.parallelStream().anyMatch(p -> sci.getProductId().equals(p.getString("productId")))) {
                                try {
                                    cart.removeCartItem(sci, dispatcher);
                                } catch (CartItemModifyException e) {
                                    Debug.logError(e.getMessage(), module);

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 45 mins to fix

Avoid deeply nested control flow statements.
Open

                            if (!itemAdjustments.isEmpty()) {
                                index = 0;
                                for (GenericValue adjustment : itemAdjustments ) {
                                    if(adjustment.get("productPromoId").equals(productPromoId)) {
                                        checkItem.getAdjustments().remove(index);

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 45 mins to fix

Avoid too many `return` statements within this method.
Open

                    return "product";

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

                    return "error";

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

        return "success";

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

            return "viewcart";

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

                    return "success";

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

        return "error";

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

                        return "error";

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

            return "error";

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

        return "success";

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

        return "success";

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

                    return "error";

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

                    return "error";

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

                return "product";

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

        return null;

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

                return "error";

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

                    return "error";

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

                    return "error";

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

                    return "product";

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

                    return "survey";

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

                        return "error";

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

            return "product";

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

                return Optional.ofNullable(userLogin);

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

                    return "error";

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

Avoid too many `return` statements within this method.
Open

        return "success";

Found in applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java - About 30 mins to fix

ilscipio/scipio-erp

Summary

Maintainability

Test Coverage

`ShoppingCartEvents` has 64 methods (exceeds 20 allowed). Consider refactoring.
Open

Avoid deeply nested control flow statements.
Open

Avoid deeply nested control flow statements.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

There are no issues that match your filters.

Category

Status

ilscipio/scipio-erp

Summary

Maintainability

Test Coverage

ShoppingCartEvents has 64 methods (exceeds 20 allowed). Consider refactoring. Open

Avoid deeply nested control flow statements. Open

Avoid deeply nested control flow statements. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

Avoid too many return statements within this method. Open

There are no issues that match your filters.

Category

Status

`ShoppingCartEvents` has 64 methods (exceeds 20 allowed). Consider refactoring.
Open

Avoid deeply nested control flow statements.
Open

Avoid deeply nested control flow statements.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open

Avoid too many `return` statements within this method.
Open