ilscipio/scipio-erp

View on GitHub
applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java

Summary

Maintainability
D
2 days
Test Coverage

ShoppingCartEvents has 64 methods (exceeds 20 allowed). Consider refactoring.
Open

public class ShoppingCartEvents {

    private static final Debug.OfbizLogger module = Debug.getOfbizLogger(java.lang.invoke.MethodHandles.lookup().lookupClass());
    public static final String resource = "OrderUiLabels";
    public static final String resource_error = "OrderErrorUiLabels";

    Avoid deeply nested control flow statements.
    Open

                                if (productList.parallelStream().anyMatch(p -> sci.getProductId().equals(p.getString("productId")))) {
                                    try {
                                        cart.removeCartItem(sci, dispatcher);
                                    } catch (CartItemModifyException e) {
                                        Debug.logError(e.getMessage(), module);

      Avoid deeply nested control flow statements.
      Open

                                  if (!itemAdjustments.isEmpty()) {
                                      index = 0;
                                      for (GenericValue adjustment : itemAdjustments ) {
                                          if(adjustment.get("productPromoId").equals(productPromoId)) {
                                              checkItem.getAdjustments().remove(index);

        Avoid too many return statements within this method.
        Open

                            return "product";

          Avoid too many return statements within this method.
          Open

                              return "error";

            Avoid too many return statements within this method.
            Open

                    return "success";

              Avoid too many return statements within this method.
              Open

                          return "viewcart";

                Avoid too many return statements within this method.
                Open

                                    return "success";

                  Avoid too many return statements within this method.
                  Open

                          return "error";

                    Avoid too many return statements within this method.
                    Open

                                            return "error";

                      Avoid too many return statements within this method.
                      Open

                                  return "error";

                        Avoid too many return statements within this method.
                        Open

                                return "success";

                          Avoid too many return statements within this method.
                          Open

                                  return "success";

                            Avoid too many return statements within this method.
                            Open

                                                return "error";

                              Avoid too many return statements within this method.
                              Open

                                                  return "error";

                                Avoid too many return statements within this method.
                                Open

                                                return "product";

                                  Avoid too many return statements within this method.
                                  Open

                                          return null;

                                    Avoid too many return statements within this method.
                                    Open

                                                    return "error";

                                      Avoid too many return statements within this method.
                                      Open

                                                          return "error";

                                        Avoid too many return statements within this method.
                                        Open

                                                            return "error";

                                          Avoid too many return statements within this method.
                                          Open

                                                              return "product";

                                            Avoid too many return statements within this method.
                                            Open

                                                                return "survey";

                                              Avoid too many return statements within this method.
                                              Open

                                                                      return "error";

                                                Avoid too many return statements within this method.
                                                Open

                                                            return "product";

                                                  Avoid too many return statements within this method.
                                                  Open

                                                                  return Optional.ofNullable(userLogin);

                                                    Avoid too many return statements within this method.
                                                    Open

                                                                        return "error";

                                                      Avoid too many return statements within this method.
                                                      Open

                                                              return "success";

                                                        There are no issues that match your filters.

                                                        Category
                                                        Status