applications/party/src/org/ofbiz/party/party/PartyServices.java
PartyServices has 25 methods (exceeds 20 allowed). Consider refactoring. Open
Open
public class PartyServices {
private static final Debug.OfbizLogger module = Debug.getOfbizLogger(java.lang.invoke.MethodHandles.lookup().lookupClass());
public static final String resource = "PartyUiLabels";
public static final String resourceError = "PartyErrorUiLabels";Consider simplifying this complex logical expression. Wontfix
Wontfix
if ("POSTAL_ADDRESS".equals(currentContactMechTypeId)) {
postalAddress.put("address1", rec.get("address1"));
postalAddress.put("address2", rec.get("address2"));
postalAddress.put("city", rec.get("city"));
postalAddress.put("stateProvinceGeoId", rec.get("stateProvinceGeoId"));Consider simplifying this complex logical expression. Wontfix
Wontfix
if (currentContactMechPurposeTypeId != null && ("TELECOM_NUMBER".equals(currentContactMechTypeId) || "POSTAL_ADDRESS".equals(currentContactMechTypeId) ||"EMAIL_ADDRESS".equals(currentContactMechTypeId))) {
partyContactMechPurpose.put("contactMechPurposeTypeId", currentContactMechPurposeTypeId);
partyContactMechPurposeChanged = (lastContactMechPurposeTypeId == null || !lastContactMechPurposeTypeId.equals(currentContactMechPurposeTypeId)) && !telecomNumberChanged && !postalAddressChanged && !emailAddressChanged;
Debug.logInfo("===================================last:" + lastContactMechPurposeTypeId + " current: " + currentContactMechPurposeTypeId + " t :" + telecomNumberChanged + " p: " + postalAddressChanged + " e: " + emailAddressChanged + " result: " + partyContactMechPurposeChanged, module);
}Consider simplifying this complex logical expression. Open
Open
if ( "P".equals(extInfo) ||
UtilValidate.isNotEmpty(context.get("address1"))|| UtilValidate.isNotEmpty(context.get("address2"))||
UtilValidate.isNotEmpty(context.get("city"))|| UtilValidate.isNotEmpty(context.get("postalCode"))||
UtilValidate.isNotEmpty(context.get("countryGeoId"))|| (UtilValidate.isNotEmpty(stateProvinceGeoId))) {
// add address to dynamic viewAvoid deeply nested control flow statements. Open
Open
if (ServiceUtil.isError(result)) {
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(result));
}Avoid deeply nested control flow statements. Open
Open
if (UtilValidate.isNotEmpty(rec.get("groupName"))) {
Map<String, Object> partyGroup = UtilMisc.toMap(
"partyId", newPartyId,
"preferredCurrencyUomId", rec.get("preferredCurrencyUomId"),
"groupName", rec.get("groupName"),Avoid deeply nested control flow statements. Open
Open
if (ServiceUtil.isError(resultMap)) {
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(result));
}Avoid deeply nested control flow statements. Open
Open
if (ServiceUtil.isError(serviceResult)) {
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
}Avoid deeply nested control flow statements. Open
Open
if (ServiceUtil.isError(result)) {
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(result));
}Avoid deeply nested control flow statements. Open
Open
if (ServiceUtil.isError(result)) {
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(result));
}Avoid deeply nested control flow statements. Open
Open
if (!Character.isDigit(c)) {
isNumber = false;
}Avoid deeply nested control flow statements. Open
Open
if (ServiceUtil.isError(result)) {
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(result));
}Avoid deeply nested control flow statements. Open
Open
if (ServiceUtil.isError(resultMap)) {
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(result));
}Avoid deeply nested control flow statements. Open
Open
if (stateCheck.size() == 0) {
newErrMsgs.add("Line number " + rec.getRecordNumber() + " partyId: " + currentPartyId + " Invalid stateProvinceGeoId code: " + rec.get("countryGeoId"));
}Avoid deeply nested control flow statements. Open
Open
if (currentContactMechPurposeTypeId == null) {
currentContactMechPurposeTypeId= "PHONE_WORK";
}Avoid deeply nested control flow statements. Open
Open
if (currentContactMechPurposeTypeId == null) {
currentContactMechPurposeTypeId = "PRIMARY_EMAIL";
}Avoid deeply nested control flow statements. Open
Open
if (currentContactMechPurposeTypeId == null) {
currentContactMechPurposeTypeId = "GENERAL_LOCATION";
}Consider simplifying this complex logical expression. Open
Open
if ("TELECOM_NUMBER".equals(currentContactMechTypeId)) {
telecomNumber.put("countryCode", rec.get("telCountryCode"));
telecomNumber.put("areaCode", rec.get("telAreaCode"));
telecomNumber.put("contactNumber", rec.get("telContactNumber"));
telecomNumberChanged =Avoid too many return statements within this method. Open
Open
return result;Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return result;Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resourceError,
"person.update.write_failure", new Object[] { e.getMessage() }, locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(result));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resourceError,
"partyservices.cannot_create_party_group_already_exists", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource,
"PartyLookupPartyError",
UtilMisc.toMap("errMessage", e.toString()), locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return result;Avoid too many return statements within this method. Open
Open
return result;Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resourceError,
"person.update.write_failure", new Object[] { e.getMessage() }, locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resourceError,
"partyservices.could_not_add_affiliate_info_write",
UtilMisc.toMap("errMessage", e.getMessage()), locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnSuccess();Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(result));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(result));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(result));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resourceError,
"partyservices.partyservices.cannot_create_party_group_already_exists_not_PARTY_GROUP_type", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return resp;Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(result));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(result));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(errMsgs);Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(result));Avoid too many return statements within this method. Open
Open
return result;Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource,
"PartyLookupStateProvinceGeoError",
UtilMisc.toMap("errMessage", e.toString()), locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resource,
"PartyPartyFromDoesNotExists", locale));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(result));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(result));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resourceError,
"person.create.db_error", new Object[] { e.getMessage() }, locale));Avoid too many return statements within this method. Open
Open
return result;Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));Avoid too many return statements within this method. Open
Open
return result;Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(result));Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(UtilProperties.getMessage(resourceError,
"partyservices.data_source_error_adding_party_group",
UtilMisc.toMap("errMessage", e.getMessage()), locale));Avoid too many return statements within this method. Open
Open
return result;Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(e.getMessage());Avoid too many return statements within this method. Open
Open
return ServiceUtil.returnError(ServiceUtil.getErrorMessage(result));