ilscipio/scipio-erp

View on GitHub
applications/product/src/com/ilscipio/scipio/product/product/ProductDataReader.java

Summary

Maintainability
F
4 days
Test Coverage

ProductDataReader has 50 methods (exceeds 20 allowed). Consider refactoring.
Open

public class ProductDataReader {
    static final Debug.OfbizLogger module = Debug.getOfbizLogger(java.lang.invoke.MethodHandles.lookup().lookupClass());

    public static final ProductDataReader DEFAULT = new ProductDataReader();

    Method getProductStandardPrices has 11 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public Map<String, Object> getProductStandardPrices(DispatchContext dctx, Map<String, Object> context, GenericValue userLogin, GenericValue product, String productStoreId, String webSiteId, String prodCatalogId, String currencyUomId, Locale locale, boolean useCache, Map<String, ?> ovrdFields) throws GeneralException {

      Method getConfigurableProductStartingPrices has 10 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public ProductConfigWrapper getConfigurableProductStartingPrices(DispatchContext dctx, Map<String, Object> context, GenericValue userLogin, String productId, String productStoreId, String webSiteId, String prodCatalogId, String currencyUomId, Locale locale, boolean useCache) throws GeneralException {

        Method getProductContentForLocales has 10 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public void getProductContentForLocales(Map<String, String> contentMap, DispatchContext dctx, GenericValue product, String productContentTypeId,
                                                    Collection<Locale> locales, Locale defaultLocale, Function<Locale, String> langCodeFn, String generalKey,
                                                    Timestamp moment, boolean useCache) throws GeneralException {

          Method getConfigurableProductStartingPrices has 10 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public ProductConfigWrapper getConfigurableProductStartingPrices(DispatchContext dctx, Map<String, Object> context, GenericValue userLogin, GenericValue product, GenericValue productStore, String webSiteId, String prodCatalogId, String currencyUomId, Locale locale, boolean useCache) throws GeneralException {

            Method getConfigurableProductStartingPrices has 10 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public ProductConfigWrapper getConfigurableProductStartingPrices(DispatchContext dctx, Map<String, Object> context, GenericValue userLogin, GenericValue product, String productStoreId, String webSiteId, String prodCatalogId, String currencyUomId, Locale locale, boolean useCache) throws GeneralException {

              Method getLocalizedProductContentStringMap has 10 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public Map<String, String> getLocalizedProductContentStringMap(DispatchContext dctx, GenericValue product, String productContentTypeId,
                                                                                 Collection<Locale> locales, Locale defaultLocale, Function<Locale, String> langCodeFn, String generalKey,
                                                                                 List<ProductContentWrapper> pcwList, Timestamp moment, boolean useCache) throws GeneralException {

                Method getProductStandardPrices has 10 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public Map<String, Object> getProductStandardPrices(DispatchContext dctx, Map<String, Object> context, GenericValue userLogin, GenericValue product, GenericValue productStore, String prodCatalogId, String currencyUomId, Locale locale, boolean useCache, Map<String, ?> ovrdFields) throws GeneralException {

                  Method getConfigurableProductStartingPrices has 9 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public ProductConfigWrapper getConfigurableProductStartingPrices(DispatchContext dctx, Map<String, Object> context, GenericValue userLogin, GenericValue product, GenericValue productStore, String prodCatalogId, String currencyUomId, Locale locale, boolean useCache) throws GeneralException {

                    Method getConfigurableProductStartingPrices has 9 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public ProductConfigWrapper getConfigurableProductStartingPrices(DispatchContext dctx, Map<String, Object> context, GenericValue userLogin, String productId, String productStoreId, String prodCatalogId, String currencyUomId, Locale locale, boolean useCache) throws GeneralException {

                      Method getProductStandardPrices has 9 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public Map<String, Object> getProductStandardPrices(DispatchContext dctx, Map<String, Object> context, GenericValue userLogin, GenericValue product, GenericValue productStore, String currencyUomId, Locale locale, boolean useCache, Map<String, ?> ovrdFields) throws GeneralException {

                        Method getProductStandardPrices has 9 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            public Map<String, Object> getProductStandardPrices(DispatchContext dctx, Map<String, Object> context, GenericValue userLogin, GenericValue product, GenericValue productStore, String prodCatalogId, String currencyUomId, Locale locale, boolean useCache) throws GeneralException {

                          Method getProductStandardPrices has 8 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              public Map<String, Object> getProductStandardPrices(DispatchContext dctx, Map<String, Object> context, GenericValue userLogin, GenericValue product, GenericValue productStore, String currencyUomId, Locale locale, boolean useCache) throws GeneralException {

                            Method getConfigurableProductStartingPrices has 8 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                public ProductConfigWrapper getConfigurableProductStartingPrices(DispatchContext dctx, Map<String, Object> context, GenericValue userLogin, String productId, String productStoreId, String currencyUomId, Locale locale, boolean useCache) throws GeneralException {

                              Method getConfigurableProductStartingPrices has 8 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  public ProductConfigWrapper getConfigurableProductStartingPrices(DispatchContext dctx, Map<String, Object> context, GenericValue userLogin, GenericValue product, GenericValue productStore, String currencyUomId, Locale locale, boolean useCache) throws GeneralException {

                                Method getAssocCategoryIdsForProduct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                    public Set<String> getAssocCategoryIdsForProduct(DispatchContext dctx, String productId, List<GenericValue> assocToVariant, Timestamp moment, boolean ordered, boolean useCache) throws GenericEntityException {

                                  Method getProductContentText has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                      public String getProductContentText(DispatchContext dctx, GenericValue targetContent,
                                                                          GenericValue product, GenericValue productContent, Locale locale, boolean useCache) throws GeneralException {

                                    Method getProductContentWrappersForLocales has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                        public Map<String, ProductContentWrapper> getProductContentWrappersForLocales(DispatchContext dctx, GenericValue product,
                                                                                                                      Collection<Locale> locales, Locale defaultLocale, Function<Locale, String> langCodeFn,
                                                                                                                      boolean useCache) throws GeneralException {

                                      Method getProductCategoryMembers has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                      Open

                                          public List<GenericValue> getProductCategoryMembers(DispatchContext dctx, String productId, Timestamp moment, boolean ordered, boolean useCache) throws GeneralException {

                                        Method getVirtualProductIdsDeepDfs has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                        Open

                                            protected List<String> getVirtualProductIdsDeepDfs(DispatchContext dctx, String productId, Timestamp moment, boolean useCache, List<String> virtualProductIds) throws GeneralException {

                                          Method refineLocalizedContentValues has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                          Open

                                              public void refineLocalizedContentValues(Map<String, String> contentMap, Collection<Locale> locales, Locale defaultLocale, Function<Locale, String> langCodeFn, String generalKey) {

                                            Method getVariantProductIdsDeepDfs has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                            Open

                                                protected List<String> getVariantProductIdsDeepDfs(DispatchContext dctx, String productId, Timestamp moment, boolean useCache, List<String> variantProductIds) throws GeneralException {

                                              Method getOwnCategoryIdsForProduct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                              Open

                                                  public Set<String> getOwnCategoryIdsForProduct(DispatchContext dctx, String productId, Timestamp moment, boolean ordered, boolean useCache) throws GenericEntityException {

                                                Method getCategoryRollups has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                Open

                                                    public List<GenericValue> getCategoryRollups(DispatchContext dctx, String productCategoryId, Timestamp moment, boolean ordered, boolean useCache) throws GeneralException {

                                                  Method getProductStoreCatalogsForCatalogIds has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                  Open

                                                      public List<GenericValue> getProductStoreCatalogsForCatalogIds(DispatchContext dctx, Collection<String> catalogIds, Timestamp moment, boolean ordered, boolean useCache) throws GeneralException {

                                                    Method getProductStoreAndCatalogAssocForCatalogIds has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                    Open

                                                        public List<GenericValue> getProductStoreAndCatalogAssocForCatalogIds(DispatchContext dctx, Collection<String> catalogIds, Timestamp moment, boolean ordered, boolean useCache) throws GeneralException {

                                                      Method getCategoryRollupTrails has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                      Open

                                                          public List<List<String>> getCategoryRollupTrails(DispatchContext dctx, String productCategoryId, Timestamp moment, boolean ordered, boolean useCache) throws GeneralException {

                                                        Method getProductStoresForCatalogIds has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                        Open

                                                            public List<GenericValue> getProductStoresForCatalogIds(DispatchContext dctx, Collection<String> catalogIds, Timestamp moment, boolean ordered, boolean useCache) throws GeneralException {

                                                          Method getProductStoreAndCatalogAssocForCatalogId has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                          Open

                                                              public List<GenericValue> getProductStoreAndCatalogAssocForCatalogId(DispatchContext dctx, String catalogId, Timestamp moment, boolean ordered, boolean useCache) throws GeneralException {

                                                            Method getProductStoreCatalogsForCatalogId has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                            Open

                                                                public List<GenericValue> getProductStoreCatalogsForCatalogId(DispatchContext dctx, String catalogId, Timestamp moment, boolean ordered, boolean useCache) throws GeneralException {

                                                              There are no issues that match your filters.

                                                              Category
                                                              Status