Sign upLogin

ilscipio/scipio-erp

View on GitHub
Star
applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java

Summary

Maintainability
F
1 wk
Test Coverage

SeoCatalogUrlWorker has 125 methods (exceeds 20 allowed). Consider refactoring.
Open

@SuppressWarnings("serial")
public class SeoCatalogUrlWorker implements Serializable {

    private static final Debug.OfbizLogger module = Debug.getOfbizLogger(java.lang.invoke.MethodHandles.lookup().lookupClass());
Severity: Major
Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 2 days to fix

    PathSegmentEntities has 33 methods (exceeds 20 allowed). Consider refactoring.
    Open

        public static class PathSegmentEntities implements List<PathSegmentEntity>, Serializable {
        private final CatalogUrlType entityType;
        private final String pathSegment;
        private final List<PathSegmentEntity> entities;
        private final Timestamp moment;
    Severity: Minor
    Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 4 hrs to fix

      PathSegmentEntity has 27 methods (exceeds 20 allowed). Consider refactoring.
      Open

          public static class PathSegmentEntity implements Serializable {
        protected final CatalogUrlType entityType;
        protected final String id;
        protected final String pathSegment;
        protected final PathSegmentMatchOptions matchOptions;
      Severity: Minor
      Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 3 hrs to fix

        PathMatch has 26 methods (exceeds 20 allowed). Consider refactoring.
        Open

            public static class PathMatch implements Serializable {

        protected PathEntity pathEntity;
        protected String path;
        protected List<String> pathSegments; // path segments (after mount-point, if any)
        Severity: Minor
        Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 3 hrs to fix

          Method makeCategoryUrlImpl has 14 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              protected String makeCategoryUrlImpl(Delegator delegator, LocalDispatcher dispatcher, Locale locale, List<String> trail, FullWebappInfo targetWebappInfo,
                                  String currentCatalogId, String previousCategoryId, String productCategoryId, String productId, String viewSize, String viewIndex, String viewSort, String searchString, boolean useCache) {
          Severity: Major
          Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

            Method makeCategoryUrl has 13 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public String makeCategoryUrl(Delegator delegator, LocalDispatcher dispatcher, Locale locale, List<String> currentTrail, FullWebappInfo targetWebappInfo,
                                  String currentCatalogId, String previousCategoryId, String productCategoryId, String productId, String viewSize, String viewIndex, String viewSort, String searchString) {
            Severity: Major
            Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

              Method getCategoryCacheKey has 13 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  protected static String getCategoryCacheKey(Delegator delegator, FullWebappInfo targetWebappInfo, String type, Locale locale, String previousCategoryId, String productCategoryId, String productId,
                                                String viewSize, String viewIndex, String viewSort, String searchString, String currentCatalogId, List<String> trail) {
              Severity: Major
              Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

                Method makeCategoryAltUrl has 13 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        public String makeCategoryAltUrl(Delegator delegator, LocalDispatcher dispatcher, Locale locale, List<String> trail,
                FullWebappInfo targetWebappInfo, String currentCatalogId, String previousCategoryId, String productCategoryId, String productId,
                String viewSize, String viewIndex, String viewSort, String searchString) {
                Severity: Major
                Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

                  Method addPathSegmentEntity has 11 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      protected PathSegmentEntity addPathSegmentEntity(Map<String, PathSegmentEntity> results, Delegator delegator, CatalogUrlType entityType, String id, String pathSegment, PathSegmentMatchOptions matchOptions, Timestamp moment, PathSegmentMatchType matchType, String name, String localeString, GenericValue record) {
                  Severity: Major
                  Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

                    Method makePathMatch has 11 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public PathMatch makePathMatch(Delegator delegator, PathEntity pathEntity, String path, List<String> pathSegments,
                                   String contextPath, String webSiteId, String currentCatalogId,
                                   boolean explicitProductRequest, boolean explicitCategoryRequest, Locale explicitLocale, Timestamp moment) {
                    Severity: Major
                    Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

                      Method makePathMatchIfValidRequest has 11 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public PathMatch makePathMatchIfValidRequest(Delegator delegator, PathEntity pathEntity, String path, List<String> pathSegments,
                                                 String contextPath, String webSiteId, String currentCatalogId,
                                                 boolean explicitProductRequest, boolean explicitCategoryRequest, Locale explicitLocale, Timestamp moment) {
                      Severity: Major
                      Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

                        Method makeProductUrlImpl has 10 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            protected String makeProductUrlImpl(Delegator delegator, LocalDispatcher dispatcher, Locale locale, List<String> trail, FullWebappInfo targetWebappInfo,
                                 String currentCatalogId, String previousCategoryId, String productCategoryId, String productId, boolean useCache) {
                        Severity: Major
                        Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

                          Method makePathSegmentEntity has 10 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              public PathSegmentEntity makePathSegmentEntity(Delegator delegator, CatalogUrlType entityType, String id, String pathSegment, PathSegmentMatchOptions matchOptions, Timestamp moment, PathSegmentMatchType matchType, String name, String localeString, GenericValue record) {
                          Severity: Major
                          Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

                            Method getCategoryTrailPathSegments has 10 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                protected List<String> getCategoryTrailPathSegments(Delegator delegator, LocalDispatcher dispatcher, Locale locale, List<GenericValue> trailEntities, GenericValue targetCategory,
                                                        SeoConfig.TrailFormat trailFormat, SeoConfig.TrailFormat targetCategoryFormat, CatalogUrlType urlType, CatalogAltUrlSanitizer.SanitizeContext targetSanitizeCtx, boolean useCache) {
                            Severity: Major
                            Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

                              Method makeProductAltUrl has 9 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                      public String makeProductAltUrl(Delegator delegator, LocalDispatcher dispatcher, Locale locale, List<String> trail,
                FullWebappInfo targetWebappInfo, String currentCatalogId, String previousCategoryId, String productCategoryId, String productId) {
                              Severity: Major
                              Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

                                Method makeProductUrl has 9 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                    public String makeProductUrl(Delegator delegator, LocalDispatcher dispatcher, Locale locale, List<String> currentTrail, FullWebappInfo targetWebappInfo,
                                 String currentCatalogId, String previousCategoryId, String productCategoryId, String productId) {
                                Severity: Major
                                Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

                                  Method makeCategoryAltUrl has 9 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                          public String makeCategoryAltUrl(HttpServletRequest request, Locale locale, String previousCategoryId,
                String productCategoryId, String productId, String viewSize, String viewIndex, String viewSort,
                String searchString) {
                                  Severity: Major
                                  Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

                                    Method makeCategoryUrl has 9 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                        public String makeCategoryUrl(HttpServletRequest request, Locale locale, String previousCategoryId, String productCategoryId, String productId, String viewSize, String viewIndex, String viewSort, String searchString) {
                                    Severity: Major
                                    Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

                                      Method makeProductUrlCore has 9 arguments (exceeds 4 allowed). Consider refactoring.
                                      Open

                                          public StringBuilder makeProductUrlCore(Delegator delegator, LocalDispatcher dispatcher, Locale locale, GenericValue product,
                                            String currentCatalogId, String previousCategoryId, List<GenericValue> trailEntities, FullWebappInfo targetWebappInfo, boolean useCache) {
                                      Severity: Major
                                      Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

                                        Method makeCatalogUrl has 9 arguments (exceeds 4 allowed). Consider refactoring.
                                        Open

                                                public String makeCatalogUrl(Delegator delegator, LocalDispatcher dispatcher, Locale locale, FullWebappInfo targetWebappInfo, String currentCatalogId, List<String> crumb, String productId,
                String currentCategoryId, String previousCategoryId) {
                                        Severity: Major
                                        Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

                                          Method getProductUrlCacheKey has 9 arguments (exceeds 4 allowed). Consider refactoring.
                                          Open

                                              protected static String getProductUrlCacheKey(Delegator delegator, FullWebappInfo targetWebappInfo, String type, Locale locale, String previousCategoryId, String productCategoryId, String productId, String currentCatalogId, List<String> trail) {
                                          Severity: Major
                                          Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

                                            Method makeCategoryUrlCore has 9 arguments (exceeds 4 allowed). Consider refactoring.
                                            Open

                                                public StringBuilder makeCategoryUrlCore(Delegator delegator, LocalDispatcher dispatcher, Locale locale, GenericValue productCategory,
                                             String currentCatalogId, String previousCategoryId, List<GenericValue> trailEntities, FullWebappInfo targetWebappInfo, boolean useCache) {
                                            Severity: Major
                                            Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

                                              Method matchBestProductAndTrail has 8 arguments (exceeds 4 allowed). Consider refactoring.
                                              Open

                                                  protected PathEntity matchBestProductAndTrail(Delegator delegator, PathSegmentEntities products, PathSegmentEntities lastSegmentProducts, List<String> pathSegments, String currentCatalogId, String webSiteId, Locale expectedLocale, Timestamp moment) throws GenericEntityException {
                                              Severity: Major
                                              Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

                                                Method matchBestCategoryAndTrail has 8 arguments (exceeds 4 allowed). Consider refactoring.
                                                Open

                                                    protected PathEntity matchBestCategoryAndTrail(Delegator delegator, PathSegmentEntities categories, PathSegmentEntities lastSegmentCategories, List<String> pathSegments, String currentCatalogId, String webSiteId, Locale expectedLocale, Timestamp moment) throws GenericEntityException {
                                                Severity: Major
                                                Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

                                                  Method makeCategoryUrlPath has 8 arguments (exceeds 4 allowed). Consider refactoring.
                                                  Open

                                                      public StringBuilder makeCategoryUrlPath(Delegator delegator, LocalDispatcher dispatcher, Locale locale,
                                             GenericValue productCategory, List<String> trailNames, String contextPath, CatalogAltUrlSanitizer.SanitizeContext sanitizeCtx, boolean useCache) {
                                                  Severity: Major
                                                  Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

                                                    Method matchBestEntityAndTrail has 8 arguments (exceeds 4 allowed). Consider refactoring.
                                                    Open

                                                        protected PathEntity matchBestEntityAndTrail(Delegator delegator, PathSegmentEntities targetEntities, PathSegmentEntities lastSegmentEntities,
                                                 List<String> pathSegments, String currentCatalogId, String webSiteId, Locale expectedLocale, Timestamp moment) throws GenericEntityException {
                                                    Severity: Major
                                                    Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

                                                      Method makeProductUrlPath has 8 arguments (exceeds 4 allowed). Consider refactoring.
                                                      Open

                                                          public StringBuilder makeProductUrlPath(Delegator delegator, LocalDispatcher dispatcher, Locale locale, GenericValue product, List<String> trailNames, String contextPath, CatalogAltUrlSanitizer.SanitizeContext sanitizeCtx, boolean useCache) {
                                                      Severity: Major
                                                      Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

                                                        Method matchPathSegmentAltUrl has 8 arguments (exceeds 4 allowed). Consider refactoring.
                                                        Open

                                                            private void matchPathSegmentAltUrl(Delegator delegator, String pathSegment, List<GenericValue> values, String idField,
                                        CatalogUrlType entityType, PathSegmentMatchOptions matchOptions, Timestamp moment, Map<String, PathSegmentEntity> results) {
                                                        Severity: Major
                                                        Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

                                                          Consider simplifying this complex logical expression.
                                                          Open

                                                                                  if (bestEntity == null || bestTrail == null || bestTrailMatchType.comparePriorityTo(trailMatchType) < 0 ||
                                (bestTrailMatchType.comparePriorityTo(trailMatchType) == 0 &&
                                    (trail.size() < bestTrail.size() ||
                                        (trail.size() == bestTrail.size() && isFirstTrailBetterMatchThanSecondTopCatPrecision(entity, trail, bestEntity, bestTrail, topCategoryIds))))) {
                            trailEntities = resolvePathSegmentEntityTrail(trail, requestedTrailEntities);
                                                          Severity: Major
                                                          Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 1 hr to fix

                                                            Method makeCategoryUrlPath has 7 arguments (exceeds 4 allowed). Consider refactoring.
                                                            Open

                                                                public StringBuilder makeCategoryUrlPath(Delegator delegator, LocalDispatcher dispatcher, Locale locale,
                                             GenericValue productCategory, List<String> trailNames, String contextPath, boolean useCache) {
                                                            Severity: Major
                                                            Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 50 mins to fix

                                                              Method getCategoryPathName has 7 arguments (exceeds 4 allowed). Consider refactoring.
                                                              Open

                                                                  protected String getCategoryPathName(Delegator delegator, LocalDispatcher dispatcher, Locale locale, GenericValue productCategory, SeoConfig.TrailFormat format, CatalogAltUrlSanitizer.SanitizeContext sanitizeCtx, boolean useCache) {
                                                              Severity: Major
                                                              Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 50 mins to fix

                                                                Method getCategoryPathSegment has 7 arguments (exceeds 4 allowed). Consider refactoring.
                                                                Open

                                                                    public String getCategoryPathSegment(Delegator delegator, LocalDispatcher dispatcher, Locale locale, GenericValue productCategory, SeoConfig.TrailFormat format, CatalogAltUrlSanitizer.SanitizeContext sanitizeCtx, boolean useCache) {
                                                                Severity: Major
                                                                Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 50 mins to fix

                                                                  Method makeProductUrlPath has 7 arguments (exceeds 4 allowed). Consider refactoring.
                                                                  Open

                                                                      public StringBuilder makeProductUrlPath(Delegator delegator, LocalDispatcher dispatcher, Locale locale, GenericValue product, List<String> trailNames, String contextPath, boolean useCache) {
                                                                  Severity: Major
                                                                  Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 50 mins to fix

                                                                    Method getProductPathSegment has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                                                    Open

                                                                        protected String getProductPathSegment(Delegator delegator, LocalDispatcher dispatcher, Locale locale, GenericValue product, CatalogAltUrlSanitizer.SanitizeContext sanitizeCtx, boolean useCache) {
                                                                    Severity: Minor
                                                                    Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 45 mins to fix

                                                                      Avoid deeply nested control flow statements.
                                                                      Open

                                                                                              if (firstTopCatId.equals(topCatId)) {
                            return true;
                        } else if (secondTopCatId.equals(topCatId)) {
                            return false;
                        }
                                                                      Severity: Major
                                                                      Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 45 mins to fix

                                                                        Method getProductPathName has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                                                        Open

                                                                            protected String getProductPathName(Delegator delegator, LocalDispatcher dispatcher, Locale locale, GenericValue product, CatalogAltUrlSanitizer.SanitizeContext sanitizeCtx, boolean useCache) {
                                                                        Severity: Minor
                                                                        Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 45 mins to fix

                                                                          Avoid deeply nested control flow statements.
                                                                          Open

                                                                                                      if (newResults == null) {
                                newResults = makePathSegmentEntity(this, matchOptions, false);
                            }
                                                                          Severity: Major
                                                                          Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 45 mins to fix

                                                                            Method getCategoryAltUrl has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                                                            Open

                                                                                protected String getCategoryAltUrl(Delegator delegator, LocalDispatcher dispatcher, Locale locale, GenericValue productCategory, CatalogAltUrlSanitizer.SanitizeContext sanitizeCtx, boolean useCache) {
                                                                            Severity: Minor
                                                                            Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 45 mins to fix

                                                                              Avoid deeply nested control flow statements.
                                                                              Open

                                                                                                      if (isCategoryEntity) {
                            trail.remove(trail.size() - 1);
                        }
                                                                              Severity: Major
                                                                              Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 45 mins to fix

                                                                                Method matchReplaceOutboundSeoTranslatableUrl has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                                                                Open

                                                                                    public String matchReplaceOutboundSeoTranslatableUrl(HttpServletRequest request, Delegator delegator, String url, String productReqPath, String categoryReqPath, String contextRoot) {
                                                                                Severity: Minor
                                                                                Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 45 mins to fix

                                                                                  Avoid deeply nested control flow statements.
                                                                                  Open

                                                                                                          if (bestEntity == null || bestTrail == null || bestTrailMatchType.comparePriorityTo(trailMatchType) < 0 ||
                                (bestTrailMatchType.comparePriorityTo(trailMatchType) == 0 &&
                                    (trail.size() < bestTrail.size() ||
                                        (trail.size() == bestTrail.size() && isFirstTrailBetterMatchThanSecondTopCatPrecision(entity, trail, bestEntity, bestTrail, topCategoryIds))))) {
                            trailEntities = resolvePathSegmentEntityTrail(trail, requestedTrailEntities);
                                                                                  Severity: Major
                                                                                  Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 45 mins to fix

                                                                                    Method getProductAltUrl has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                                                                    Open

                                                                                        protected String getProductAltUrl(Delegator delegator, LocalDispatcher dispatcher, Locale locale, GenericValue product, CatalogAltUrlSanitizer.SanitizeContext sanitizeCtx, boolean useCache) {
                                                                                    Severity: Minor
                                                                                    Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 45 mins to fix

                                                                                      Avoid deeply nested control flow statements.
                                                                                      Open

                                                                                                              if (pathInfo.length() > productReqPath.length()) {
                            Map<String, String> params = extractParamsFromRest(pathInfo, productReqPath.length());
                            if (params == null) return null;
                            String productId = params.remove("product_id");
                            if (productId == null) {
                                                                                      Severity: Major
                                                                                      Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 45 mins to fix

                                                                                        Method makeProductAltUrl has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                                                        Open

                                                                                                public String makeProductAltUrl(HttpServletRequest request, Locale locale, String previousCategoryId, String productCategoryId,
                String productId) {
                                                                                        Severity: Minor
                                                                                        Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 35 mins to fix

                                                                                          Method mapCategoryUrlTrail has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                                                          Open

                                                                                              protected List<String> mapCategoryUrlTrail(Delegator delegator, List<String> hintTrail, String productCategoryId, String webSiteId, String currentCatalogId) {
                                                                                          Severity: Minor
                                                                                          Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 35 mins to fix

                                                                                            Method matchPathSegmentCategoryById has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                                                            Open

                                                                                                protected void matchPathSegmentCategoryById(Delegator delegator, String pathSegment, PathSegmentMatchOptions matchOptions, Timestamp moment, Map<String, PathSegmentEntity> results) throws GenericEntityException {
                                                                                            Severity: Minor
                                                                                            Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 35 mins to fix

                                                                                              Method isFirstTrailBetterMatchThanSecondTopCatPrecision has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                                                              Open

                                                                                                  private boolean isFirstTrailBetterMatchThanSecondTopCatPrecision(PathSegmentEntity firstMatch, List<String> firstTrail, PathSegmentEntity secondMatch, List<String> secondTrail, Set<String> topCategoryIds) {
                                                                                              Severity: Minor
                                                                                              Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 35 mins to fix

                                                                                                Method getCategoriesFromIdList has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                                                                Open

                                                                                                    protected List<GenericValue> getCategoriesFromIdList(Delegator delegator, LocalDispatcher dispatcher, Locale locale, List<String> categoryIdList, boolean useCache) {
                                                                                                Severity: Minor
                                                                                                Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 35 mins to fix

                                                                                                  Method matchPathSegmentCategoryByAltUrl has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                                                                  Open

                                                                                                      protected void matchPathSegmentCategoryByAltUrl(Delegator delegator, String pathSegment, PathSegmentMatchOptions matchOptions, Timestamp moment, Map<String, PathSegmentEntity> results) throws GenericEntityException {
                                                                                                  Severity: Minor
                                                                                                  Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 35 mins to fix

                                                                                                    Method makeProductUrl has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                                                                    Open

                                                                                                        public String makeProductUrl(HttpServletRequest request, Locale locale, String previousCategoryId, String productCategoryId, String productId) {
                                                                                                    Severity: Minor
                                                                                                    Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 35 mins to fix

                                                                                                      Method matchInboundSeoCatalogUrl has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                                                                      Open

                                                                                                          public PathMatch matchInboundSeoCatalogUrl(Delegator delegator, String path, String contextPath, String webSiteId, String currentCatalogId) {
                                                                                                      Severity: Minor
                                                                                                      Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 35 mins to fix

                                                                                                        Method matchPathSegmentProductImpl has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                                                                        Open

                                                                                                            protected void matchPathSegmentProductImpl(Delegator delegator, String pathSegment, PathSegmentMatchOptions matchOptions, Timestamp moment, Map<String, PathSegmentEntity> results) throws GenericEntityException {
                                                                                                        Severity: Minor
                                                                                                        Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 35 mins to fix

                                                                                                          Method makeCatalogUrl has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                                                                          Open

                                                                                                                  public String makeCatalogUrl(HttpServletRequest request, Locale locale, String productId, String currentCategoryId,
                String previousCategoryId) {
                                                                                                          Severity: Minor
                                                                                                          Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 35 mins to fix

                                                                                                            Method mapProductUrlTrail has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                                                                            Open

                                                                                                                protected List<String> mapProductUrlTrail(Delegator delegator, List<String> hintTrail, String productId, String webSiteId, String currentCatalogId) {
                                                                                                            Severity: Minor
                                                                                                            Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 35 mins to fix

                                                                                                              Method matchPathSegmentCategoryImpl has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                                                                              Open

                                                                                                                  protected void matchPathSegmentCategoryImpl(Delegator delegator, String pathSegment, PathSegmentMatchOptions matchOptions, Timestamp moment, Map<String, PathSegmentEntity> results) throws GenericEntityException {
                                                                                                              Severity: Minor
                                                                                                              Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 35 mins to fix

                                                                                                                Method matchPathSegmentProductByAltUrl has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                                                                                Open

                                                                                                                    protected void matchPathSegmentProductByAltUrl(Delegator delegator, String pathSegment, PathSegmentMatchOptions matchOptions, Timestamp moment, Map<String, PathSegmentEntity> results) throws GenericEntityException {
                                                                                                                Severity: Minor
                                                                                                                Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 35 mins to fix

                                                                                                                  Method matchPathSegmentProductById has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                                                                                  Open

                                                                                                                      protected void matchPathSegmentProductById(Delegator delegator, String pathSegment, PathSegmentMatchOptions matchOptions, Timestamp moment, Map<String, PathSegmentEntity> results) throws GenericEntityException {
                                                                                                                  Severity: Minor
                                                                                                                  Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 35 mins to fix

                                                                                                                    Avoid too many return statements within this method.
                                                                                                                    Open

                                                                                                                                                    if (newUrl == null) return null;
                                                                                                                    Severity: Major
                                                                                                                    Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 30 mins to fix

                                                                                                                      Avoid too many return statements within this method.
                                                                                                                      Open

                                                                                                                              return null;
                                                                                                                      Severity: Major
                                                                                                                      Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 30 mins to fix

                                                                                                                        Avoid too many return statements within this method.
                                                                                                                        Open

                                                                                                                                return makePathMatchIfValidRequest(delegator, pathEntity, path, allPathSegments, contextPath, webSiteId, currentCatalogId, explicitProductRequest, explicitCategoryRequest, explicitLocale, moment);
                                                                                                                        Severity: Major
                                                                                                                        Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 30 mins to fix

                                                                                                                          Avoid too many return statements within this method.
                                                                                                                          Open

                                                                                                                                                          return absPrefix + newUrl + colonString + remainingParams;
                                                                                                                          Severity: Major
                                                                                                                          Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 30 mins to fix

                                                                                                                            Avoid too many return statements within this method.
                                                                                                                            Open

                                                                                                                                    return firstMatch.isMorePreciseThan(secondMatch);
                                                                                                                            Severity: Major
                                                                                                                            Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 30 mins to fix

                                                                                                                              Avoid too many return statements within this method.
                                                                                                                              Open

                                                                                                                                      return null;
                                                                                                                              Severity: Major
                                                                                                                              Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 30 mins to fix

                                                                                                                                Avoid too many return statements within this method.
                                                                                                                                Open

                                                                                                                                                            if (params == null) return null;
                                                                                                                                Severity: Major
                                                                                                                                Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 30 mins to fix

                                                                                                                                  Avoid too many return statements within this method.
                                                                                                                                  Open

                                                                                                                                              return null;
                                                                                                                                  Severity: Major
                                                                                                                                  Found in applications/product/src/com/ilscipio/scipio/product/seo/SeoCatalogUrlWorker.java - About 30 mins to fix

                                                                                                                                    There are no issues that match your filters.

                                                                                                                                    Category
                                                                                                                                    Status