ilscipio/scipio-erp

View on GitHub
applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java

Summary

Maintainability
F
4 days
Test Coverage

CatalogUrlFilter has 30 methods (exceeds 20 allowed). Consider refactoring.
Open

public class CatalogUrlFilter extends ContextFilter {

    private static final Debug.OfbizLogger module = Debug.getOfbizLogger(java.lang.invoke.MethodHandles.lookup().lookupClass());

    /**

    Method makeCatalogAltLink has 19 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            public String makeCatalogAltLink(Map<String, Object> context, Delegator delegator, LocalDispatcher dispatcher, Locale locale, List<String> trail,
                    String productCategoryId, String productId, String previousCategoryId, Object params,
                    FullWebappInfo targetWebappInfo, String currentCatalogId, Boolean fullPath, Boolean secure, Boolean encode,
                    String viewSize, String viewIndex, String viewSort, String searchString,
                    FullWebappInfo currentWebappInfo) {

      Method makeCatalogAltLink has 16 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public static String makeCatalogAltLink(Map<String, Object> context, Delegator delegator, LocalDispatcher dispatcher, Locale locale, String productCategoryId, String productId,
                  String previousCategoryId, Object params, FullWebappInfo targetWebappInfo, Boolean fullPath, Boolean secure, Boolean encode,
                  String viewSize, String viewIndex, String viewSort, String searchString) {

        Method makeCatalogAltLink has 15 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                public String makeCatalogAltLink(HttpServletRequest request, HttpServletResponse response, Locale locale, String productCategoryId, String productId,
                        String previousCategoryId, Object params, FullWebappInfo targetWebappInfo,
                        Boolean fullPath, Boolean secure, Boolean encode,
                        String viewSize, String viewIndex, String viewSort, String searchString) {

          Method makeCatalogAltLink has 15 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public static String makeCatalogAltLink(HttpServletRequest request, HttpServletResponse response, Locale locale, String productCategoryId, String productId,
                      String previousCategoryId, Object params, FullWebappInfo targetWebappInfo, Boolean fullPath, Boolean secure, Boolean encode,
                      String viewSize, String viewIndex, String viewSort, String searchString) {

            Method makeCatalogAltLink has 15 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public static String makeCatalogAltLink(Map<String, Object> context, Delegator delegator, LocalDispatcher dispatcher, Locale locale, String productCategoryId, String productId,
                        String previousCategoryId, Object params, FullWebappInfo targetWebappInfo, Boolean fullPath, Boolean secure,
                        String viewSize, String viewIndex, String viewSort, String searchString) {

              Method makeCatalogAltLink has 14 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public static String makeCatalogAltLink(HttpServletRequest request, HttpServletResponse response, Locale locale, String productCategoryId, String productId, String previousCategoryId,
                          Object params, Boolean fullPath, Boolean secure, Boolean encode,
                          String viewSize, String viewIndex, String viewSort, String searchString) {

                Method makeCategoryAltUrl has 13 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                            public String makeCategoryAltUrl(Delegator delegator, LocalDispatcher dispatcher, Locale locale, List<String> trail,
                                    FullWebappInfo targetWebappInfo, String currentCatalogId, String previousCategoryId, String productCategoryId, String productId,
                                    String viewSize, String viewIndex, String viewSort, String searchString) {

                  Method makeCategoryAltUrl has 13 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          public abstract String makeCategoryAltUrl(Delegator delegator, LocalDispatcher dispatcher, Locale locale, List<String> trail, FullWebappInfo targetWebappInfo, String currentCatalogId, String previousCategoryId, String productCategoryId, String productId, String viewSize, String viewIndex, String viewSort, String searchString);

                    Method makeCategoryUrl has 11 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public static String makeCategoryUrl(Delegator delegator, CategoryContentWrapper wrapper, List<String> trail, String contextPath, String previousCategoryId, String productCategoryId, String productId, String viewSize, String viewIndex, String viewSort, String searchString) {

                      Method makeCategoryAltUrl has 9 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                                  public String makeCategoryAltUrl(HttpServletRequest request, Locale locale, String previousCategoryId,
                                          String productCategoryId, String productId, String viewSize, String viewIndex, String viewSort,
                                          String searchString) {

                        Method makeCategoryAltUrl has 9 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                public abstract String makeCategoryAltUrl(HttpServletRequest request, Locale locale, String previousCategoryId, String productCategoryId, String productId, String viewSize, String viewIndex, String viewSort, String searchString);

                          Method makeProductAltUrl has 9 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                      public String makeProductAltUrl(Delegator delegator, LocalDispatcher dispatcher, Locale locale, List<String> trail,
                                              FullWebappInfo targetWebappInfo, String currentCatalogId, String previousCategoryId, String productCategoryId, String productId) {

                            Method makeProductAltUrl has 9 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                    public abstract String makeProductAltUrl(Delegator delegator, LocalDispatcher dispatcher, Locale locale, List<String> trail, FullWebappInfo targetWebappInfo, String currentCatalogId, String previousCategoryId, String productCategoryId, String productId);

                              Method makeCategoryUrl has 8 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  public static String makeCategoryUrl(HttpServletRequest request, String previousCategoryId, String productCategoryId, String productId, String viewSize, String viewIndex, String viewSort, String searchString) {

                                Method makeProductUrl has 7 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                    public static String makeProductUrl(Delegator delegator, ProductContentWrapper wrapper, List<String> trail, String contextPath, String previousCategoryId, String productCategoryId, String productId) {

                                  Method getTrailElementsAndUpdateRequestAndTrail has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                      public static void getTrailElementsAndUpdateRequestAndTrail(HttpServletRequest request, Delegator delegator, String productId,
                                              String productCategoryId, List<String> trailCategoryIds, String topCategoryId) {

                                    Avoid deeply nested control flow statements.
                                    Open

                                                            if (UtilValidate.isNotEmpty(ElectronicText)) {
                                                                String textData = (String) ElectronicText.get("textData");
                                                                if (UtilValidate.isNotEmpty(textData)) {
                                                                    textData = UrlServletHelper.invalidCharacter(textData);
                                                                    if (alternativeUrl.matches(textData + ".+$")) {

                                      Avoid deeply nested control flow statements.
                                      Open

                                                              if (UtilValidate.isNotEmpty(ElectronicText)) {
                                                                  String textData = (String) ElectronicText.get("textData");
                                                                  if (UtilValidate.isNotEmpty(textData)) {
                                                                      textData = UrlServletHelper.invalidCharacter(textData);
                                                                      if (alternativeUrl.matches(textData + ".+$")) {

                                        Avoid deeply nested control flow statements.
                                        Open

                                                                if (UtilValidate.isNotEmpty(ElectronicText)) {
                                                                    String textData = (String) ElectronicText.get("textData");
                                                                    if (UtilValidate.isNotEmpty(textData)) {
                                                                        textData = UrlServletHelper.invalidCharacter(textData);
                                                                        if (alternativeUrl.matches(textData + ".+$")) {

                                          Avoid deeply nested control flow statements.
                                          Open

                                                                  if (UtilValidate.isNotEmpty(ElectronicText)) {
                                                                      String textData = (String) ElectronicText.get("textData");
                                                                      textData = UrlServletHelper.invalidCharacter(textData);
                                                                      if (alternativeUrl.matches(textData + ".+$")) {
                                                                          String productIdStr = null;

                                            Method makeProductAltUrl has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                            Open

                                                        public String makeProductAltUrl(HttpServletRequest request, Locale locale, String previousCategoryId, String productCategoryId,
                                                                String productId) {

                                              Method makeProductAltUrl has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                              Open

                                                      public abstract String makeProductAltUrl(HttpServletRequest request, Locale locale, String previousCategoryId, String productCategoryId, String productId);

                                                Method updateRequestAndTrail has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                Open

                                                    public static void updateRequestAndTrail(HttpServletRequest request, String categoryId, String productId, List<String> pathElements, List<String> trail) {

                                                  There are no issues that match your filters.

                                                  Category
                                                  Status