Sign upLogin

ilscipio/scipio-erp

View on GitHub
Star
applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java

Summary

Maintainability
F
4 days
Test Coverage

CatalogUrlFilter has 30 methods (exceeds 20 allowed). Consider refactoring.
Open

public class CatalogUrlFilter extends ContextFilter {

    private static final Debug.OfbizLogger module = Debug.getOfbizLogger(java.lang.invoke.MethodHandles.lookup().lookupClass());

    /**
Severity: Minor
Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 3 hrs to fix

    Method makeCatalogAltLink has 19 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            public String makeCatalogAltLink(Map<String, Object> context, Delegator delegator, LocalDispatcher dispatcher, Locale locale, List<String> trail,
                String productCategoryId, String productId, String previousCategoryId, Object params,
                FullWebappInfo targetWebappInfo, String currentCatalogId, Boolean fullPath, Boolean secure, Boolean encode,
                String viewSize, String viewIndex, String viewSort, String searchString,
                FullWebappInfo currentWebappInfo) {
    Severity: Major
    Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 2 hrs to fix

      Method makeCatalogAltLink has 16 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public static String makeCatalogAltLink(Map<String, Object> context, Delegator delegator, LocalDispatcher dispatcher, Locale locale, String productCategoryId, String productId,
            String previousCategoryId, Object params, FullWebappInfo targetWebappInfo, Boolean fullPath, Boolean secure, Boolean encode,
            String viewSize, String viewIndex, String viewSort, String searchString) {
      Severity: Major
      Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 2 hrs to fix

        Method makeCatalogAltLink has 15 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                public String makeCatalogAltLink(HttpServletRequest request, HttpServletResponse response, Locale locale, String productCategoryId, String productId,
                String previousCategoryId, Object params, FullWebappInfo targetWebappInfo,
                Boolean fullPath, Boolean secure, Boolean encode,
                String viewSize, String viewIndex, String viewSort, String searchString) {
        Severity: Major
        Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 1 hr to fix

          Method makeCatalogAltLink has 15 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public static String makeCatalogAltLink(HttpServletRequest request, HttpServletResponse response, Locale locale, String productCategoryId, String productId,
            String previousCategoryId, Object params, FullWebappInfo targetWebappInfo, Boolean fullPath, Boolean secure, Boolean encode,
            String viewSize, String viewIndex, String viewSort, String searchString) {
          Severity: Major
          Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 1 hr to fix

            Method makeCatalogAltLink has 15 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public static String makeCatalogAltLink(Map<String, Object> context, Delegator delegator, LocalDispatcher dispatcher, Locale locale, String productCategoryId, String productId,
            String previousCategoryId, Object params, FullWebappInfo targetWebappInfo, Boolean fullPath, Boolean secure,
            String viewSize, String viewIndex, String viewSort, String searchString) {
            Severity: Major
            Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 1 hr to fix

              Method makeCatalogAltLink has 14 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public static String makeCatalogAltLink(HttpServletRequest request, HttpServletResponse response, Locale locale, String productCategoryId, String productId, String previousCategoryId,
            Object params, Boolean fullPath, Boolean secure, Boolean encode,
            String viewSize, String viewIndex, String viewSort, String searchString) {
              Severity: Major
              Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 1 hr to fix

                Method makeCategoryAltUrl has 13 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                            public String makeCategoryAltUrl(Delegator delegator, LocalDispatcher dispatcher, Locale locale, List<String> trail,
                    FullWebappInfo targetWebappInfo, String currentCatalogId, String previousCategoryId, String productCategoryId, String productId,
                    String viewSize, String viewIndex, String viewSort, String searchString) {
                Severity: Major
                Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 1 hr to fix

                  Method makeCategoryAltUrl has 13 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          public abstract String makeCategoryAltUrl(Delegator delegator, LocalDispatcher dispatcher, Locale locale, List<String> trail, FullWebappInfo targetWebappInfo, String currentCatalogId, String previousCategoryId, String productCategoryId, String productId, String viewSize, String viewIndex, String viewSort, String searchString);
                  Severity: Major
                  Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 1 hr to fix

                    Method makeCategoryUrl has 11 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public static String makeCategoryUrl(Delegator delegator, CategoryContentWrapper wrapper, List<String> trail, String contextPath, String previousCategoryId, String productCategoryId, String productId, String viewSize, String viewIndex, String viewSort, String searchString) {
                    Severity: Major
                    Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 1 hr to fix

                      Method makeCategoryAltUrl has 9 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                                  public String makeCategoryAltUrl(HttpServletRequest request, Locale locale, String previousCategoryId,
                    String productCategoryId, String productId, String viewSize, String viewIndex, String viewSort,
                    String searchString) {
                      Severity: Major
                      Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 1 hr to fix

                        Method makeCategoryAltUrl has 9 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                public abstract String makeCategoryAltUrl(HttpServletRequest request, Locale locale, String previousCategoryId, String productCategoryId, String productId, String viewSize, String viewIndex, String viewSort, String searchString);
                        Severity: Major
                        Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 1 hr to fix

                          Method makeProductAltUrl has 9 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                      public String makeProductAltUrl(Delegator delegator, LocalDispatcher dispatcher, Locale locale, List<String> trail,
                    FullWebappInfo targetWebappInfo, String currentCatalogId, String previousCategoryId, String productCategoryId, String productId) {
                          Severity: Major
                          Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 1 hr to fix

                            Method makeProductAltUrl has 9 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                    public abstract String makeProductAltUrl(Delegator delegator, LocalDispatcher dispatcher, Locale locale, List<String> trail, FullWebappInfo targetWebappInfo, String currentCatalogId, String previousCategoryId, String productCategoryId, String productId);
                            Severity: Major
                            Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 1 hr to fix

                              Method makeCategoryUrl has 8 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  public static String makeCategoryUrl(HttpServletRequest request, String previousCategoryId, String productCategoryId, String productId, String viewSize, String viewIndex, String viewSort, String searchString) {
                              Severity: Major
                              Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 1 hr to fix

                                Method makeProductUrl has 7 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                    public static String makeProductUrl(Delegator delegator, ProductContentWrapper wrapper, List<String> trail, String contextPath, String previousCategoryId, String productCategoryId, String productId) {
                                Severity: Major
                                Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 50 mins to fix

                                  Method getTrailElementsAndUpdateRequestAndTrail has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                      public static void getTrailElementsAndUpdateRequestAndTrail(HttpServletRequest request, Delegator delegator, String productId,
            String productCategoryId, List<String> trailCategoryIds, String topCategoryId) {
                                  Severity: Minor
                                  Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 45 mins to fix

                                    Avoid deeply nested control flow statements.
                                    Open

                                                            if (UtilValidate.isNotEmpty(ElectronicText)) {
                            String textData = (String) ElectronicText.get("textData");
                            if (UtilValidate.isNotEmpty(textData)) {
                                textData = UrlServletHelper.invalidCharacter(textData);
                                if (alternativeUrl.matches(textData + ".+$")) {
                                    Severity: Major
                                    Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 45 mins to fix

                                      Avoid deeply nested control flow statements.
                                      Open

                                                              if (UtilValidate.isNotEmpty(ElectronicText)) {
                            String textData = (String) ElectronicText.get("textData");
                            if (UtilValidate.isNotEmpty(textData)) {
                                textData = UrlServletHelper.invalidCharacter(textData);
                                if (alternativeUrl.matches(textData + ".+$")) {
                                      Severity: Major
                                      Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 45 mins to fix

                                        Avoid deeply nested control flow statements.
                                        Open

                                                                if (UtilValidate.isNotEmpty(ElectronicText)) {
                            String textData = (String) ElectronicText.get("textData");
                            if (UtilValidate.isNotEmpty(textData)) {
                                textData = UrlServletHelper.invalidCharacter(textData);
                                if (alternativeUrl.matches(textData + ".+$")) {
                                        Severity: Major
                                        Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 45 mins to fix

                                          Avoid deeply nested control flow statements.
                                          Open

                                                                  if (UtilValidate.isNotEmpty(ElectronicText)) {
                            String textData = (String) ElectronicText.get("textData");
                            textData = UrlServletHelper.invalidCharacter(textData);
                            if (alternativeUrl.matches(textData + ".+$")) {
                                String productIdStr = null;
                                          Severity: Major
                                          Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 45 mins to fix

                                            Method makeProductAltUrl has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                            Open

                                                        public String makeProductAltUrl(HttpServletRequest request, Locale locale, String previousCategoryId, String productCategoryId,
                    String productId) {
                                            Severity: Minor
                                            Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 35 mins to fix

                                              Method makeProductAltUrl has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                              Open

                                                      public abstract String makeProductAltUrl(HttpServletRequest request, Locale locale, String previousCategoryId, String productCategoryId, String productId);
                                              Severity: Minor
                                              Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 35 mins to fix

                                                Method updateRequestAndTrail has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                                Open

                                                    public static void updateRequestAndTrail(HttpServletRequest request, String categoryId, String productId, List<String> pathElements, List<String> trail) {
                                                Severity: Minor
                                                Found in applications/product/src/org/ofbiz/product/category/CatalogUrlFilter.java - About 35 mins to fix

                                                  There are no issues that match your filters.

                                                  Category
                                                  Status