ilscipio/scipio-erp

View on GitHub
applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementServices.java

Summary

Maintainability
D
3 days
Test Coverage

Method scaleImageMangementInAllSize has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public static Map<String, Object> scaleImageMangementInAllSize(Map<String, ? extends Object> context, String filenameToUse, String resizeType, String productId,
                                                                   String imageProfile, Map<String, Object> imageWriteOptions) throws IllegalArgumentException, ImagingOpException, IOException {

    Method createContentAndDataResource has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public static Map<String, Object> createContentAndDataResource(DispatchContext dctx, GenericValue userLogin, String filenameToUse, String imageUrl, String contentId, String fileContentType){

      Method createContentThumbnail has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public static Map<String, Object> createContentThumbnail(DispatchContext dctx, Map<String, ? extends Object> context, GenericValue userLogin, ByteBuffer imageData, String productId, String imageName){

        Avoid deeply nested control flow statements.
        Open

                                    if (dataResourceAssocUp != null) {
                                        Map<String, Object> dataResourceAssocMap = new HashMap<>();
                                        dataResourceAssocMap.put("dataResourceId", dataResourceAssocUp.getString("dataResourceId"));
                                        dataResourceAssocMap.put("objectInfo", imageUrlAssoc);
                                        dataResourceAssocMap.put("dataResourceName", filenameToUseAssoc);

          Avoid deeply nested control flow statements.
          Open

                                  if (!created) {
                                      String errMsg = UtilProperties.getMessage(resourceError, "ScaleImage.unable_to_create_target_directory", locale) + " - " + targetDirectory;
                                      Debug.logFatal(errMsg, module);
                                      return ServiceUtil.returnError(errMsg);
                                  }

            Method resizeImage has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public static Map<String, Object> resizeImage(BufferedImage bufImg, double imgHeight, double imgWidth, double resizeHeight, double resizeWidth) {

              Avoid too many return statements within this method.
              Open

                                  return ServiceUtil.returnError(e.getMessage());

                Avoid too many return statements within this method.
                Open

                                return ServiceUtil.returnError(e.getMessage());

                  Avoid too many return statements within this method.
                  Open

                              return ServiceUtil.returnError(UtilProperties.getMessage(resourceError,
                                      "ProductImageViewUnableWriteBinaryData",
                                      UtilMisc.toMap("fileName", fileOriginalThumb.getAbsolutePath()), locale));

                    Avoid too many return statements within this method.
                    Open

                                    return ServiceUtil.returnError(e.getMessage());

                      Avoid too many return statements within this method.
                      Open

                                              return ServiceUtil.returnError(e.getMessage());

                        Avoid too many return statements within this method.
                        Open

                                                    return ServiceUtil.returnError(e.getMessage());

                          Avoid too many return statements within this method.
                          Open

                                  return result;

                            Avoid too many return statements within this method.
                            Open

                                    return ServiceUtil.returnError(errMsg);

                              Avoid too many return statements within this method.
                              Open

                                      return ServiceUtil.returnSuccess(successMsg);

                                Avoid too many return statements within this method.
                                Open

                                                                    return ServiceUtil.returnError(e.getMessage());

                                  Avoid too many return statements within this method.
                                  Open

                                                      return ServiceUtil.returnError(errMsg);

                                    Avoid too many return statements within this method.
                                    Open

                                                return ServiceUtil.returnError(errMsg);

                                      Avoid too many return statements within this method.
                                      Open

                                                                      return ServiceUtil.returnError(e.getMessage());

                                        Avoid too many return statements within this method.
                                        Open

                                                return ServiceUtil.returnSuccess(successMsg);

                                          Avoid too many return statements within this method.
                                          Open

                                                              return ServiceUtil.returnError(UtilProperties.getMessage(resourceError,
                                                                      "ProductImageViewUnableWriteFile", UtilMisc.toMap("fileName", file.getAbsolutePath()), locale));

                                            Avoid too many return statements within this method.
                                            Open

                                                                return ServiceUtil.returnError(UtilProperties.getMessage(resourceError,
                                                                        "ProductImageViewUnableWriteBinaryData", UtilMisc.toMap("fileName", fileOriginal.getAbsolutePath()), locale));

                                              Avoid too many return statements within this method.
                                              Open

                                                              return ServiceUtil.returnError(e.getMessage());

                                                Avoid too many return statements within this method.
                                                Open

                                                                                        return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));

                                                  Avoid too many return statements within this method.
                                                  Open

                                                                      return ServiceUtil.returnError(UtilProperties.getMessage(resourceError,
                                                                              "ProductImageViewUnableWriteFile", UtilMisc.toMap("fileName", fileOriginal.getAbsolutePath()), locale));

                                                    Avoid too many return statements within this method.
                                                    Open

                                                                        return ServiceUtil.returnError(e.getMessage());

                                                      Avoid too many return statements within this method.
                                                      Open

                                                                  return ServiceUtil.returnError(e.getMessage());

                                                        Avoid too many return statements within this method.
                                                        Open

                                                                    return ServiceUtil.returnError(e.getMessage());

                                                          Avoid too many return statements within this method.
                                                          Open

                                                                              return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));

                                                            Avoid too many return statements within this method.
                                                            Open

                                                                                    return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));

                                                              Avoid too many return statements within this method.
                                                              Open

                                                                                          return ServiceUtil.returnError(e.getMessage());

                                                                Avoid too many return statements within this method.
                                                                Open

                                                                            return ServiceUtil.returnError(e.getMessage());

                                                                  Avoid too many return statements within this method.
                                                                  Open

                                                                                  return ServiceUtil.returnError(e.getMessage());

                                                                    Avoid too many return statements within this method.
                                                                    Open

                                                                                            return result;

                                                                      Avoid too many return statements within this method.
                                                                      Open

                                                                              return result;

                                                                        Avoid too many return statements within this method.
                                                                        Open

                                                                                                        return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));

                                                                          Avoid too many return statements within this method.
                                                                          Open

                                                                                                      return ServiceUtil.returnError(e.getMessage());

                                                                            Avoid too many return statements within this method.
                                                                            Open

                                                                                                            return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));

                                                                              Avoid too many return statements within this method.
                                                                              Open

                                                                                                  return ServiceUtil.returnError(UtilProperties.getMessage(resourceError,
                                                                                                          "ProductImageViewUnableWriteBinaryData", UtilMisc.toMap("fileName", file.getAbsolutePath()), locale));

                                                                                Avoid too many return statements within this method.
                                                                                Open

                                                                                                    return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));

                                                                                  Avoid too many return statements within this method.
                                                                                  Open

                                                                                                      return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));

                                                                                    Avoid too many return statements within this method.
                                                                                    Open

                                                                                                            return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));

                                                                                      Avoid too many return statements within this method.
                                                                                      Open

                                                                                              return result;

                                                                                        Avoid too many return statements within this method.
                                                                                        Open

                                                                                                    return result;

                                                                                          Avoid too many return statements within this method.
                                                                                          Open

                                                                                                              return ServiceUtil.returnError(e.getMessage());

                                                                                            Avoid too many return statements within this method.
                                                                                            Open

                                                                                                                        return ServiceUtil.returnError(UtilProperties.getMessage("CommonErrorUiLabels", "ImageTransform.unable_to_read_image", locale));

                                                                                              There are no issues that match your filters.

                                                                                              Category
                                                                                              Status