ilscipio/scipio-erp

View on GitHub
applications/product/src/org/ofbiz/product/product/ProductServices.java

Summary

Maintainability
F
4 days
Test Coverage

ProductServices has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

public class ProductServices {

    private static final Debug.OfbizLogger module = Debug.getOfbizLogger(java.lang.invoke.MethodHandles.lookup().lookupClass());
    public static final String resource = "ProductUiLabels";
    public static final String resourceError = "ProductErrorUiLabels";

    Method uploadImage has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        private static Map<String, Object> uploadImage(Map<String, ?> context, LocalDispatcher dispatcher, Delegator delegator, String id,
                                                       String contentTypeId, String location, ByteBuffer imageData, Locale locale, Map<String, String> entityInfo) {

      Method addImageResource has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private static Map<String,Object> addImageResource(LocalDispatcher dispatcher, Delegator delegator, Map<String, ? extends Object> context,
                  String imageUrl, String id, String contentTypeId, Map<String, String> entityInfo) {
      Severity: Major
      Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 50 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if (availableToPromiseTotal != null && availableToPromiseTotal.compareTo(BigDecimal.ZERO) > 0) {
                                    // refresh the product so we can update it
                                    GenericValue productToUpdate = null;
                                    try {
                                        productToUpdate = EntityQuery.use(delegator).from("Product").where(product.getPrimaryKey()).queryOne();
        Severity: Major
        Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                      if (ServiceUtil.isError(serviceResult)) {
                                          return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
                                      }
          Severity: Major
          Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if (context.containsKey("imageProfile")) { // SCIPIO
                                        Map<String, Object> contentCtx = new HashMap<>();
                                        contentCtx.put("contentId", contentId);
                                        contentCtx.put("mediaProfile", context.get("imageProfile"));
                                        contentCtx.put("userLogin", userLogin);
            Severity: Major
            Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                          if (ServiceUtil.isError(invRes)) {
                                              return ServiceUtil.returnError(ServiceUtil.getErrorMessage(invRes));
                                          }
              Severity: Major
              Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                            if (ServiceUtil.isError(serviceResult)) {
                                                return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
                                            }
                Severity: Major
                Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                          if (dataResource != null) {
                                              dataResourceCtx.put("dataResourceId", dataResource.getString("dataResourceId"));
                                              try {
                                                  Map<String, Object> serviceResult = dispatcher.runSync("updateDataResource", dataResourceCtx);
                                                  if (ServiceUtil.isError(serviceResult)) {
                  Severity: Major
                  Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 45 mins to fix

                    Method makeGroup has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        private static Map<String, Object> makeGroup(Delegator delegator, Map<String, List<String>> featureList, List<String> items, List<String> order, int index)
                    Severity: Minor
                    Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 35 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return ServiceUtil.returnError(e.getMessage());
                      Severity: Major
                      Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return result;
                        Severity: Major
                        Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                  return result;
                          Severity: Major
                          Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                                    return ServiceUtil.returnError(e.getMessage());
                            Severity: Major
                            Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                                      return ServiceUtil.returnError(e.getMessage());
                              Severity: Major
                              Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                        return ServiceUtil.returnSuccess();
                                Severity: Major
                                Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                                                  return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
                                  Severity: Major
                                  Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                                return ServiceUtil.returnError(e.getMessage());
                                    Severity: Major
                                    Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                                          return ServiceUtil.returnError(e.getMessage());
                                      Severity: Major
                                      Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                        Avoid too many return statements within this method.
                                        Open

                                                                return ServiceUtil.returnError(e.getMessage());
                                        Severity: Major
                                        Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                          Avoid too many return statements within this method.
                                          Open

                                                                  return ServiceUtil.returnError(e.getMessage());
                                          Severity: Major
                                          Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                            Avoid too many return statements within this method.
                                            Open

                                                    return ServiceUtil.returnSuccess();
                                            Severity: Major
                                            Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                              Avoid too many return statements within this method.
                                              Open

                                                                              return ServiceUtil.returnError(e.getMessage());
                                              Severity: Major
                                              Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                Avoid too many return statements within this method.
                                                Open

                                                                                    return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
                                                Severity: Major
                                                Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                  Avoid too many return statements within this method.
                                                  Open

                                                                              return ServiceUtil.returnError(e.getMessage());
                                                  Severity: Major
                                                  Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                    Avoid too many return statements within this method.
                                                    Open

                                                                                return ServiceUtil.returnError(e.getMessage());
                                                    Severity: Major
                                                    Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                      Avoid too many return statements within this method.
                                                      Open

                                                                                      return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
                                                      Severity: Major
                                                      Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                        Avoid too many return statements within this method.
                                                        Open

                                                                                        return ServiceUtil.returnError(e.getMessage());
                                                        Severity: Major
                                                        Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                          Avoid too many return statements within this method.
                                                          Open

                                                                              return ServiceUtil.returnError(e.getMessage());
                                                          Severity: Major
                                                          Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                            Avoid too many return statements within this method.
                                                            Open

                                                                                            return ServiceUtil.returnError(e.getMessage());
                                                            Severity: Major
                                                            Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                              Avoid too many return statements within this method.
                                                              Open

                                                                     return ServiceUtil.returnSuccess();
                                                              Severity: Major
                                                              Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                Avoid too many return statements within this method.
                                                                Open

                                                                                                return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
                                                                Severity: Major
                                                                Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                  Avoid too many return statements within this method.
                                                                  Open

                                                                                                  return ServiceUtil.returnError(e.getMessage());
                                                                  Severity: Major
                                                                  Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                    Avoid too many return statements within this method.
                                                                    Open

                                                                            return addImageResource(dispatcher, delegator, context, imageUrl, id, contentTypeId, entityInfo);
                                                                    Severity: Major
                                                                    Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                      Avoid too many return statements within this method.
                                                                      Open

                                                                                              return ServiceUtil.returnError(e.getMessage());
                                                                      Severity: Major
                                                                      Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                        Avoid too many return statements within this method.
                                                                        Open

                                                                                                        return ServiceUtil.returnError(e.getMessage());
                                                                        Severity: Major
                                                                        Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                          Avoid too many return statements within this method.
                                                                          Open

                                                                                          return ServiceUtil.returnError(UtilProperties.getMessage(resource,
                                                                                                  "ProductFeatureTreeCannotCallIsStoreInventoryRequired", locale));
                                                                          Severity: Major
                                                                          Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                            Avoid too many return statements within this method.
                                                                            Open

                                                                                                            return ServiceUtil.returnError(ServiceUtil.getErrorMessage(dataResourceResult));
                                                                            Severity: Major
                                                                            Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                              Avoid too many return statements within this method.
                                                                              Open

                                                                                                          return ServiceUtil.returnError(e.getMessage());
                                                                              Severity: Major
                                                                              Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                                Avoid too many return statements within this method.
                                                                                Open

                                                                                                            return ServiceUtil.returnError(e.getMessage());
                                                                                Severity: Major
                                                                                Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                                  Avoid too many return statements within this method.
                                                                                  Open

                                                                                              return ServiceUtil.returnError(UtilProperties.getMessage(resourceError,
                                                                                                      "productservices.empty_list_of_selectable_features_found", locale));
                                                                                  Severity: Major
                                                                                  Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                                    Avoid too many return statements within this method.
                                                                                    Open

                                                                                            return result;
                                                                                    Severity: Major
                                                                                    Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                                      Avoid too many return statements within this method.
                                                                                      Open

                                                                                                          return ServiceUtil.returnError(e.getMessage());
                                                                                      Severity: Major
                                                                                      Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                                        Avoid too many return statements within this method.
                                                                                        Open

                                                                                                                            return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
                                                                                        Severity: Major
                                                                                        Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                                          Avoid too many return statements within this method.
                                                                                          Open

                                                                                                                              return ServiceUtil.returnError(ServiceUtil.getErrorMessage(dataResourceResult));
                                                                                          Severity: Major
                                                                                          Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                                            Avoid too many return statements within this method.
                                                                                            Open

                                                                                                    return ServiceUtil.returnSuccess();
                                                                                            Severity: Major
                                                                                            Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                                              Avoid too many return statements within this method.
                                                                                              Open

                                                                                                              return ServiceUtil.returnError(UtilProperties.getMessage(resource,
                                                                                                                      "ProductImageViewUnableWriteBinaryData", UtilMisc.toMap("fileName", file.getAbsolutePath()), locale));
                                                                                              Severity: Major
                                                                                              Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                                                Avoid too many return statements within this method.
                                                                                                Open

                                                                                                        return ServiceUtil.returnSuccess();
                                                                                                Severity: Major
                                                                                                Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                                                  Avoid too many return statements within this method.
                                                                                                  Open

                                                                                                                              return ServiceUtil.returnError(ServiceUtil.getErrorMessage(dataResourceResult));
                                                                                                  Severity: Major
                                                                                                  Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                                                    Avoid too many return statements within this method.
                                                                                                    Open

                                                                                                                                    return ServiceUtil.returnError(e.getMessage());
                                                                                                    Severity: Major
                                                                                                    Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                                                      Avoid too many return statements within this method.
                                                                                                      Open

                                                                                                                                  return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
                                                                                                      Severity: Major
                                                                                                      Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                                                        Avoid too many return statements within this method.
                                                                                                        Open

                                                                                                                                    return ServiceUtil.returnError(e.getMessage());
                                                                                                        Severity: Major
                                                                                                        Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                                                          Avoid too many return statements within this method.
                                                                                                          Open

                                                                                                                                              return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
                                                                                                          Severity: Major
                                                                                                          Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                                                            Avoid too many return statements within this method.
                                                                                                            Open

                                                                                                                                    return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
                                                                                                            Severity: Major
                                                                                                            Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                                                              Avoid too many return statements within this method.
                                                                                                              Open

                                                                                                                                          return ServiceUtil.returnError(ServiceUtil.getErrorMessage(serviceResult));
                                                                                                              Severity: Major
                                                                                                              Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                                                                Avoid too many return statements within this method.
                                                                                                                Open

                                                                                                                                        return ServiceUtil.returnError(e.getMessage());
                                                                                                                Severity: Major
                                                                                                                Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                                                                  Avoid too many return statements within this method.
                                                                                                                  Open

                                                                                                                                              return ServiceUtil.returnError(ServiceUtil.getErrorMessage(contentResult));
                                                                                                                  Severity: Major
                                                                                                                  Found in applications/product/src/org/ofbiz/product/product/ProductServices.java - About 30 mins to fix

                                                                                                                    There are no issues that match your filters.

                                                                                                                    Category
                                                                                                                    Status