Sign upLogin

ilscipio/scipio-erp

View on GitHub
Star
applications/product/src/org/ofbiz/shipment/packing/PackingSession.java

Summary

Maintainability
D
2 days
Test Coverage

PackingSession has 75 methods (exceeds 20 allowed). Consider refactoring.
Open

@SuppressWarnings("serial")
public class PackingSession implements java.io.Serializable {

    private static final Debug.OfbizLogger module = Debug.getOfbizLogger(java.lang.invoke.MethodHandles.lookup().lookupClass());
Severity: Major
Found in applications/product/src/org/ofbiz/shipment/packing/PackingSession.java - About 1 day to fix

    Method createPackLineItem has 10 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        protected void createPackLineItem(int checkCode, GenericValue res, String orderId, String orderItemSeqId, String shipGroupSeqId, String productId, BigDecimal quantity, BigDecimal weight, int packageSeqId, String shipmentItemSeqId) throws GeneralException {
    Severity: Major
    Found in applications/product/src/org/ofbiz/shipment/packing/PackingSession.java - About 1 hr to fix

      Method getShipmentCostEstimate has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public synchronized BigDecimal getShipmentCostEstimate(String shippingContactMechId, String shipmentMethodTypeId, String carrierPartyId, String carrierRoleTypeId, String productStoreId, List<GenericValue> shippableItemInfo, BigDecimal shippableTotal, BigDecimal shippableWeight, BigDecimal shippableQuantity) {
      Severity: Major
      Found in applications/product/src/org/ofbiz/shipment/packing/PackingSession.java - About 1 hr to fix

        Method createPackLineItem has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            protected void createPackLineItem(int checkCode, GenericValue res, String orderId, String orderItemSeqId, String shipGroupSeqId, String productId, BigDecimal quantity, BigDecimal weight, int packageSeqId) throws GeneralException {
        Severity: Major
        Found in applications/product/src/org/ofbiz/shipment/packing/PackingSession.java - About 1 hr to fix

          Method addOrIncreaseLine has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public synchronized void addOrIncreaseLine(String orderId, String orderItemSeqId, String shipGroupSeqId, String productId, BigDecimal quantity, int packageSeqId, BigDecimal weight, boolean update) throws GeneralException {
          Severity: Major
          Found in applications/product/src/org/ofbiz/shipment/packing/PackingSession.java - About 1 hr to fix

            Method checkLineForAdd has 8 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                protected int checkLineForAdd(GenericValue res, String orderId, String orderItemSeqId, String shipGroupSeqId, String productId, BigDecimal quantity, int packageSeqId, boolean update) {
            Severity: Major
            Found in applications/product/src/org/ofbiz/shipment/packing/PackingSession.java - About 1 hr to fix

              Method getShipmentCostEstimate has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public synchronized BigDecimal getShipmentCostEstimate(GenericValue orderItemShipGroup, String productStoreId, List<GenericValue> shippableItemInfo, BigDecimal shippableTotal, BigDecimal shippableWeight, BigDecimal shippableQuantity) {
              Severity: Minor
              Found in applications/product/src/org/ofbiz/shipment/packing/PackingSession.java - About 45 mins to fix

                Method findLine has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public synchronized PackingSessionLine findLine(String orderId, String orderItemSeqId, String shipGroupSeqId, String productId, String inventoryItemId, int packageSeq) {
                Severity: Minor
                Found in applications/product/src/org/ofbiz/shipment/packing/PackingSession.java - About 45 mins to fix

                  Method getPackedQuantity has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public synchronized BigDecimal getPackedQuantity(String orderId, String orderItemSeqId, String shipGroupSeqId, String productId, String inventoryItemId, int packageSeq) {
                  Severity: Minor
                  Found in applications/product/src/org/ofbiz/shipment/packing/PackingSession.java - About 45 mins to fix

                    Consider simplifying this complex logical expression.
                    Open

                                if (orderId.equals(line.getOrderId()) &&
                    orderItemSeqId.equals(line.getOrderItemSeqId()) &&
                    shipGroupSeqId.equals(line.getShipGroupSeqId()) &&
                    productId.equals(line.getProductId()) &&
                    inventoryItemId.equals(line.getInventoryItemId()) &&
                    Severity: Major
                    Found in applications/product/src/org/ofbiz/shipment/packing/PackingSession.java - About 40 mins to fix

                      Method getPackedQuantity has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          public synchronized BigDecimal getPackedQuantity(String orderId, String orderItemSeqId, String shipGroupSeqId, String productId, int packageSeq) {
                      Severity: Minor
                      Found in applications/product/src/org/ofbiz/shipment/packing/PackingSession.java - About 35 mins to fix

                        Method addOrIncreaseLine has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            public synchronized void addOrIncreaseLine(String orderId, String orderItemSeqId, String shipGroupSeqId, BigDecimal quantity, int packageSeqId) throws GeneralException {
                        Severity: Minor
                        Found in applications/product/src/org/ofbiz/shipment/packing/PackingSession.java - About 35 mins to fix

                          There are no issues that match your filters.

                          Category
                          Status