ilscipio/scipio-erp

View on GitHub
framework/base/src/org/ofbiz/base/crypto/HashCrypt.java

Summary

Maintainability
B
5 hrs
Test Coverage

HashCrypt has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

public class HashCrypt {

    private static final Debug.OfbizLogger module = Debug.getOfbizLogger(java.lang.invoke.MethodHandles.lookup().lookupClass());
    public static final String CRYPT_CHAR_SET = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789./";

Severity: Minor
Found in framework/base/src/org/ofbiz/base/crypto/HashCrypt.java - About 3 hrs to fix

    Avoid too many return statements within this method.
    Open

                    return true;
    Severity: Major
    Found in framework/base/src/org/ofbiz/base/crypto/HashCrypt.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return doComparePbkdf2(crypted, password);
      Severity: Major
      Found in framework/base/src/org/ofbiz/base/crypto/HashCrypt.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return doCompareTypePrefix(crypted, defaultCrypt, password.getBytes()); // SCIPIO: DEV NOTE: DO NOT ADD UTF-8 HERE!
        Severity: Major
        Found in framework/base/src/org/ofbiz/base/crypto/HashCrypt.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return false;
          Severity: Major
          Found in framework/base/src/org/ofbiz/base/crypto/HashCrypt.java - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status