ilscipio/scipio-erp

View on GitHub
framework/base/src/org/ofbiz/base/util/UtilValidate.java

Summary

Maintainability
F
6 days
Test Coverage

UtilValidate has 125 methods (exceeds 20 allowed). Consider refactoring.
Open

public final class UtilValidate {

    //private static final Debug.OfbizLogger module = Debug.getOfbizLogger(java.lang.invoke.MethodHandles.lookup().lookupClass());

    private UtilValidate() {}
Severity: Major
Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 2 days to fix

    Consider simplifying this complex logical expression.
    Open

            if (isMasterCard(cc) || isVisa(cc) || isAmericanExpress(cc) || isDinersClub(cc) ||
                    isDiscover(cc) || isEnRoute(cc) || isJCB(cc) || isSolo(cc)|| isSwitch (cc)|| isVisaElectron(cc)) {
                return true;
            }
    Severity: Critical
    Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 2 hrs to fix

      Method isFloat has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public static boolean isFloat(String s, boolean allowNegative, boolean allowPositive, int minDecimal, int maxDecimal) {
      Severity: Minor
      Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 35 mins to fix

        Method isDouble has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public static boolean isDouble(String s, boolean allowNegative, boolean allowPositive, int minDecimal, int maxDecimal) {
        Severity: Minor
        Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 35 mins to fix

          Avoid too many return statements within this method.
          Open

                      return passed.before(now);
          Severity: Major
          Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return true;
            Severity: Major
            Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return "CCT_ENROUTE";
              Severity: Major
              Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return "CCT_JCB";
                Severity: Major
                Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return "CCT_SOLO";
                  Severity: Major
                  Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return "[question mark found at position " + (fieldStr.indexOf('?') + 1) + "]";
                    Severity: Major
                    Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                      return true;
                      Severity: Major
                      Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return false;
                        Severity: Major
                        Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                      return false;
                          Severity: Major
                          Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                        return false;
                            Severity: Major
                            Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                          return "[less-than sign found at position " + (fieldStr.indexOf('<') + 1) + "]";
                              Severity: Major
                              Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                            return true;
                                Severity: Major
                                Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                              return "CCT_DISCOVER";
                                  Severity: Major
                                  Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                            return true;
                                    Severity: Major
                                    Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                                      return false;
                                      Severity: Major
                                      Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                        Avoid too many return statements within this method.
                                        Open

                                                    return false;
                                        Severity: Major
                                        Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                          Avoid too many return statements within this method.
                                          Open

                                                      return "CCT_SWITCH";
                                          Severity: Major
                                          Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                            Avoid too many return statements within this method.
                                            Open

                                                        return false;
                                            Severity: Major
                                            Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                              Avoid too many return statements within this method.
                                              Open

                                                          return false;
                                              Severity: Major
                                              Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                Avoid too many return statements within this method.
                                                Open

                                                            return "[greater-than sign found at position " + (fieldStr.indexOf('>') + 1) + "]";
                                                Severity: Major
                                                Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                  Avoid too many return statements within this method.
                                                  Open

                                                              return true;
                                                  Severity: Major
                                                  Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                    Avoid too many return statements within this method.
                                                    Open

                                                                return true;
                                                    Severity: Major
                                                    Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                      Avoid too many return statements within this method.
                                                      Open

                                                                  return false;
                                                      Severity: Major
                                                      Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                        Avoid too many return statements within this method.
                                                        Open

                                                                    return false;
                                                        Severity: Major
                                                        Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                          Avoid too many return statements within this method.
                                                          Open

                                                                  return true;
                                                          Severity: Major
                                                          Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                            Avoid too many return statements within this method.
                                                            Open

                                                                            return false;
                                                            Severity: Major
                                                            Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                              Avoid too many return statements within this method.
                                                              Open

                                                                          return true;
                                                              Severity: Major
                                                              Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                Avoid too many return statements within this method.
                                                                Open

                                                                            return false;
                                                                Severity: Major
                                                                Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                  Avoid too many return statements within this method.
                                                                  Open

                                                                                  return false;
                                                                  Severity: Major
                                                                  Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                    Avoid too many return statements within this method.
                                                                    Open

                                                                            return false;
                                                                    Severity: Major
                                                                    Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                      Avoid too many return statements within this method.
                                                                      Open

                                                                                  return "CCT_AMERICANEXPRESS";
                                                                      Severity: Major
                                                                      Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                        Avoid too many return statements within this method.
                                                                        Open

                                                                                    return true;
                                                                        Severity: Major
                                                                        Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                          Avoid too many return statements within this method.
                                                                          Open

                                                                                      return "[forward-slash found at position " + (fieldStr.indexOf('/') + 1) + "]";
                                                                          Severity: Major
                                                                          Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                            Avoid too many return statements within this method.
                                                                            Open

                                                                                    return "Unknown";
                                                                            Severity: Major
                                                                            Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                              Avoid too many return statements within this method.
                                                                              Open

                                                                                          return false;
                                                                              Severity: Major
                                                                              Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                                Avoid too many return statements within this method.
                                                                                Open

                                                                                            return "[back-slash found at position " + (fieldStr.indexOf('\\') + 1) + "]";
                                                                                Severity: Major
                                                                                Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                                  Avoid too many return statements within this method.
                                                                                  Open

                                                                                              return "CCT_DINERSCLUB";
                                                                                  Severity: Major
                                                                                  Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                                    Avoid too many return statements within this method.
                                                                                    Open

                                                                                                return true;
                                                                                    Severity: Major
                                                                                    Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                                      Avoid too many return statements within this method.
                                                                                      Open

                                                                                                  return true;
                                                                                      Severity: Major
                                                                                      Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                                        Avoid too many return statements within this method.
                                                                                        Open

                                                                                                    return false;
                                                                                        Severity: Major
                                                                                        Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                                          Avoid too many return statements within this method.
                                                                                          Open

                                                                                                      return true;
                                                                                          Severity: Major
                                                                                          Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                                            Avoid too many return statements within this method.
                                                                                            Open

                                                                                                        return true;
                                                                                            Severity: Major
                                                                                            Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                                              Avoid too many return statements within this method.
                                                                                              Open

                                                                                                      return false;
                                                                                              Severity: Major
                                                                                              Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                                                Avoid too many return statements within this method.
                                                                                                Open

                                                                                                            return true;
                                                                                                Severity: Major
                                                                                                Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                                                  Avoid too many return statements within this method.
                                                                                                  Open

                                                                                                              return passed.after(now);
                                                                                                  Severity: Major
                                                                                                  Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                                                    Avoid too many return statements within this method.
                                                                                                    Open

                                                                                                                return "CCT_VISAELECTRON";
                                                                                                    Severity: Major
                                                                                                    Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                                                      Avoid too many return statements within this method.
                                                                                                      Open

                                                                                                                  return false;
                                                                                                      Severity: Major
                                                                                                      Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                                                        Avoid too many return statements within this method.
                                                                                                        Open

                                                                                                                return null;
                                                                                                        Severity: Major
                                                                                                        Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                                                          Avoid too many return statements within this method.
                                                                                                          Open

                                                                                                                          return false;
                                                                                                          Severity: Major
                                                                                                          Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                                                            Avoid too many return statements within this method.
                                                                                                            Open

                                                                                                                    return false;
                                                                                                            Severity: Major
                                                                                                            Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                                                              Avoid too many return statements within this method.
                                                                                                              Open

                                                                                                                          return false;
                                                                                                              Severity: Major
                                                                                                              Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                                                                Avoid too many return statements within this method.
                                                                                                                Open

                                                                                                                                return true;
                                                                                                                Severity: Major
                                                                                                                Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                                                                  Avoid too many return statements within this method.
                                                                                                                  Open

                                                                                                                              return false;
                                                                                                                  Severity: Major
                                                                                                                  Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                                                                    Avoid too many return statements within this method.
                                                                                                                    Open

                                                                                                                                return false;
                                                                                                                    Severity: Major
                                                                                                                    Found in framework/base/src/org/ofbiz/base/util/UtilValidate.java - About 30 mins to fix

                                                                                                                      There are no issues that match your filters.

                                                                                                                      Category
                                                                                                                      Status