Sign upLogin

ilscipio/scipio-erp

View on GitHub
Star
framework/entity/src/org/ofbiz/entity/GenericDelegator.java

Summary

Maintainability
F
3 days
Test Coverage

GenericDelegator has 136 methods (exceeds 20 allowed). Consider refactoring.
Open

public class GenericDelegator implements Delegator {

    private static final Debug.OfbizLogger module = Debug.getOfbizLogger(java.lang.invoke.MethodHandles.lookup().lookupClass());

    protected ModelReader modelReader = null;
Severity: Major
Found in framework/entity/src/org/ofbiz/entity/GenericDelegator.java - About 2 days to fix

    Method findListIteratorByCondition has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public EntityListIterator findListIteratorByCondition(DynamicViewEntity dynamicViewEntity, EntityCondition whereEntityCondition, EntityCondition havingEntityCondition, Collection<String> fieldsToSelect, List<String> orderBy, EntityFindOptions findOptions) throws GenericEntityException {
    Severity: Minor
    Found in framework/entity/src/org/ofbiz/entity/GenericDelegator.java - About 45 mins to fix

      Method find has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public EntityListIterator find(String entityName, EntityCondition whereEntityCondition, EntityCondition havingEntityCondition, Set<String> fieldsToSelect, List<String> orderBy, EntityFindOptions findOptions) throws GenericEntityException {
      Severity: Minor
      Found in framework/entity/src/org/ofbiz/entity/GenericDelegator.java - About 45 mins to fix

        Method findList has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public List<GenericValue> findList(String entityName, EntityCondition entityCondition, Set<String> fieldsToSelect, List<String> orderBy, EntityFindOptions findOptions, boolean useCache) throws GenericEntityException {
        Severity: Minor
        Found in framework/entity/src/org/ofbiz/entity/GenericDelegator.java - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                      if (currentSeqId.startsWith(sequencedIdPrefix)) {
                                currentSeqId = currentSeqId.substring(sequencedIdPrefix.length());
                            } else {
                                continue;
                            }
          Severity: Major
          Found in framework/entity/src/org/ofbiz/entity/GenericDelegator.java - About 45 mins to fix

            Method createEntityAuditLogSingle has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                protected void createEntityAuditLogSingle(GenericValue value, ModelField mf, boolean isUpdate, boolean isRemove, Timestamp nowTimestamp) throws GenericEntityException {
            Severity: Minor
            Found in framework/entity/src/org/ofbiz/entity/GenericDelegator.java - About 35 mins to fix

              Method getRelated has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public List<GenericValue> getRelated(String relationName, Map<String, ? extends Object> byAndFields, List<String> orderBy, GenericValue value, boolean useCache) throws GenericEntityException {
              Severity: Minor
              Found in framework/entity/src/org/ofbiz/entity/GenericDelegator.java - About 35 mins to fix

                Avoid too many return statements within this method.
                Open

                        return helperInfo;
                Severity: Major
                Found in framework/entity/src/org/ofbiz/entity/GenericDelegator.java - About 30 mins to fix

                  There are no issues that match your filters.

                  Category
                  Status