Sign upLogin

ilscipio/scipio-erp

View on GitHub
Star
framework/webapp/src/org/ofbiz/webapp/control/ConfigXMLReader.java

Summary

Maintainability
D
2 days
Test Coverage

ControllerConfig has 37 methods (exceeds 20 allowed). Consider refactoring.
Open

    public static class ControllerConfig {
        public static final ControllerConfig NULL_CONFIG; // SCIPIO: special key for cache lookups that return null
        static {
            ControllerConfig config = null;
            try {
Severity: Minor
Found in framework/webapp/src/org/ofbiz/webapp/control/ConfigXMLReader.java - About 4 hrs to fix

    ResolvedControllerConfig has 28 methods (exceeds 20 allowed). Consider refactoring.
    Open

        public static class ResolvedControllerConfig extends ControllerConfig {

        public ResolvedControllerConfig(ControllerConfig srcConfig) throws WebAppConfigurationException {
            super(srcConfig, true);
        }
    Severity: Minor
    Found in framework/webapp/src/org/ofbiz/webapp/control/ConfigXMLReader.java - About 3 hrs to fix

      RequestResponse has 26 methods (exceeds 20 allowed). Consider refactoring.
      Open

          public static class RequestResponse {

        public static RequestResponse createEmptyNoneRequestResponse() {
            /* SCIPIO: 2018-11-07: now a dedicated constructor for this
            RequestResponse requestResponse = new RequestResponse();
      Severity: Minor
      Found in framework/webapp/src/org/ofbiz/webapp/control/ConfigXMLReader.java - About 3 hrs to fix

        Avoid deeply nested control flow statements.
        Open

                                    if (!component.enabled()) {
                                continue;
                            }
        Severity: Major
        Found in framework/webapp/src/org/ofbiz/webapp/control/ConfigXMLReader.java - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                      for(Element avdsFilterByNameElem : avsdFilterByNameElems) {
                                if ("view-name".equals(avdsFilterByNameElem.getAttribute("field"))) {
                                    NameFilter<Boolean> nameFilter = NameFilter.fromElement(avdsFilterByNameElem, Boolean.class);
                                    allowViewSaveViewNameFilters.add(nameFilter);
                                }
          Severity: Major
          Found in framework/webapp/src/org/ofbiz/webapp/control/ConfigXMLReader.java - About 45 mins to fix

            Method loadInclude has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    private void loadInclude(String includeLocation, boolean recursive, boolean optional, String order, boolean wildcard) { // SCIPIO: refactored from loadIncludes
            Severity: Minor
            Found in framework/webapp/src/org/ofbiz/webapp/control/ConfigXMLReader.java - About 35 mins to fix

              Avoid too many return statements within this method.
              Open

                                  return new IncludeAttributesSpec(includeAttr);
              Severity: Major
              Found in framework/webapp/src/org/ofbiz/webapp/control/ConfigXMLReader.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                            return new ReqAttrValueExpr(value, name);
                Severity: Major
                Found in framework/webapp/src/org/ofbiz/webapp/control/ConfigXMLReader.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                          return EVENT_MESSAGES;
                  Severity: Major
                  Found in framework/webapp/src/org/ofbiz/webapp/control/ConfigXMLReader.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                            return EVENT_MESSAGES;
                    Severity: Major
                    Found in framework/webapp/src/org/ofbiz/webapp/control/ConfigXMLReader.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return new ConstValueExpr(value);
                      Severity: Major
                      Found in framework/webapp/src/org/ofbiz/webapp/control/ConfigXMLReader.java - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                                    return new ReqParamValueExpr(value, name);
                        Severity: Major
                        Found in framework/webapp/src/org/ofbiz/webapp/control/ConfigXMLReader.java - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                          return new FlexibleValueExpr(value);
                          Severity: Major
                          Found in framework/webapp/src/org/ofbiz/webapp/control/ConfigXMLReader.java - About 30 mins to fix

                            There are no issues that match your filters.

                            Category
                            Status