framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java
RequestHandler
has 98 methods (exceeds 20 allowed). Consider refactoring. Open
Open
public class RequestHandler {
private static final Debug.OfbizLogger module = Debug.getOfbizLogger(java.lang.invoke.MethodHandles.lookup().lookupClass());
private static final boolean showSessionIdInLog = UtilProperties.propertyValueEqualsIgnoreCase("requestHandler", "show-sessionId-in-log", "Y"); // SCIPIO: made static var & remove delegator
private static final Integer sessionUnserializableLogLevel = Debug.getLevel(UtilProperties.getPropertyValue("requestHandler",
Method makeLinkAutoCore
has 14 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
private static String makeLinkAutoCore(boolean requestBased, HttpServletRequest request, HttpServletResponse response, Map<String, Object> context, String url, Boolean absPath, Boolean interWebapp, String webSiteId, Boolean controller,
Boolean fullPath, Boolean secure, Boolean encode, Delegator delegator, Locale locale) {
Method renderView
has 11 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
private void renderView(String view, boolean allowExtView, HttpServletRequest req, HttpServletResponse resp, String saveName,
ControllerConfig controllerConfig, ConfigXMLReader.ViewAsJsonConfig viewAsJsonConfig, boolean viewAsJson,
boolean allowViewSave, RequestState requestState, ConfigXMLReader.RequestMap requestMap) throws RequestHandlerException, RequestHandlerExceptionAllowExternalRequests {
Method makeLinkAuto
has 11 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
public static String makeLinkAuto(Map<String, Object> context, Delegator delegator, Locale locale, String webSiteId, String url, Boolean absPath, Boolean interWebapp, Boolean controller,
Boolean fullPath, Boolean secure, Boolean encode) {
Method makeLink
has 10 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
public static String makeLink(Delegator delegator, Locale locale, String url, FullWebappInfo targetWebappInfo, Boolean controller,
Boolean fullPath, Boolean secure, Boolean encode, FullWebappInfo currentWebappInfo, Map<String, Object> context) {
Method makeLinkAuto
has 10 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
public static String makeLinkAuto(HttpServletRequest request, HttpServletResponse response, String url, Boolean absPath, Boolean interWebapp, String webSiteId, Boolean controller,
Boolean fullPath, Boolean secure, Boolean encode) {
Method makeLink
has 9 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
public static String makeLink(HttpServletRequest request, HttpServletResponse response, String url, Boolean interWebapp, WebappInfo webappInfo, Boolean controller,
Boolean fullPath, Boolean secure, Boolean encode) {
Method makeLink
has 9 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
public static String makeLink(Map<String, Object> context, Delegator delegator, Locale locale, String url, FullWebappInfo targetWebappInfo, Boolean controller,
Boolean fullPath, Boolean secure, Boolean encode) {
Method makeLink
has 9 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
public static String makeLink(HttpServletRequest request, HttpServletResponse response, String url, Boolean interWebapp, FullWebappInfo targetWebappInfo, Boolean controller,
Boolean fullPath, Boolean secure, Boolean encode) {
Consider simplifying this complex logical expression. Open
Open
if ("logout".equals(previousRequest) || "/logout".equals(previousRequest) || "login".equals(previousRequest) || "/login".equals(previousRequest) || "checkLogin".equals(previousRequest) || "/checkLogin".equals(previousRequest) || "/checkLogin/login".equals(previousRequest)) {
// SCIPIO: This is likely to happen, so should not be a warning
//Debug.logWarning("Found special _PREVIOUS_REQUEST_ of [" + previousRequest + "], setting to null to avoid problems, not running request again", module);
Debug.logInfo("Found special _PREVIOUS_REQUEST_ of [" + previousRequest + "], setting to null to avoid problems, not running request again", module);
} else {
Method makeLinkWithQueryString
has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
public String makeLinkWithQueryString(HttpServletRequest request, HttpServletResponse response, String url, Boolean fullPath, Boolean secure, Boolean encode,
ConfigXMLReader.RequestResponse requestResponse, Map<String, Object> extraParameters) {
Method doLinkURLEncode
has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
protected static String doLinkURLEncode(HttpServletRequest request, HttpServletResponse response, StringBuilder newURL, boolean interWebapp,
FullWebappInfo targetWebappInfo, FullWebappInfo currentWebappInfo, boolean didFullStandard, boolean didFullSecure) {
Method doLinkURLEncode
has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
protected static String doLinkURLEncode(Delegator delegator, Locale locale, StringBuilder newURL, FullWebappInfo targetWebappInfo,
FullWebappInfo currentWebappInfo, boolean didFullStandard, boolean didFullSecure, Map<String, Object> context) {
Method restoreViewParamsAndGetViewName
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
private String restoreViewParamsAndGetViewName(HttpServletRequest request, String overrideViewUri, String eventReturn,
String nextRequestResponseValue, ConfigXMLReader.RequestResponse nextRequestResponse,
RequestMap requestMap, ControllerConfig controllerConfig) throws RequestHandlerException {
Method callRedirect
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
private void callRedirect(String url, HttpServletResponse resp, HttpServletRequest req, int statusCode, AttributesSpec saveAttrMap, String httpConnectionHeader, Boolean allowCacheRedirect) throws RequestHandlerException {
Method checkFullSecureOrStandard
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
protected static Boolean checkFullSecureOrStandard(HttpServletRequest request, Boolean isCurrentSecure, WebSiteProperties webSiteProps, ConfigXMLReader.RequestMap requestMap,
Boolean interWebapp, Boolean fullPath, Boolean secure) {
Method runEventImpl
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
private Object runEventImpl(HttpServletRequest request, HttpServletResponse response, List<ConfigXMLReader.ValueExpr> synchronizeExprList, int synchronizeObjIndex, // SCIPIO
ConfigXMLReader.Event event, ConfigXMLReader.RequestMap requestMap, String trigger) throws EventHandlerException {
Method makeLinkWithQueryString
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
public String makeLinkWithQueryString(HttpServletRequest request, HttpServletResponse response, String url, Boolean fullPath, Boolean secure, Boolean encode,
ConfigXMLReader.RequestResponse requestResponse) {
Method makeLinkAuto
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
public static String makeLinkAuto(HttpServletRequest request, HttpServletResponse response, String url, Boolean absPath, Boolean interWebapp, String webSiteId, Boolean controller) {
Method isAllowViewSave
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
static boolean isAllowViewSave(String viewName, HttpServletRequest req,
ConfigXMLReader.ControllerConfig controllerConfig, ConfigXMLReader.RequestMap requestMap,
ConfigXMLReader.RequestResponse requestResponse, boolean viewAsJson, ConfigXMLReader.ViewAsJsonConfig viewAsJsonConfig) {
Method makeLinkAutoFull
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
public static String makeLinkAutoFull(HttpServletRequest request, HttpServletResponse response, String url, Boolean absPath, Boolean interWebapp, String webSiteId, Boolean controller) {
Method doRequestCore
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
private void doRequestCore(HttpServletRequest request, HttpServletResponse response, String chain,
GenericValue userLogin, Delegator delegator, RequestState requestState) throws RequestHandlerException, RequestHandlerExceptionAllowExternalRequests {
Method checkFullSecureOrStandard
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
protected static Boolean checkFullSecureOrStandard(HttpServletRequest request, WebSiteProperties webSiteProps, ConfigXMLReader.RequestMap requestMap,
Boolean interWebapp, Boolean fullPath, Boolean secure) {
Method makeLink
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
public String makeLink(HttpServletRequest request, HttpServletResponse response, String url, Boolean fullPath, Boolean secure, Boolean encode) {
Method makeUrl
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
public static String makeUrl(HttpServletRequest request, HttpServletResponse response, String url, Boolean fullPath, Boolean secure, Boolean encode) {
Method doRequest
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
private void doRequest(HttpServletRequest request, HttpServletResponse response, String chain,
GenericValue userLogin, Delegator delegator, RequestState requestState) throws RequestHandlerException, RequestHandlerExceptionAllowExternalRequests {
Consider simplifying this complex logical expression. Open
Open
if (requestResponse == null ||
("auto".equals(requestResponse.includeMode) && requestResponse.redirectParameterMap.size() == 0 && requestResponse.redirectParameterValueMap.size() == 0) ||
!"url-params".equals(requestResponse.includeMode) || "all-params".equals(requestResponse.includeMode)) {
Map<String, Object> urlParams;
if (requestResponse != null && "all-params".equals(requestResponse.includeMode)) {
Consider simplifying this complex logical expression. Open
Open
if ((Boolean.FALSE.equals(secure) && (requestMap == null || !requestMap.securityHttps)) &&
(Boolean.TRUE.equals(fullPath) || (fullPath == null && Boolean.TRUE.equals(isCurrentSecure)))) {
return Boolean.FALSE; // http://
} else if (Boolean.TRUE.equals(fullPath) // all other fullPath=true requests produce https
|| (!Boolean.TRUE.equals(isCurrentSecure) && (Boolean.TRUE.equals(secure) || (requestMap != null && requestMap.securityHttps)))) { // automatic upgrade to https
Method doRequest
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
public void doRequest(HttpServletRequest request, HttpServletResponse response, String chain,
GenericValue userLogin, Delegator delegator) throws RequestHandlerException, RequestHandlerExceptionAllowExternalRequests {
Method invoke
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
public Object invoke(Iterator<EventHandlerWrapper> handlers, Event event, RequestMap requestMap,
HttpServletRequest request, HttpServletResponse response) throws EventHandlerException {
Method invokeCore
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
private Object invokeCore(EventHandler eventHandler, Event event, RequestMap requestMap, HttpServletRequest request,
HttpServletResponse response) throws EventHandlerException {
Method makeLinkFullWithQueryString
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
public String makeLinkFullWithQueryString(HttpServletRequest request, HttpServletResponse response, String url, ConfigXMLReader.RequestResponse requestResponse, Map<String, Object> extraParameters) {
Method makeLinkWithQueryString
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
public String makeLinkWithQueryString(HttpServletRequest request, HttpServletResponse response, String url, ConfigXMLReader.RequestResponse requestResponse, Map<String, Object> extraParameters) {
Method runEvent
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
public Object runEvent(HttpServletRequest request, HttpServletResponse response,
ConfigXMLReader.Event event, ConfigXMLReader.RequestMap requestMap, String trigger) throws EventHandlerException {
Method getDefaultViewLastView
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
String getDefaultViewLastView(String viewName, ConfigXMLReader.RequestResponse nextRequestResponse, RequestMap requestMap,
ControllerConfig controllerConfig, HttpServletRequest request) throws RequestHandlerException {
Avoid too many return
statements within this method. Open
Open
return null;
Avoid too many return
statements within this method. Open
Open
return null;
Avoid too many return
statements within this method. Open
Open
return null;
Avoid too many return
statements within this method. Open
Open
return makeLink(request, response, relUrl, interWebapp, targetWebappInfo, controller, fullPath, secure, encode);
Avoid too many return
statements within this method. Open
Open
return null;
Avoid too many return
statements within this method. Open
Open
return null;
Avoid too many return
statements within this method. Open
Open
return null;
Avoid too many return
statements within this method. Open
Open
return null;
Avoid too many return
statements within this method. Open
Open
return null;
Avoid too many return
statements within this method. Open
Open
return encodedUrl;
Avoid too many return
statements within this method. Open
Open
return null;
Avoid too many return
statements within this method. Open
Open
return null;
Avoid too many return
statements within this method. Open
Open
return null;
Avoid too many return
statements within this method. Open
Open
return null;
Avoid too many return
statements within this method. Open
Open
return makeLink(delegator, locale, relUrl, targetWebappInfo, controller, fullPath, secure, encode, currentWebappInfo, context);
Avoid too many return
statements within this method. Open
Open
return null;
Avoid too many return
statements within this method. Open
Open
return null;
Avoid too many return
statements within this method. Open
Open
return encodedUrl;