Sign upLogin

ilscipio/scipio-erp

View on GitHub
Star
framework/widget/src/org/ofbiz/widget/model/ModelMenu.java

Summary

Maintainability
F
3 days
Test Coverage

ModelMenu has 131 methods (exceeds 20 allowed). Consider refactoring.
Open

@SuppressWarnings("serial")
public class ModelMenu extends ModelMenuCommon implements ModelWidget.IdAttrWidget { // SCIPIO: new comon base class to share with sub-menu

    /*
     * ----------------------------------------------------------------------- *
Severity: Major
Found in framework/widget/src/org/ofbiz/widget/model/ModelMenu.java - About 2 days to fix

    Method processIncludeMenuItems has 15 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        void processIncludeMenuItems(Element parentElement, List<? extends Element> preInclElements, List<? extends Element> postInclElements, List<ModelMenuItem> menuItemList,
            Map<String, ModelMenuItem> menuItemMap, Map<String, ModelMenuItemAlias> menuItemAliasMap, boolean includeMenuItemAliases, String currResource,
            boolean processIncludes, Set<String> excludeItems, String subMenusFilter, String forceSubMenuModelScope,
            ModelSubMenu parentSubMenu, CurrentMenuDefBuildArgs currentMenuDefBuildArgs, GeneralBuildArgs genBuildArgs) {
    Severity: Major
    Found in framework/widget/src/org/ofbiz/widget/model/ModelMenu.java - About 1 hr to fix

      Method processIncludeActions has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          void processIncludeActions(Element parentElement, List<? extends Element> preInclElements, List<? extends Element> postInclElements, List<ModelAction> actions,
            String currResource, boolean processIncludes, CurrentMenuDefBuildArgs currentMenuDefBuildArgs, GeneralBuildArgs genBuildArgs) {
      Severity: Major
      Found in framework/widget/src/org/ofbiz/widget/model/ModelMenu.java - About 1 hr to fix

        Method loadIncludedMenu has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            Element loadIncludedMenu(String menuName, String resource,
            Element currMenuElem, String currResource,
            Map<String, Element> menuElemCache, boolean useCache, boolean cacheConsume) {
        Severity: Major
        Found in framework/widget/src/org/ofbiz/widget/model/ModelMenu.java - About 50 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if ("extends-only".equals(inclRecursive) || "full".equals(inclRecursive)) {
                            String extendedResource = includedMenuElem.getAttribute("extends-resource");
                            String extendedMenuName = includedMenuElem.getAttribute("extends");
                            String extendedNextResource = UtilValidate.isNotEmpty(extendedResource) ? extendedResource : nextResource;
          Severity: Major
          Found in framework/widget/src/org/ofbiz/widget/model/ModelMenu.java - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if ("includes-only".equals(inclRecursive) || "full".equals(inclRecursive)) {
                            processIncludeMenuItems(includedMenuElem, null, null, menuItemList, menuItemMap, menuItemAliasMap, nextIncludeMenuItemAliases,
                                    nextResource, true, inclExcludeItems, nextSubMenusFilter, includedForceSubMenuModelScope, parentSubMenu,
                                    includedNextCurrentMenuDefBuildArgs, genBuildArgs);
                        } else {
            Severity: Major
            Found in framework/widget/src/org/ofbiz/widget/model/ModelMenu.java - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                      if ("includes-only".equals(inclRecursive) || "full".equals(inclRecursive)) {
                            processIncludeActions(includedMenuElem, null, null, actions,
                                    nextResource, true,
                                    includedNextCurrentMenuDefBuildArgs, genBuildArgs);
                        } else {
              Severity: Major
              Found in framework/widget/src/org/ofbiz/widget/model/ModelMenu.java - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        if (UtilValidate.isEmpty(includedForceSubMenuModelScope)) {
                            includedForceSubMenuModelScope = includedMenuModel.forceAllSubMenuModelScope;
                        }
                Severity: Major
                Found in framework/widget/src/org/ofbiz/widget/model/ModelMenu.java - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                          if ("extends-only".equals(inclRecursive) || "full".equals(inclRecursive)) {
                            String extendedResource = includedMenuElem.getAttribute("extends-resource");
                            String extendedMenuName = includedMenuElem.getAttribute("extends");
                            String extendedNextResource = UtilValidate.isNotEmpty(extendedResource) ? extendedResource : nextResource;
                            if (UtilValidate.isNotEmpty(extendedMenuName)) {
                  Severity: Major
                  Found in framework/widget/src/org/ofbiz/widget/model/ModelMenu.java - About 45 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return new MenuAndItemLookup(null, menuItem, subMenuName, mappedMenuItemName, menuItemName, null);
                    Severity: Major
                    Found in framework/widget/src/org/ofbiz/widget/model/ModelMenu.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                          return new MenuAndItemLookup(subMenu.getParentMenuItem().getParentSubMenu(), subMenu.getParentMenuItem(),
                            subMenuName, mappedMenuItemName, menuItemName, subMenu);
                      Severity: Major
                      Found in framework/widget/src/org/ofbiz/widget/model/ModelMenu.java - About 30 mins to fix

                        There are no issues that match your filters.

                        Category
                        Status