Sign upLogin

imagecms/ImageCMS

View on GitHub
Star
application/helpers/rules_helper.php

Summary

Maintainability
B
5 hrs
Test Coverage

Function admin_or_redirect has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    function admin_or_redirect() {
        if (PHP_SAPI == 'cli') {
            return true;
        }
        $ci = & get_instance();
Severity: Minor
Found in application/helpers/rules_helper.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_permissions_array has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function get_permissions_array() {
        $all_perms = [
                      'cp_access'              => lang('Access Control Panel', 'admin'),
                      'cp_autoupdate'          => lang('System update', 'admin'),
                      'cp_page_search'         => lang('Find pages in the control panel', 'admin'),
Severity: Minor
Found in application/helpers/rules_helper.php - About 1 hr to fix

Function cp_check_perm has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    function cp_check_perm($perm) {
        $ci = & get_instance();

        if ($ci->dx_auth->is_logged_in()) {
            if ($ci->dx_auth->get_permission_value($perm)) {
Severity: Minor
Found in application/helpers/rules_helper.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function check_perm has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    function check_perm($perm) {
        $ci = & get_instance();

        if ($ci->dx_auth->is_logged_in()) {
            if ($ci->dx_auth->get_permission_value($perm)) {
Severity: Minor
Found in application/helpers/rules_helper.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status