Sign upLogin

imagecms/ImageCMS

View on GitHub
Star
application/libraries/lib_csrf.php

Summary

Maintainability
B
5 hrs
Test Coverage

Function check_token has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    private function check_token() {
        $this->addDisabledCsrfUrls();
        if (count($_POST) > 0) {
            if (defined('ICMS_DISBALE_CSRF') AND ICMS_DISBALE_CSRF === TRUE) {
                return TRUE;
Severity: Minor
Found in application/libraries/lib_csrf.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function addDisabledCsrfUrls has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    private function addDisabledCsrfUrls() {

        // Diable CSRF library form web money service
        $ci = $this->ci;
        if ($ci->uri->segment(1) == 'shop' && $ci->uri->segment(2) == 'cart' && $ci->uri->segment(3) == 'view' && $ci->input->get('result') == 'true' && $ci->input->get('pm') > 0) {
Severity: Minor
Found in application/libraries/lib_csrf.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addDisabledCsrfUrls has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function addDisabledCsrfUrls() {

        // Diable CSRF library form web money service
        $ci = $this->ci;
        if ($ci->uri->segment(1) == 'shop' && $ci->uri->segment(2) == 'cart' && $ci->uri->segment(3) == 'view' && $ci->input->get('result') == 'true' && $ci->input->get('pm') > 0) {
Severity: Minor
Found in application/libraries/lib_csrf.php - About 1 hr to fix

There are no issues that match your filters.

Category
Status