Function register
has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring. Open
public function register() {
if (!$this->dx_auth->is_logged_in() AND $this->dx_auth->allow_registration) {
$val = $this->form_validation;
// Set form validation rules
$this->form_validation->set_message('required', lang('The %s is required', 'auth'));
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File authapi.php
has 335 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
use CMSFactory\Events;
(defined('BASEPATH')) OR exit('No direct script access allowed');
- Create a ticketCreate a ticket
Method register
has 73 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function register() {
if (!$this->dx_auth->is_logged_in() AND $this->dx_auth->allow_registration) {
$val = $this->form_validation;
// Set form validation rules
$this->form_validation->set_message('required', lang('The %s is required', 'auth'));
- Create a ticketCreate a ticket
Function login
has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
public function login() {
if (!$this->dx_auth->is_logged_in()) {
$this->form_validation->set_message('required', lang('The %s is required', 'auth'));
/** Set form validation rules */
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method login
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function login() {
if (!$this->dx_auth->is_logged_in()) {
$this->form_validation->set_message('required', lang('The %s is required', 'auth'));
/** Set form validation rules */
- Create a ticketCreate a ticket
Method change_password
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function change_password() {
/** Preprate Variables */
$jsonResponse = [];
/** Check if user logged in or not */
- Create a ticketCreate a ticket
Method cancel_account
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function cancel_account() {
// Check if user logged in or not
if ($this->dx_auth->is_logged_in()) {
$val = $this->form_validation;
// Set form validation rules
- Create a ticketCreate a ticket
Method forgot_password
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function forgot_password() {
$val = $this->form_validation;
// Set form validation rules
$this->form_validation->set_message('required', lang('The %s is required', 'auth'));
- Create a ticketCreate a ticket
Method reset_password
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function reset_password() {
// Get username and key
$email = $this->input->post('email');
$key = $this->input->post('key');
// Reset password
- Create a ticketCreate a ticket
Function change_password
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public function change_password() {
/** Preprate Variables */
$jsonResponse = [];
/** Check if user logged in or not */
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Identical blocks of code found in 2 locations. Consider refactoring. Open
foreach (ShopCore::app()->CustomFieldsHelper->getCustomFielsdAsArray('user') as $item) {
if ($item['is_active'] == 1) {
if ($item['is_required'] == 1) {
$val->set_rules('custom_field['. $item['id'] .']', lang($item['field_name']), 'trim|xss_clean|required');
- Read upRead up
- Create a ticketCreate a ticket
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 123.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76