Sign upLogin

imagecms/ImageCMS

View on GitHub
Star
application/modules/wishlist/classes/ParentWishlist.php

Summary

Maintainability
D
2 days
Test Coverage

File ParentWishlist.php has 410 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace wishlist\classes;

use CI_DB_active_record;
Severity: Minor
Found in application/modules/wishlist/classes/ParentWishlist.php - About 5 hrs to fix

ParentWishlist has 29 functions (exceeds 20 allowed). Consider refactoring.
Open

class ParentWishlist extends MY_Controller
{

    /**
     * array that contains wishlist settings
Severity: Minor
Found in application/modules/wishlist/classes/ParentWishlist.php - About 3 hrs to fix

Method _addItem has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function _addItem($varId, $listId, $listName, $userId = null) {
        if (!$userId) {
            $userId = $this->dx_auth->get_user_id();
        }
        $count_lists = 0;
Severity: Minor
Found in application/modules/wishlist/classes/ParentWishlist.php - About 1 hr to fix

Method do_upload has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function do_upload($userID = null) {

        if (!$userID) {
            $userID = $this->dx_auth->get_user_id();
        }
Severity: Minor
Found in application/modules/wishlist/classes/ParentWishlist.php - About 1 hr to fix

Function createWishList has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function createWishList($user_id, $listName, $wlType, $wlDescription) {

        if ($listName) {
            $count_lists = $this->wishlist_model->getUserWishListCount($user_id);
        }
Severity: Minor
Found in application/modules/wishlist/classes/ParentWishlist.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _addItem has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function _addItem($varId, $listId, $listName, $userId = null) {
        if (!$userId) {
            $userId = $this->dx_auth->get_user_id();
        }
        $count_lists = 0;
Severity: Minor
Found in application/modules/wishlist/classes/ParentWishlist.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method createWishList has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function createWishList($user_id, $listName, $wlType, $wlDescription) {

        if ($listName) {
            $count_lists = $this->wishlist_model->getUserWishListCount($user_id);
        }
Severity: Minor
Found in application/modules/wishlist/classes/ParentWishlist.php - About 1 hr to fix

Function deleteAllWL has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function deleteAllWL($UserID) {
        $forReturn = TRUE;

        $WLs = $this->wishlist_model->getAllUserWLs($UserID);
        if ($forReturn) {
Severity: Minor
Found in application/modules/wishlist/classes/ParentWishlist.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method moveItem has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function moveItem($varId, $wish_list_id, $to_listId = '', $to_listName = '', $user_id = null) {
Severity: Minor
Found in application/modules/wishlist/classes/ParentWishlist.php - About 35 mins to fix

Function do_upload has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function do_upload($userID = null) {

        if (!$userID) {
            $userID = $this->dx_auth->get_user_id();
        }
Severity: Minor
Found in application/modules/wishlist/classes/ParentWishlist.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

            return TRUE;
Severity: Major
Found in application/modules/wishlist/classes/ParentWishlist.php - About 30 mins to fix

Function renderUserWLEdit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function renderUserWLEdit($wish_list_id, $userID = null) {
        if ($userID === null) {
            $userID = $this->dx_auth->get_user_id();
        }
Severity: Minor
Found in application/modules/wishlist/classes/ParentWishlist.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function show has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function show($hash, $access = ['shared', 'private', 'public']) {
        if (!$hash) {
            return FALSE;
        }
Severity: Minor
Found in application/modules/wishlist/classes/ParentWishlist.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        if (iconv_strlen($wlDescription, 'UTF-8') > $this->settings['maxWLDescLenght']) {
            $wlDescription = mb_substr($wlDescription, 0, (int) $this->settings['maxWLDescLenght'], 'utf-8');
            $this->errors[] = lang('List description limit exhausted', 'wishlist') . '. ' . lang('List description max count', 'wishlist') . ' - ' . $this->settings['maxWLDescLenght'];
        }
Severity: Major
Found in application/modules/wishlist/classes/ParentWishlist.php and 3 other locations - About 1 hr to fix
application/modules/wishlist/classes/BaseApi.php on lines 243..246
application/modules/wishlist/classes/BaseWishlist.php on lines 200..203
application/modules/wishlist/classes/ParentWishlist.php on lines 408..411

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        if (mb_strlen($listName, 'utf-8') > $this->settings['maxListName']) {
            $listName = mb_substr($listName, 0, (int) $this->settings['maxListName'], 'utf-8');
            $this->errors[] = lang('Wishlist name will be changed', 'wishlist') . '. ' . lang('Maximum length of wishlist name', 'wishlist') . ' - ' . $this->settings['maxListName'];
        }
Severity: Major
Found in application/modules/wishlist/classes/ParentWishlist.php and 3 other locations - About 1 hr to fix
application/modules/wishlist/classes/BaseApi.php on lines 243..246
application/modules/wishlist/classes/BaseWishlist.php on lines 200..203
application/modules/wishlist/classes/ParentWishlist.php on lines 295..298

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status