imanel/websocket-rack

View on GitHub
example/html/FABridge.js

Summary

Maintainability
F
3 days
Test Coverage

File FABridge.js has 477 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
/*
Copyright 2006 Adobe Systems Incorporated

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"),
Severity: Minor
Found in example/html/FABridge.js - About 7 hrs to fix

    Function FABridge__bridgeInitialized has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
    Open

    function FABridge__bridgeInitialized(bridgeName) {
        var objects = document.getElementsByTagName("object");
        var ol = objects.length;
        var activeObjects = [];
        if (ol > 0) {
    Severity: Minor
    Found in example/html/FABridge.js - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    prototype has 23 functions (exceeds 20 allowed). Consider refactoring.
    Open

    {
    
    
    // bootstrapping
    
    Severity: Minor
    Found in example/html/FABridge.js - About 2 hrs to fix

      Function FABridge__bridgeInitialized has 58 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function FABridge__bridgeInitialized(bridgeName) {
          var objects = document.getElementsByTagName("object");
          var ol = objects.length;
          var activeObjects = [];
          if (ol > 0) {
      Severity: Major
      Found in example/html/FABridge.js - About 2 hrs to fix

        Function deserialize has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            deserialize: function(packedValue)
            {
        
                var result;
        
        Severity: Minor
        Found in example/html/FABridge.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function deserialize has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            deserialize: function(packedValue)
            {
        
                var result;
        
        Severity: Minor
        Found in example/html/FABridge.js - About 1 hr to fix

          Function serialize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              serialize: function(value)
              {
                  var result = {};
          
                  var t = typeof(value);
          Severity: Minor
          Found in example/html/FABridge.js - About 1 hr to fix

            Function serialize has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                serialize: function(value)
                {
                    var result = {};
            
                    var t = typeof(value);
            Severity: Minor
            Found in example/html/FABridge.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid deeply nested control flow statements.
            Open

                                if (param.nodeType == 1 && param.tagName.toLowerCase() == "param" && param["name"].toLowerCase() == "flashvars" && param["value"].indexOf(searchStr) >= 0) {
                                    FABridge.attachBridge(activeObjects[k], bridgeName);
                                        flash_found = true;
                                        break;
                                    }
            Severity: Major
            Found in example/html/FABridge.js - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if (ol > 0) {
                      for (var i = 0; i < ol; i++) {
                          if (typeof objects[i].SetVariable != "undefined") {
                              activeObjects[activeObjects.length] = objects[i];
                          }
              Severity: Major
              Found in example/html/FABridge.js and 1 other location - About 1 hr to fix
              example/html/FABridge.js on lines 119..125

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 74.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if (el > 0) {
                      for (var j = 0; j < el; j++) {
                          if (typeof embeds[j].SetVariable != "undefined") {
                              activeEmbeds[activeEmbeds.length] = embeds[j];
                          }
              Severity: Major
              Found in example/html/FABridge.js and 1 other location - About 1 hr to fix
              example/html/FABridge.js on lines 109..115

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 74.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          for (var i = 0; i < packedValue.length; i++)
                          {
                              result[i] = this.deserialize(packedValue[i]);
                          }
              Severity: Minor
              Found in example/html/FABridge.js and 1 other location - About 45 mins to fix
              example/html/FABridge.js on lines 464..467

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 50.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          for (var i = 0; i < value.length; i++)
                          {
                              result[i] = this.serialize(value[i]);
                          }
              Severity: Minor
              Found in example/html/FABridge.js and 1 other location - About 45 mins to fix
              example/html/FABridge.js on lines 504..507

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 50.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status